fix new tab opens when downloading offline #28114

StevenKKC · 2023-09-25T06:31:17Z

Details

Fixed Issues

$ #26258
PROPOSAL: #26258 (comment)

Tests

From user A, Send an attachment to user B.
Be offline for user B before opening the attachment
Click on the attachment sent from User A
Verify that there is no download button at the top

Verify that no errors appear in the JS console

Offline tests

From user A, send an attachment to user B.
Be offline for user B before opening the attachment
Click on the attachment sent from User A
Verify that there is no download button at the top

QA Steps

From user A, Send an attachment to user B.
Be offline for user B before opening the attachment
Click on the attachment sent from User A
Verify that there is no download button at the top

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Web.webm

Mobile Web - Chrome

Android-Chrome.webm

Mobile Web - Safari

iOS-Safari.webm

Desktop

Desktop.mp4

iOS

iOS.webm

Android

Android.webm

melvin-bot · 2023-09-25T06:31:22Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2023-09-25T19:54:11Z

src/components/AttachmentModal.js

@@ -350,7 +351,7 @@ function AttachmentModal(props) {
                <HeaderWithBackButton
                    title={props.headerTitle || translate(isAttachmentReceipt ? 'common.receipt' : 'common.attachment')}
                    shouldShowBorderBottom
-                    shouldShowDownloadButton={props.allowDownload && shouldShowDownloadButton && !isAttachmentReceipt}
+                    shouldShowDownloadButton={props.allowDownload && shouldShowDownloadButton && !isAttachmentReceipt && !NetworkStore.isOffline()}


Let's use network hook for this component.

I updated my code.

@StevenKKC I think you updated the wrong component. we cant use the hook outside of react component.

Sorry for my confusion. I updated my wrong code.

fedirjh · 2023-09-25T21:39:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

CleanShot.2023-09-25.at.21.18.00.mp4

Mobile Web - Safari

CleanShot.2023-09-25.at.21.04.14.mp4

Desktop

CleanShot.2023-09-25.at.21.21.15.mp4

iOS

CleanShot.2023-09-25.at.21.28.38.mp4

Android

CleanShot.2023-09-25.at.22.35.38.mp4

fedirjh · 2023-09-26T09:19:05Z

@StevenKKC I think we have an edge case in which a user opens the context menu for an attachment, then goes offline. In this scenario, the context menu is not updated immediately; instead, it will only be updated after the user closes and reopens the context menu. Is it simple to fix this case ?

CleanShot.2023-09-26.at.10.08.43.mp4

fedirjh · 2023-09-26T09:32:08Z

@StevenKKC I think we can pass the offline prop in this line , that should address the above bug :

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

Lines 62 to 63 in 85a9c5f

    
           const shouldShowFilter = (contextAction) => 
        
               contextAction.shouldShow(props.type, reportAction, props.isArchivedRoom, props.betas, props.anchor, props.isChronosReport, props.reportID, props.isPinnedChat, props.isUnreadChat);

fedirjh · 2023-09-26T19:48:38Z

We have a lint error.

fedirjh · 2023-09-26T20:01:44Z

@StevenKKC have we addressed this changes #28114 (comment) ?

StevenKKC · 2023-09-26T20:05:48Z

Not yet. could you explain in more details?

fedirjh · 2023-09-26T20:14:42Z

Not yet. could you explain in more details?

Regarding the bug, the context menu does not re-render when the network change . My suggestions, instead of using the NetworkStore.isOffline , we should update the BaseReportActionContextMenu.js to use the network hook and we pass the offline prop as a parameter to shouldShowFilter, so that when the network changes, the component will re-render and the download button is hidden immediately.

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

Lines 62 to 63 in 85a9c5f

    
           const shouldShowFilter = (contextAction) => 
        
               contextAction.shouldShow(props.type, reportAction, props.isArchivedRoom, props.betas, props.anchor, props.isChronosReport, props.reportID, props.isPinnedChat, props.isUnreadChat);

src/pages/home/report/ContextMenu/ContextMenuActions.js

fedirjh · 2023-09-26T20:40:11Z

We have a lint error as well

Co-authored-by: Fedi Rajhi <[email protected]>

fedirjh · 2023-09-26T21:17:29Z

We have a lint error as well

Lint error related to Prettier

StevenKKC · 2023-09-26T21:19:35Z

@fedirjh I am really sorry about I am out of office.

StevenKKC · 2023-09-26T21:31:57Z

I would be appreciate it if you suggest the commit.

fedirjh

No problem, I have suggested the required changes

src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

src/pages/home/report/ContextMenu/ContextMenuActions.js

Co-authored-by: Fedi Rajhi <[email protected]>

fedirjh

LGTM

OSBotify · 2023-09-27T02:32:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:18:43Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:22:38Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:51:16Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:52:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix new tab opens when downloading offline

79c2f61

StevenKKC requested a review from a team as a code owner September 25, 2023 06:31

melvin-bot bot requested review from fedirjh and removed request for a team September 25, 2023 06:31

fix lint error

8d12ce3

StevenKKC mentioned this pull request Sep 25, 2023

[HOLD for payment 2023-10-09] [$500] A new tab opens when downloading offline #26258

Closed

6 tasks

fedirjh reviewed Sep 25, 2023

View reviewed changes

StevenKKC added 3 commits September 25, 2023 19:26

use network hook

fb1dde8

Revert wrong update

d717a24

use network hook - (2)

71acc4f

Merge branch 'main' into fix26258

f5b1642

fix lint error

34a60f0

Update BaseReportActionContextMenu.js

8adaa11

fedirjh suggested changes Sep 26, 2023

View reviewed changes

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

StevenKKC and others added 3 commits September 26, 2023 17:04

Update src/pages/home/report/ContextMenu/ContextMenuActions.js

6d30612

Co-authored-by: Fedi Rajhi <[email protected]>

Update src/pages/home/report/ContextMenu/ContextMenuActions.js

c3f3b72

Co-authored-by: Fedi Rajhi <[email protected]>

Update src/pages/home/report/ContextMenu/ContextMenuActions.js

aa8b4a2

Co-authored-by: Fedi Rajhi <[email protected]>

Update ContextMenuActions.js

760ee57

fedirjh suggested changes Sep 26, 2023

View reviewed changes

src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js Outdated Show resolved Hide resolved

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

StevenKKC and others added 3 commits September 26, 2023 17:40

Update src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

3167756

Co-authored-by: Fedi Rajhi <[email protected]>

Update src/pages/home/report/ContextMenu/ContextMenuActions.js

e792362

Co-authored-by: Fedi Rajhi <[email protected]>

Update src/pages/home/report/ContextMenu/ContextMenuActions.js

629cb53

Co-authored-by: Fedi Rajhi <[email protected]>

fedirjh approved these changes Sep 26, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam September 26, 2023 21:54

thienlnam approved these changes Sep 27, 2023

View reviewed changes

thienlnam merged commit 09a0118 into Expensify:main Sep 27, 2023
12 checks passed

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix new tab opens when downloading offline #28114

fix new tab opens when downloading offline #28114

StevenKKC commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

fedirjh Sep 25, 2023

StevenKKC Sep 25, 2023

fedirjh Sep 26, 2023

StevenKKC Sep 26, 2023

fedirjh commented Sep 25, 2023

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

StevenKKC commented Sep 26, 2023

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

StevenKKC commented Sep 26, 2023

StevenKKC commented Sep 26, 2023

fedirjh left a comment

fedirjh left a comment

OSBotify commented Sep 27, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

fix new tab opens when downloading offline #28114

fix new tab opens when downloading offline #28114

Conversation

StevenKKC commented Sep 25, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 25, 2023

fedirjh Sep 25, 2023

Choose a reason for hiding this comment

StevenKKC Sep 25, 2023

Choose a reason for hiding this comment

fedirjh Sep 26, 2023

Choose a reason for hiding this comment

StevenKKC Sep 26, 2023

Choose a reason for hiding this comment

fedirjh commented Sep 25, 2023

Reviewer Checklist

Screenshots/Videos

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

StevenKKC commented Sep 26, 2023

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

fedirjh commented Sep 26, 2023

StevenKKC commented Sep 26, 2023

StevenKKC commented Sep 26, 2023

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 27, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023