[NoQA] feat: Remove moment from the project (Except Datepicker) #28175

waterim · 2023-09-25T17:04:43Z

Details

This PR is for removing all moment and changing it with date-fns (Except Datepicker)

Fixed Issues

$ #19810
PROPOSAL: #19810 (comment)

Tests

N/A

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

src/pages/settings/Profile/PersonalDetails/DateOfBirthPage.js

src/pages/wallet/WalletStatementPage.js

tests/actions/ReportTest.js

src/libs/actions/Report.js

tests/unit/CalendarPickerTest.js

situchan · 2023-09-27T18:20:59Z

Coming from #28315:
@waterim is there a reason for not removing moment from datepicker?

waterim · 2023-09-27T18:26:00Z

@situchan I wanted to split it to another(last PR), because datepicker has a loot of moment, but I can add it here if you wish

situchan · 2023-09-27T18:27:12Z

@waterim oh ok, so eventually we completely deprecate moment from the project, right?

waterim · 2023-09-27T18:28:35Z

@situchan Yes, Im finishing this transition with removing it fully, hopefully next week will be the last week(Im waiting for a bunch of regressions here)

melvin-bot · 2023-09-27T18:31:52Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…other-places

waterim · 2023-10-02T21:27:50Z

@allroundexperts Hey, do you have some updates here?

allroundexperts · 2023-10-03T03:11:23Z

@waterim Still testing. Can you please resolve conflicts?

waterim · 2023-10-03T09:35:48Z

Damn, new changes are here, will resolve

…other-places

waterim · 2023-10-03T13:26:20Z

@allroundexperts resolved everything

allroundexperts · 2023-10-03T20:26:49Z

src/libs/actions/IOU.js

@@ -110,7 +110,7 @@ Onyx.connect({
 * @param {String} id
 */
 function resetMoneyRequestInfo(id = '') {
-    const created = currentDate || moment().format('YYYY-MM-DD');
+    const created = currentDate || format(new Date(), CONST.DATE.FNS_FORMAT_STRING);


This is yyyy-MM-dd unlike YYYY-MM-DD as it was previously.

Yes, its the same, moment uses own formats, date-fns uses IANA and doesnt support YYYY-MM-DD

Not sure about this comment, the output of the date here is same as from moment, right? @allroundexperts @waterim

confirmed its the same in DM

allroundexperts · 2023-10-03T20:29:37Z

src/libs/actions/MapboxToken.js

@@ -42,7 +42,7 @@ const setExpirationTimer = () => {
    }, REFRESH_INTERVAL);
 };

-const hasTokenExpired = () => moment().isAfter(currentToken.expiration);
+const hasTokenExpired = () => isAfter(new Date(), currentToken.expiration);


I think this is incorrect. This should be isAfter(currentToken.expiration, new Date()) instead.

Also, have you tested the format of currentToken.expiration? It might be a string which will cause this to return false always.

"I think this is incorrect. This should be isAfter(currentToken.expiration, new Date()) instead."
Actually no, this is correct:
We use the isAfter function to compare the current date (new Date()) with currentToken.expiration.
The isTokenExpired variable will be true if the current date is after the expiration date, and false otherwise.

Can you post a screenshot of two dates using moment and isAfter function?

sure, one moment

new Date()
new Date(currentToken.expiration)
@allroundexperts

I'm talking about the input values themselves that you used for comparison.

Get it, will show now

looks correct

allroundexperts · 2023-10-03T20:44:53Z

src/libs/actions/User.js

@@ -460,7 +460,7 @@ function isBlockedFromConcierge(blockedFromConciergeNVP) {
        return false;
    }

-    return moment().isBefore(moment(blockedFromConciergeNVP.expiresAt), 'day');
+    return isBefore(new Date(), new Date(blockedFromConciergeNVP.expiresAt));


I think this is incorrect again. It should be isBefore(new Date(blockedFromConciergeNVP.expiresAt), new Date())

Here is correct again:
If new Date() is before new Date(blockedFromConciergeNVP.expiresAt) - it will be true

allroundexperts · 2023-10-03T20:57:50Z

src/pages/wallet/WalletStatementPage.js

+    const year = yearMonth.substring(0, 4) || getYear(new Date());
+    const month = yearMonth.substring(4) || getMonth(new Date());
+    const monthName = format(new Date(year, month), CONST.DATE.MONTH_FORMAT);


Not sure if this was wrong previously, but the two are producing different results:

Probably new one is correct, I tried with new dates and moment is showing september for some reason, but date-fns October(which is correct)

allroundexperts

Working well. We just need to sort out the usage of isBefore and isAfter.

allroundexperts · 2023-10-04T19:38:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-05.at.12.28.53.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-05.at.12.35.25.AM.mov

Mobile Web - Safari

Screen.Recording.2023-10-05.at.12.34.07.AM.mov

Desktop

Screen.Recording.2023-10-05.at.12.32.23.AM.mov

iOS

Screen.Recording.2023-10-05.at.12.34.39.AM.mov

Android

Screen.Recording.2023-10-05.at.12.36.29.AM.mov

allroundexperts

Looks good!

waterim · 2023-10-06T11:39:33Z

@mountiny Should it be merged?

mountiny

Thank you!

mountiny · 2023-10-06T14:37:16Z

src/libs/actions/IOU.js

@@ -110,7 +110,7 @@ Onyx.connect({
 * @param {String} id
 */
 function resetMoneyRequestInfo(id = '') {
-    const created = currentDate || moment().format('YYYY-MM-DD');
+    const created = currentDate || format(new Date(), CONST.DATE.FNS_FORMAT_STRING);


confirmed its the same in DM

OSBotify · 2023-10-06T14:45:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-09T23:02:31Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.80-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-11T04:42:47Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-11T05:11:41Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-13T22:00:47Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:12:50Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:29:03Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:04:28Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:16:08Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:52:28Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

waterim added 6 commits September 25, 2023 19:02

moment remov

189f2b9

additional changes

7c18da2

lint fix

503eab3

remove moment from ReportTest.js

b5016aa

remove moment from unreadIndicatorsTest.js

93813c0

remove moment from CalendarPickerTest.js

71391a1

waterim changed the title ~~feat: Remove moment from the project~~ feat: Remove moment from the project (Except Datepicker) Sep 26, 2023

fix lint

3c86b0f

adhorodyski reviewed Sep 27, 2023

View reviewed changes

src/pages/settings/Profile/PersonalDetails/DateOfBirthPage.js Show resolved Hide resolved

koko57 reviewed Sep 27, 2023

View reviewed changes

src/pages/wallet/WalletStatementPage.js Outdated Show resolved Hide resolved

koko57 reviewed Sep 27, 2023

View reviewed changes

tests/actions/ReportTest.js Outdated Show resolved Hide resolved

thiagobrez reviewed Sep 27, 2023

View reviewed changes

src/libs/actions/Report.js Show resolved Hide resolved

thiagobrez reviewed Sep 27, 2023

View reviewed changes

tests/unit/CalendarPickerTest.js Outdated Show resolved Hide resolved

pradeepmdk mentioned this pull request Sep 27, 2023

[HOLD for payment 2023-10-18] [HOLD] [$500] iOS - App crashes on accessing the Date of Birth page in Spanish language #28315

Closed

6 tasks

adjustments

0cd0b9f

waterim marked this pull request as ready for review September 27, 2023 18:31

waterim requested a review from a team as a code owner September 27, 2023 18:31

melvin-bot bot requested review from allroundexperts and removed request for a team September 27, 2023 18:31

waterim and others added 3 commits September 28, 2023 22:57

Merge remote-tracking branch 'upstream/main' into feat-19810-Replace-…

8a6dd64

…other-places

lint fix

84b7beb

Merge branch 'main' into feat-19810-Replace-other-places

42830bc

Merge branch 'main' into feat-19810-Replace-other-places

137d9aa

Merge remote-tracking branch 'upstream/main' into feat-19810-Replace-…

7538e54

…other-places

allroundexperts reviewed Oct 3, 2023

View reviewed changes

allroundexperts suggested changes Oct 3, 2023

View reviewed changes

fix

e68a84a

allroundexperts approved these changes Oct 4, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny October 4, 2023 19:38

mountiny assigned waterim Oct 4, 2023

mountiny changed the title ~~feat: Remove moment from the project (Except Datepicker)~~ [NoQA] feat: Remove moment from the project (Except Datepicker) Oct 4, 2023

mountiny approved these changes Oct 6, 2023

View reviewed changes

mountiny merged commit 5dc3c25 into Expensify:main Oct 6, 2023
16 of 21 checks passed

OSBotify mentioned this pull request Oct 9, 2023

Deploy Checklist: New Expensify 2023-10-09 #29131

Closed

64 tasks

melvin-bot bot mentioned this pull request Oct 11, 2023

[HOLD for payment 2023-11-22] [Feature request] Replace the moment library with some lightweight date utility library #19810

Closed

1 task

OSBotify mentioned this pull request Oct 11, 2023

Deploy Checklist: New Expensify 2023-10-11 #29252

Closed

[NoQA] feat: Remove moment from the project (Except Datepicker) #28175

[NoQA] feat: Remove moment from the project (Except Datepicker) #28175

Conversation

waterim commented Sep 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

situchan commented Sep 27, 2023

waterim commented Sep 27, 2023

situchan commented Sep 27, 2023

waterim commented Sep 27, 2023

melvin-bot bot commented Sep 27, 2023

waterim commented Oct 2, 2023

allroundexperts commented Oct 3, 2023

waterim commented Oct 3, 2023

waterim commented Oct 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allroundexperts left a comment

Choose a reason for hiding this comment

allroundexperts commented Oct 4, 2023

Reviewer Checklist

Screenshots/Videos

allroundexperts left a comment

Choose a reason for hiding this comment

waterim commented Oct 6, 2023

mountiny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

waterim commented Sep 25, 2023 •

edited

Loading