-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and rename Invite-Employees.md to Invite.Members.md #28276
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor changes, good job!
|
||
## Inviting Members Manually | ||
|
||
Navigate to **Settings > Policies > Group > *Policy Name* > People** - then click Invite and enter the invitee's email address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we don't want "Policy Name" to be bolded. Here's how it looks in the Google Doc:
And here's how the markdown looks right now:
Navigate to Settings > Policies > Group > Policy Name > People - then click Invite and enter the invitee's email address.
This should fix it!
Navigate to **Settings > Policies > Group > *Policy Name* > People** - then click Invite and enter the invitee's email address. | |
Navigate to **Settings > Policies > Group >** *Policy Name* **> People** - then click Invite and enter the invitee's email address. |
|
||
## Inviting Members to a Policy in Bulk | ||
|
||
Navigate to **Settings > Policies > Group > *Policy Name* > People** - then click Invite and enter all of the email addresses separated by comma. Indicate whether you want them to be an Employee, Admin, or Auditor on the policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as earlier
Navigate to **Settings > Policies > Group > *Policy Name* > People** - then click Invite and enter all of the email addresses separated by comma. Indicate whether you want them to be an Employee, Admin, or Auditor on the policy. | |
Navigate to **Settings > Policies > Group >** *Policy Name* **> People** - then click Invite and enter all of the email addresses separated by comma. Indicate whether you want them to be an Employee, Admin, or Auditor on the policy. |
|
||
You have the ability to invite your colleagues to join your Expensify policy by sharing a unique Policy Joining Link. You can use this link as many times as necessary to invite multiple users through various communication methods such as internal emails, chats, text messages, and more. | ||
|
||
To find your unique link, simply go to **Settings > Policies > Group > *Policy Name* > People**. It's easily accessible from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To find your unique link, simply go to **Settings > Policies > Group > *Policy Name* > People**. It's easily accessible from there. | |
To find your unique link, simply go to **Settings > Policies > Group >** *Policy Name* **> People**. It's easily accessible from there. |
Any Policy Admin can add users to a Group policy using any of the above methods. | ||
|
||
## How can I customize an invite message? | ||
Under **Settings > Policies > Group > *Policy Name* > People > Invite** you can enter a custom message you'd like users to receive in their invitation email. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under **Settings > Policies > Group > *Policy Name* > People > Invite** you can enter a custom message you'd like users to receive in their invitation email. | |
Under **Settings > Policies > Group >** *Policy Name* **> People > Invite** you can enter a custom message you'd like users to receive in their invitation email. |
@NicMendonca Do you mind commenting this in the PR? |
I have read the CLA Document and I hereby sign the CLA |
Updating "policy" to workspace, and "users/employees" to "members"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating policies to workspaces, and employees/ users to members as per new guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NicMendonca requesting changes
@@ -0,0 +1,62 @@ | |||
--- | |||
title: Invite Members | |||
description: Invite Members |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a suggestion, but could we improve this description? It'll be shown in google search results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to cc my pal @CherylWalsh who was my marketing reviewer! Do we need to change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think we want to make sure we're applying good descriptions to all help site pages. It's both beneficial for SEO purposes and provides a user with additional details when looking at the page listed in search results.
yes, we need to change this - context here https://expensify.slack.com/archives/C02QSAC6BJ8/p1695970001229149?thread_ts=1695962329.762109&cid=C02QSAC6BJ8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I am not good at marketing 😂
@@ -0,0 +1,62 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please re-name this file to Invite-Members.md
?
replace the dot .
with a dash -
updating description and file name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
desc & title change
Reviewer Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #28510. |
docs/articles/expensify-classic/getting-started/Invite-Members.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/getting-started/Invite-Members.md
Outdated
Show resolved
Hide resolved
fixed typos/ grammar error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed typos/ grammar error
docs/articles/expensify-classic/getting-started/Invite-Members.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/articles/expensify-classic/getting-started/Invite-Members.md
Outdated
Show resolved
Hide resolved
@NicMendonca You need to complete every checkbox in the list in the description in order for us to be able to merge, please! |
docs/articles/expensify-classic/getting-started/Invite-Members.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/getting-started/Invite-Members.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/getting-started/Invite-Members.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sonia Liapounova <[email protected]>
Co-authored-by: Sonia Liapounova <[email protected]>
@NicMendonca friendly bump! What do you think about the suggestions? |
Co-authored-by: Sonia Liapounova <[email protected]>
Co-authored-by: Sonia Liapounova <[email protected]>
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
2 similar comments
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
https://github.com/Expensify/Expensify/issues/311410
Details
Help doc resource
Fixed Issues
https://github.com/Expensify/Expensify/issues/311410
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android