-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent spacing after typing an emoji #28297
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@eVoloshchak I merged Expensify/main into my branch and that seemed to make that unit test pass. Ready for review and merge. Thank you! |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-28.at.11.26.17.movMobile Web - Chromescreen-20230928-113716.mp4Mobile Web - SafariRPReplay_Final1695893482.MP4DesktopScreen.Recording.2023-09-28.at.11.38.48.moviOSScreen.Recording.2023-09-28.at.12.09.43.movAndroidscreen-20230928-121248.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@youssef-lr, gentle bump on the above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.76-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.77-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
Details
There's an inconsistency between the compose and edit boxes. When typing out an emoji there is sometimes a space after and sometimes not. By utilizing the same ComposerUtils.getCommonSuffixLength function inside of the editor box as we use in the composer box, the cursor position is calculated correctly.
Fixed Issues
$ #27195
PROPOSAL: #27195 (comment)
Tests
Offline tests
N/A. The steps are the same for offline.
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
macOS.Chrome.mov
Mobile Web - Chrome
Android.Chrome.webm
Mobile Web - Safari
iOS.Safari.mp4
Desktop
Desktop.mov
iOS
iOS.Native.mp4
Android
Android.Native.webm