Fix: Hover effect lost after opening popover again before closing it

[getusha]

Details

Fixed Issues

$ #25582
PROPOSAL: #25582 (comment)

Tests

1. Go to any chat
2. Open the pop over right clicking
3. Move the pointer to the left or the right and right click again.
4. Move the mouse out of the report item
5. Verify that the hover effect is not lost when the popover is opened

• Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-02.at.9.05.23.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-02.at.9.10.34.PM.mov

Mobile Web - Safari

Screen.Recording.2023-10-02.at.9.12.33.PM.mov

Desktop

Screen.Recording.2023-10-02.at.9.16.48.PM.mov

iOS

Screen.Recording.2023-10-02.at.9.31.17.PM.mov

Android

Screen.Recording.2023-10-03.at.1.23.00.AM.mov

[melvin-bot]

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[abdulrahuman5196]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-03.at.1.09.50.PM.mp4

Mobile Web - Chrome

Screen.Recording.2023-10-03.at.1.46.25.PM.mp4

Mobile Web - Safari

Screen.Recording.2023-10-03.at.1.26.38.PM.mp4

Desktop

Screen.Recording.2023-10-03.at.1.49.15.PM.mp4

iOS

Screen.Recording.2023-10-03.at.1.30.59.PM.mp4

Android

Screen.Recording.2023-10-03.at.1.31.39.PM.mp4

[abdulrahuman5196]

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @pecanoro

🎀 👀 🎀
C+ Reviewed

[abdulrahuman5196]

Gentle Ping @pecanoro

[pecanoro]

It looks good but I have a question. Would it be possible to remove the setIsContextMenuActive(true); from line 250 now that we have this or do we need both? Just wondering since this will be always called onShow 😄

[abdulrahuman5196]

@pecanoro If we remove that line it causes another issue which was discussed in the GH issue also - #25582 (comment)
#25582 (comment)

So this acts as an extra check for the fix.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1259.664 ms → 1349.651 ms (+89.988 ms, +7.1%) 🔴

Show details

Name

Duration

App start TTI

Baseline Mean: 1259.664 ms Stdev: 38.223 ms (3.0%) Runs: 1160.4389300011098 1169.7629720009863 1191.0034830011427 1193.202975999564 1195.0251739993691 1197.2424639984965 1208.616928998381 1212.7123479992151 1216.6303029991686 1217.63668499887 1218.6798200011253 1222.1632990017533 1222.522050999105 1222.8992730006576 1223.0237869992852 1223.5349830016494 1223.7585749998689 1228.4924109987915 1229.1178210005164 1230.0771420001984 1230.3634819984436 1230.3937859982252 1233.474582001567 1234.6387480013072 1234.8878329992294 1236.4395139999688 1236.869187001139 1237.646728001535 1240.6453620009124 1240.7733610011637 1244.7877420000732 1246.1564959995449 1247.9361359998584 1250.310531001538 1253.59221399948 1254.877459000796 1257.3285229988396 1258.3748000003397 1258.9219730012119 1259.3001109994948 1259.8464209996164 1260.0915610007942 1260.805461999029 1262.9353320002556 1263.0834579989314 1263.4929580017924 1264.3783759996295 1265.3722920008004 1265.7026700004935 1266.1368909999728 1267.4255089983344 1267.4393530003726 1267.4933600015938 1267.5874800011516 1268.1032789982855 1269.0095739997923 1269.4430290013552 1272.5599609985948 1276.2067769989371 1278.8556450009346 1280.563804000616 1280.979387998581 1281.739861998707 1282.8623149991035 1283.5245679989457 1284.29997099936 1286.1006910018623 1286.9514909982681 1291.7904210016131 1291.8812410011888 1295.3789860010147 1296.0247920006514 1297.7028760015965 1297.8792200013995 1302.693532999605 1308.5957520008087 1309.5309030003846 1310.0160120017827 1312.1597380004823 1314.9615259990096 1315.5174809992313 1329.4140270017087 1331.0968299992383 1334.5001589991152 1336.9350450001657 1357.7354910001159 Current Mean: 1349.651 ms Stdev: 58.216 ms (4.3%) Runs: 1253.7431599982083 1263.1451519988477 1265.9030670002103 1266.4522240012884 1266.6148039996624 1269.3018799982965 1275.5069760009646 1276.1321460008621 1277.9125929996371 1281.9657520018518 1282.3405809998512 1283.9431709982455 1284.3426420018077 1286.4527690000832 1289.2068700008094 1289.3621539995074 1290.115582998842 1290.3051559999585 1291.9317030012608 1292.442605998367 1292.6777479983866 1293.1412549987435 1294.4402199983597 1299.3041069991887 1302.304703000933 1305.3791680000722 1305.6014630012214 1305.943261999637 1309.3554980009794 1311.8606350012124 1313.3786900006235 1315.5608530007303 1316.4879949986935 1321.7980999983847 1326.725214999169 1328.9139499999583 1330.740177001804 1331.0653630010784 1332.536901999265 1332.6752000004053 1339.1539640016854 1339.3799259997904 1339.8040950000286 1339.8336890004575 1339.8886019997299 1341.3315329998732 1344.5848260000348 1346.5647890008986 1348.5426779985428 1352.0688060000539 1352.4307410009205 1352.6035810001194 1354.7045579999685 1358.8105949983 1360.140475999564 1361.6047369986773 1363.8249140009284 1366.994360998273 1368.9931150004268 1370.5407060012221 1371.792771998793 1373.3463889993727 1373.3579300008714 1376.0472070015967 1376.6029979996383 1378.1417319998145 1384.1332640014589 1384.1891949996352 1385.5504520013928 1387.857306998223 1389.3344190008938 1396.3232400007546 1398.6023360006511 1401.4930059984326 1402.9445209987462 1403.464428000152 1404.6824110001326 1409.2804390005767 1418.2003309987485 1419.5026630014181 1422.862048998475 1433.2305519990623 1434.3133369982243 1435.9275440014899 1439.7369370013475 1446.823263000697 1447.1253589987755 1450.7121030017734 1454.2455499991775 1479.8758179992437 1488.839933000505 1510.5708470009267

Meaningless Changes To Duration

Show entries

Name	Duration
App start runJsBundle	871.302 ms → 919.422 ms (+48.120 ms, +5.5%)
Open Search Page TTI	628.066 ms → 640.668 ms (+12.603 ms, +2.0%)
App start nativeLaunch	22.902 ms → 24.024 ms (+1.121 ms, +4.9%)
App start regularAppStart	0.015 ms → 0.016 ms (+0.001 ms, +7.1%)

Show details

Name	Duration
App start runJsBundle	Baseline Mean: 871.302 ms Stdev: 33.358 ms (3.8%) Runs: 786 797 809 818 819 819 822 826 828 832 832 834 835 836 838 839 841 841 844 846 849 850 851 852 852 852 853 854 854 855 856 858 859 860 863 864 866 867 867 869 870 870 870 875 876 877 878 879 879 881 881 881 882 883 884 886 888 888 889 890 890 891 891 893 894 895 896 897 898 898 899 903 905 905 910 910 911 912 913 914 917 923 925 926 950 966 Current Mean: 919.422 ms Stdev: 42.782 ms (4.7%) Runs: 842 854 855 856 857 857 857 858 860 861 863 868 868 872 873 875 875 877 878 878 880 880 885 886 887 889 891 891 892 894 896 897 898 899 903 904 906 906 907 908 911 913 918 918 918 919 924 926 927 927 928 929 933 933 934 935 938 939 940 940 940 941 943 943 944 944 944 946 946 947 949 951 951 959 959 962 971 974 974 975 976 977 980 986 987 994 1008 1009 1010 1025
Open Search Page TTI	Baseline Mean: 628.066 ms Stdev: 22.610 ms (3.6%) Runs: 591.3857429996133 595.4286700002849 597.4237469993532 600.125 601.1149090006948 602.0702729970217 603.0183519981802 603.296875 603.9451499991119 604.0757660008967 604.0902910009027 605.6147059984505 607.3022460006177 607.4580889977515 607.8698729984462 608.1392420008779 608.9993079975247 610.7826340012252 611.5808920003474 611.6726890020072 611.9480790011585 611.9974769987166 612.0107830017805 612.3891609981656 612.6085619963706 612.8859050013125 612.9264319986105 612.9665530025959 613.0550949983299 613.2445069998503 613.8800459988415 614.3621830008924 614.6821699999273 616.0714920014143 616.4102380014956 616.694133002311 616.9624020010233 619.0595300011337 619.6941329985857 621.1622730009258 621.4401050023735 621.5073239989579 621.9345299974084 622.329020999372 622.7267259992659 623.5210370011628 624.0231940001249 624.1354169994593 626.5574949979782 628.0784919969738 628.5557049997151 628.6180019974709 629.9086510017514 630.0394689999521 630.687134001404 631.4877929985523 632.9004720002413 633.6069339998066 634.3494469970465 634.3859460018575 636.1434330008924 637.3899739980698 637.6689050011337 638.9708259999752 639.4562989994884 641.0107430033386 641.5722250007093 641.5865070000291 643.493407998234 644.0797930024564 645.4985360018909 645.9418950006366 646.0842700004578 647.7227779999375 649.6126299984753 651.3644209988415 651.5799560025334 653.0478110015392 654.5707610026002 655.3812259994447 662.9929609969258 665.7866619974375 669.3402100019157 669.5707200020552 689.2424720004201 691.8673099987209 692.0130610018969 695.6035160012543 Current Mean: 640.668 ms Stdev: 19.715 ms (3.1%) Runs: 603.5242520011961 603.9012859985232 612.3763430006802 613.6468919999897 617.2551269978285 618.078409999609 618.3573810011148 618.5012209974229 620.1344810016453 620.2048749998212 620.3134770020843 620.4829520024359 620.5822760015726 620.782145999372 621.1993409991264 621.8689370006323 622.0865890011191 622.5953369997442 622.7719330005348 622.8205980025232 622.8542889989913 623.1850989982486 623.2901620008051 627.6326909996569 627.9961749985814 628.594076000154 628.7487390004098 629.2408850006759 629.3644619993865 629.4037679992616 630.3875740021467 630.5245769992471 630.5396329984069 630.6196699999273 630.8006189987063 635.2581789977849 635.5334069989622 635.6180419996381 635.8385419994593 636.6282150000334 636.8016359992325 637.0173350013793 637.4175620004535 637.5461429990828 637.5685629993677 637.5813800022006 637.8320309966803 638.8647059984505 639.1648360006511 639.3037110008299 639.5011799968779 639.5298260003328 639.733642000705 639.8911129981279 640.3488369993865 643.5761730000377 644.5530200004578 645.4404300004244 645.744099996984 646.1210130006075 646.2371420003474 648.2126870006323 648.376180998981 648.6582439988852 648.7609460018575 652.3494470007718 652.3501389995217 652.4177249968052 652.6749680005014 653.149942997843 653.4003090001643 653.9696040004492 655.952881000936 657.3158770017326 660.2006839998066 663.2240400016308 663.3547770008445 668.1146650016308 668.7045090012252 672.7854410000145 675.1109209991992 675.7012940011919 676.4929200001061 676.7430010028183 676.9705820009112 685.6892499998212 685.8243010006845 688.8778889998794 690.7910160012543
App start nativeLaunch	Baseline Mean: 22.902 ms Stdev: 4.006 ms (17.5%) Runs: 18 18 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 25 25 26 26 26 27 28 28 28 29 29 29 29 30 30 30 30 30 31 31 31 32 33 33 Current Mean: 24.024 ms Stdev: 2.207 ms (9.2%) Runs: 20 20 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 25 25 25 25 25 25 25 25 25 25 25 25 25 25 25 26 26 26 26 27 27 27 27 27 27 28 28 29 29 29 30 30
App start regularAppStart	Baseline Mean: 0.015 ms Stdev: 0.001 ms (7.7%) Runs: 0.013020999729633331 0.013305000960826874 0.013305999338626862 0.013467997312545776 0.013672001659870148 0.013753999024629593 0.013794001191854477 0.013794001191854477 0.013875000178813934 0.01399800181388855 0.014037996530532837 0.014038000255823135 0.014119002968072891 0.014119002968072891 0.014159999787807465 0.014159999787807465 0.014201000332832336 0.014281999319791794 0.014282997697591782 0.014322999864816666 0.01440500095486641 0.014444001019001007 0.014485001564025879 0.014485999941825867 0.014485999941825867 0.014566998928785324 0.014567002654075623 0.014567002654075623 0.014607999473810196 0.014647997915744781 0.01464800164103508 0.014770999550819397 0.014810997992753983 0.014852002263069153 0.014973998069763184 0.015015002340078354 0.015054997056722641 0.015095997601747513 0.015096001327037811 0.01517699658870697 0.01521800085902214 0.01521800085902214 0.01521800085902214 0.015258003026247025 0.015258997678756714 0.015258997678756714 0.015259001404047012 0.015259001404047012 0.015259001404047012 0.015298999845981598 0.015298999845981598 0.01534000039100647 0.015380997210741043 0.015544001013040543 0.015544001013040543 0.015625 0.015707001090049744 0.015707001090049744 0.01574699953198433 0.01574699953198433 0.01574699953198433 0.015747003257274628 0.015787001699209213 0.01586899906396866 0.015992000699043274 0.01607299968600273 0.016113001853227615 0.016114000231027603 0.016154002398252487 0.016194000840187073 0.01619500294327736 0.016275998204946518 0.016276001930236816 0.01631699874997139 0.016398001462221146 0.01643899828195572 0.016439002007246017 0.016479000449180603 0.016520000994205475 0.016641996800899506 0.01684599742293358 0.017009001225233078 0.017131000757217407 0.017211999744176865 0.01725200191140175 0.017944999039173126 0.01827000081539154 0.018717002123594284 0.018718000501394272 Current Mean: 0.016 ms Stdev: 0.001 ms (6.2%) Runs: 0.014525998383760452 0.015014998614788055 0.015014998614788055 0.015055999159812927 0.015136998146772385 0.01521800085902214 0.015257999300956726 0.015259001404047012 0.015259001404047012 0.015339996665716171 0.01534000039100647 0.015380997210741043 0.015380997210741043 0.015381000936031342 0.015381000936031342 0.015461999922990799 0.015463002026081085 0.015463002026081085 0.01550300046801567 0.015544001013040543 0.015583999454975128 0.015583999454975128 0.015584003180265427 0.015666000545024872 0.015705998986959457 0.015706002712249756 0.015706002712249756 0.015747003257274628 0.015787001699209213 0.0157880000770092 0.015827998518943787 0.01586899906396866 0.01590999960899353 0.015950001776218414 0.015951000154018402 0.015990998595952988 0.01603100076317787 0.016032002866268158 0.016032002866268158 0.016113001853227615 0.016113001853227615 0.01615399867296219 0.01619499921798706 0.016235001385211945 0.016276001930236816 0.01631699874997139 0.01631699874997139 0.01631699874997139 0.016398001462221146 0.01643899828195572 0.01643899828195572 0.016439002007246017 0.016479000449180603 0.01647999882698059 0.016520000994205475 0.016560997813940048 0.016642998903989792 0.01672299951314926 0.016764000058174133 0.016805000603199005 0.01684599742293358 0.01684599742293358 0.016846001148223877 0.016846001148223877 0.016885999590158463 0.016885999590158463 0.016885999590158463 0.016927000135183334 0.016927000135183334 0.017090000212192535 0.01712999865412712 0.017212003469467163 0.017333999276161194 0.017455998808145523 0.017497003078460693 0.017619002610445023 0.017659999430179596 0.017659999430179596 0.017741002142429352 0.018146999180316925 0.01822900027036667 0.01827000081539154 0.018311001360416412 0.018473997712135315 0.018635999411344528 0.0186769999563694 0.018961001187562943 0.019124001264572144

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[abdulrahuman5196]

I am not sure how this change is related to app start performance because this change only gets triggered on popover open. And it's a very minor change 🤔

[getusha]

@abdulrahuman5196 looks like its also happening on other merged PRs e.g. #28709 (comment) #28720 (comment)

[OSBotify]

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅