-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA]Remove check to only look for blockers when run via workflow_call
#28659
Conversation
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Ran it here and it works.. But it's already failing the performance part compared to our previous release 😭 https://github.com/Expensify/App/actions/runs/6385892599/job/17332602006 |
Not sure how to treat this PR? I dont think this is a real blocker right now, we need to run these tests on specific PRs because from this I have no clue what could be the offending change or how to find it |
Removing the label discussed here Going to deploy this now and we will see now the E2E to run on PRs merged to main |
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.77-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
Details
This check does not seem to be working (
github.event_name
appears to not work forworkflow_call
) and we should check for blockers on bothworkflow_call
andworkflow_dispatch
cases.Fixed Issues
$ #27919 (comment)
Tests
Check if test failed, if so post the results and add the DeployBlocker label
step is runOffline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
N/A - Fixing tests
Mobile Web - Chrome
N/A - Fixing tests
Mobile Web - Safari
N/A - Fixing tests
Desktop
N/A - Fixing tests
iOS
N/A - Fixing tests
Android
N/A - Fixing tests