Fix/28347 Navaigate back when reloading in scan receipt #28893

DylanDylann · 2023-10-05T07:04:54Z

Details

Navaigate back when reloading in scan receipt

Fixed Issues

$ #28347
PROPOSAL: #28347 (comment)

Tests

Clicking + (FAB) Button
Clicking on scan request
Upload an image for receipt
Go to confirmation page
Refresh the page
Verify that the App navigate back to Scan Request Page
Press the request button

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Same above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-05.at.13.40.30.mp4

Mobile Web - Chrome

Screen.Recording.2023-10-05.at.13.51.31.mp4

Mobile Web - Safari

Screen.Recording.2023-10-11.at.00.42.50.mp4

Desktop

Screen.Recording.2023-10-05.at.13.59.37.mp4

iOS

Using deeplink doesn't reload page. So I don't see anyway to test it

Android

Using deeplink doesn't reload page. So I don't see anyway to test it

melvin-bot · 2023-10-05T07:15:44Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/iou/steps/MoneyRequestConfirmPage.js

DylanDylann · 2023-10-07T04:57:16Z

@mollfpr Could you help to check this PR when you have a chance? Many thanks

mollfpr · 2023-10-09T02:50:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

28893.Web.mp4

Mobile Web - Chrome

28893.mWeb-Chrome.mp4

Mobile Web - Safari

28893.mWeb-Safari.mp4

Desktop

28893.Desktop.mp4

iOS

Android

mollfpr

Found a regression. Step to reproduce:

Open the scan money request page
Select a file
Select the participants
Press the back button until it show the scan money request page again
Select a file again

The second select image should set the selected file, not redirect the user back to the selection page.

Screen.Recording.2023-10-09.at.12.24.27.mov

DylanDylann · 2023-10-09T05:35:45Z

@mollfpr I can reproduce your bug on the staging.

Screen-Recording-2023-10-09-at-12.34.18.mp4

So I think It is another bug and don't relate to this one

mollfpr · 2023-10-09T10:05:58Z

@DylanDylann Oh yeah, I just did the staging, and the issue is already there. I think we are all good here.

DylanDylann · 2023-10-09T16:57:15Z

@mollfpr I updated the lastest main. Could you help to complete the checklist here?

mollfpr

Mostly looks good on Web and Desktop. For native, I think we don't have the step to test it out.

On the mWeb, sometimes I got redirect to the LHN after refreshing the page. It's not always reproduce and I don't clear step to reproduce it.

mweb.webm

Could you check if we can find what the issue above?

DylanDylann · 2023-10-09T18:27:30Z

@mollfpr It seems we have some changes recently, It causes this issue on mWeb. I am not sure if It is bug or not

mollfpr · 2023-10-09T18:39:46Z

@DylanDylann Could you check the root cause? We can discuss the solution, if it's can be done here or should be address in a different issue.

DylanDylann · 2023-10-10T17:53:46Z

@mollfpr When reloading, goBack (new change) is executed 2 times. It causes this problem. I updated to fix it by using the new useEffect for new changes. Tested and everything work well

Screen.Recording.2023-10-11.at.00.42.50.mp4

DylanDylann · 2023-10-10T18:27:36Z

We failed Reassure Performance Tests (first time I see). I am checking

DylanDylann · 2023-10-11T04:21:34Z

@mollfpr It is resolved after I merge main. Please help to review this PR again.

DylanDylann · 2023-10-12T10:06:33Z

@mollfpr Bump, could you help to review the change on this PR?

mollfpr

Hi @DylanDylann, Sorry for the late review. I just got out from the hospital after surgery from the motorcycle accident on Wednesday 🙏

I tested the latest PR, but it seems the FileUtils.readFileAsync is never resolved now. So after the refresh, it will only take me somewhere.

Screen.Recording.2023-10-15.at.21.43.48.mov

mollfpr · 2023-10-16T10:24:51Z

I tested the latest PR, but it seems the FileUtils.readFileAsync is never resolved now. So after the refresh, it will only take me somewhere.

@DylanDylann Have you tested the above issue?

DylanDylann · 2023-10-16T13:50:29Z

@mollfpr merged main to ensure that we are not outdated. I am checking, I will response soon

DylanDylann · 2023-10-16T15:56:35Z

@mollfpr I used wrong condition in the early return condition. Updated, please help to review again

mollfpr

We can't test this on native platform since there's no way to imitate the refresh behavior.

LGTM and tests well 👍

All yours @luacmartins

luacmartins

LGTM!

OSBotify · 2023-10-17T17:44:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-17T23:57:03Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:54:33Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

navaigate back when reloading

33de55e

DylanDylann marked this pull request as ready for review October 5, 2023 07:15

DylanDylann requested a review from a team as a code owner October 5, 2023 07:15

melvin-bot bot removed the request for review from a team October 5, 2023 07:15

melvin-bot bot requested a review from mollfpr October 5, 2023 07:15

mollfpr reviewed Oct 5, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequestConfirmPage.js Outdated Show resolved Hide resolved

update state of receipt

70c2da4

mollfpr reviewed Oct 9, 2023

View reviewed changes

DylanDylann added 4 commits October 9, 2023 23:29

merge main

5a68170

using goback instead of navigate back

968e564

fix lint

c370c1c

fix lint

26e8fd9

mollfpr reviewed Oct 9, 2023

View reviewed changes

DylanDylann added 3 commits October 11, 2023 00:47

use a new useEffect

1a5b0e9

fix lint

ab55516

merge main

22bffa3

fix lint

af8f7f6

merge main

8eee7dc

mollfpr reviewed Oct 15, 2023

View reviewed changes

DylanDylann added 2 commits October 16, 2023 16:27

merge main

b1a1097

fix lint

b3977ca

fix wrong condition

c376c49

DylanDylann added 2 commits October 16, 2023 23:01

fix wrong condition

1fbc45b

fix wrong condition

6c9c98f

mollfpr approved these changes Oct 17, 2023

View reviewed changes

luacmartins self-requested a review October 17, 2023 16:19

luacmartins approved these changes Oct 17, 2023

View reviewed changes

luacmartins merged commit c498ab5 into Expensify:main Oct 17, 2023
12 checks passed

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

melvin-bot bot mentioned this pull request Oct 18, 2023

[HOLD for payment 2023-10-25] [$500] IOU - Request money is not successful after refreshing in confirm page #28347

Closed

6 tasks

DylanDylann mentioned this pull request Nov 4, 2023

[HOLD for payment 2024-02-07][$500] Page refresh causes manual request with a receipt to be stuck #30884

Closed

6 tasks

idanbe4 mentioned this pull request May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 be4solutions/App#10

Open

MelvinBot mentioned this pull request May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 #42357

Closed

50 tasks

melvin-bot bot mentioned this pull request May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 #42358

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/28347 Navaigate back when reloading in scan receipt #28893

Fix/28347 Navaigate back when reloading in scan receipt #28893

DylanDylann commented Oct 5, 2023 •

edited

Loading

melvin-bot bot commented Oct 5, 2023

DylanDylann commented Oct 7, 2023

mollfpr commented Oct 9, 2023 •

edited

Loading

mollfpr left a comment

DylanDylann commented Oct 9, 2023

mollfpr commented Oct 9, 2023

DylanDylann commented Oct 9, 2023

mollfpr left a comment

DylanDylann commented Oct 9, 2023

mollfpr commented Oct 9, 2023

DylanDylann commented Oct 10, 2023

DylanDylann commented Oct 10, 2023

DylanDylann commented Oct 11, 2023 •

edited

Loading

DylanDylann commented Oct 12, 2023

mollfpr left a comment

mollfpr commented Oct 16, 2023

DylanDylann commented Oct 16, 2023 •

edited

Loading

DylanDylann commented Oct 16, 2023

mollfpr left a comment

luacmartins left a comment

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

Fix/28347 Navaigate back when reloading in scan receipt #28893

Fix/28347 Navaigate back when reloading in scan receipt #28893

Conversation

DylanDylann commented Oct 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 5, 2023

DylanDylann commented Oct 7, 2023

mollfpr commented Oct 9, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

DylanDylann commented Oct 9, 2023

mollfpr commented Oct 9, 2023

DylanDylann commented Oct 9, 2023

mollfpr left a comment

Choose a reason for hiding this comment

DylanDylann commented Oct 9, 2023

mollfpr commented Oct 9, 2023

DylanDylann commented Oct 10, 2023

DylanDylann commented Oct 10, 2023

DylanDylann commented Oct 11, 2023 • edited Loading

DylanDylann commented Oct 12, 2023

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr commented Oct 16, 2023

DylanDylann commented Oct 16, 2023 • edited Loading

DylanDylann commented Oct 16, 2023

mollfpr left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

DylanDylann commented Oct 5, 2023 •

edited

Loading

mollfpr commented Oct 9, 2023 •

edited

Loading

DylanDylann commented Oct 11, 2023 •

edited

Loading

DylanDylann commented Oct 16, 2023 •

edited

Loading