Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Migrate EmojiPickerMenu Class component to Functional Component #29241

Merged
merged 48 commits into from
Oct 18, 2023
Merged

Refactor: Migrate EmojiPickerMenu Class component to Functional Component #29241

Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
4bb0916
refactor: rename index*.js to EmojiPickerMenu*.tsx
ashuvssut Oct 6, 2023
0385879
refactor: barrel import EmojiPickerMenu
ashuvssut Oct 6, 2023
5fcc5cc
progress #1: convert class to function + add function keyword to clas…
ashuvssut Oct 7, 2023
5716e80
progress #2: props
ashuvssut Oct 7, 2023
52eb14c
progress #3: searchInputRef -> searchInputRef
ashuvssut Oct 7, 2023
7959d01
progress #4: emojiList -> emojiListRef
ashuvssut Oct 7, 2023
9354019
progress #5: filterEmojis() with useCallback + shouldFocusInputOnScre…
ashuvssut Oct 7, 2023
65fdee9
progress #6: highlightAdjacentEmoji() + setupEventHandlers() + cleanu…
ashuvssut Oct 7, 2023
35726f6
progress #7: renderItem() +onSelectionChange()
ashuvssut Oct 7, 2023
2ba2e82
progress #8:updatePreferredSkinTone() + JsDoc upd in User.js
ashuvssut Oct 7, 2023
3aa5cfb
progress #9:setFirstNonHeaderIndex() + getItemLayout() + scrollToHead…
ashuvssut Oct 7, 2023
607b0cb
p#10: rename setFirstNonHeaderIndex -> updateFirstNonHeaderIndex() + …
ashuvssut Oct 7, 2023
c071646
p#11: emojis Ref + filteredEmojis state
ashuvssut Oct 7, 2023
878f663
p#12: headerRowIndices Ref + headerIndices state
ashuvssut Oct 7, 2023
cbd0dc4
p#13: headerEmojis ref (IMP!!: this should be a ref)
ashuvssut Oct 7, 2023
4a7995e
p#14: highlightedIndex state
ashuvssut Oct 7, 2023
5634ec4
p#15: arePointerEventsDisabled state
ashuvssut Oct 7, 2023
5c7d459
p#16: selection state
ashuvssut Oct 7, 2023
76bde46
p#17: isFocused state
ashuvssut Oct 7, 2023
7ee44e4
p#17: isUsingKeyboardMovement state
ashuvssut Oct 7, 2023
d95a5ec
p#18: convert missed this.state.filteredEmojis
ashuvssut Oct 7, 2023
76b0fa9
p#19: selectTextOnFocus state
ashuvssut Oct 7, 2023
c8fab62
p#20: keyDownHandler() + keyExtractor()
ashuvssut Oct 7, 2023
4ddcfaa
p#20: mouseMoveHandler()
ashuvssut Oct 7, 2023
c684aee
p#21: focusInputWithTextSelect() + addToFrequentAndSelectEmoji()
ashuvssut Oct 7, 2023
24c9681
p#21: cleanup
ashuvssut Oct 7, 2023
8e2540f
p#22: lifecycle methods: componentDidMount + componentWillUnmount
ashuvssut Oct 7, 2023
57ac93b
p#22: lifecycle method: componentDidUpdate()
ashuvssut Oct 7, 2023
60483ea
p#23: cleanup: rename class component file as old.EmojiPickerMenu.tsx
ashuvssut Oct 7, 2023
1a0cc8e
fix: all emojis not visible
ashuvssut Oct 7, 2023
58bec01
rename EmojiPickerMenu copy to EmojiPickerMenu
ashuvssut Oct 7, 2023
5ee4b64
fix: remove TS types
ashuvssut Oct 10, 2023
94022aa
remove TODO comments
ashuvssut Oct 10, 2023
7f80407
rename all .ts* back to .js*
ashuvssut Oct 10, 2023
c9e1762
delete old class component
ashuvssut Oct 10, 2023
e102c5e
fix: fix Bad Practice. headerEmoji (ref) was being read during render
ashuvssut Oct 10, 2023
3f70fb4
remove index.js
ashuvssut Oct 11, 2023
25f7ba6
rename: EmojiPickerMenu*.jsx -> index*.js
ashuvssut Oct 11, 2023
0c88110
Merge branch 'main' of github.com:Expensify/App into refactor/emojipi…
ashuvssut Oct 12, 2023
bcffdbe
fix: eslint error: "ES2020 optional chaining is forbidden"
ashuvssut Oct 12, 2023
7e999a6
fix: eslint error: "JSX props should not use functions"
ashuvssut Oct 12, 2023
0c9c6d2
fix: eslint error: useCallback & useEffect deps array
ashuvssut Oct 12, 2023
3ccc9a8
fix: eslint error: usused variable error
ashuvssut Oct 12, 2023
1c0320a
fix: eslint "warnings" about useCallback & useEffect deps arr
ashuvssut Oct 12, 2023
7098e80
fix: emoji filter not working
ashuvssut Oct 13, 2023
d7e3939
Merge branch 'main' of github.com:Expensify/App into refactor/emojipi…
ashuvssut Oct 16, 2023
66b4969
fix: eslint warn -- extra deps in useCallaback
ashuvssut Oct 17, 2023
f17add9
Merge branch 'refactor/emojipickermenu-try2' of github.com:ashuvssut/…
ashuvssut Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading