-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: update the report when a payment is refunded #29344
Merged
MariaHCD
merged 27 commits into
Expensify:main
from
getusha:feat-payment-expired-handler
Dec 1, 2023
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
fd857e7
Feat: update the report when a payment is refunded
getusha 2b33b90
run prettier
getusha 0aac629
prevent crash by checking key existence
getusha d29b2b9
Merge remote-tracking branch 'expensify/main' into upgrade-react-nati…
getusha b7986d4
Add es translations
getusha 444b732
use report action value
getusha 89b7bd5
Merge remote-tracking branch 'expensify/main' into feat-payment-expir…
getusha 5d3ef6a
Merge remote-tracking branch 'expensify/main' into feat-payment-expir…
getusha 99d4202
use props.report value for amount and name
getusha c4f921f
Merge remote-tracking branch 'expensify/main' into feat-payment-expir…
getusha 839326e
update 'reason' to 'cancellationReason'
getusha f2c59f3
remove usage of report.ownerEmail and add condition for canceled case
getusha 0b1f90b
fix lint
getusha a4013f1
run prettier
getusha 97d8c5e
lint!
getusha 2f0af0c
fix crash
getusha ef72ec7
run prettier
getusha 6b78581
add type in OriginalMessage for Dequeued action
getusha 899ee0a
update report preview based on dequeued action
getusha 0e3887f
Merge remote-tracking branch 'expensify/main' into feat-payment-expir…
getusha 40b9818
missed condition
getusha 8cccd75
run prettier
getusha d5c4dbe
add condition to handle canceled case
getusha 30f43e4
lint!
getusha 2bbd0ef
fix LHN last message text preview
getusha 555ddcb
use isCancelledIOU and remove redundant function
getusha 75ad8c4
run prettier
getusha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two types are the same, can we merged them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertKozik
App/src/languages/types.ts
Line 103 in ba75ce9
App/src/languages/types.ts
Line 109 in ba75ce9
App/src/languages/types.ts
Line 107 in ba75ce9
there are a lot of duplicate types, don't you think its better to keep it for its clear naming? if we want to add another param it'll be easier since we have types for each function, if not what should we name the type after combining it as one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense, lets keep it as it is