Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: update the report when a payment is refunded #29344
Feat: update the report when a payment is refunded #29344
Changes from 21 commits
fd857e7
2b33b90
0aac629
d29b2b9
b7986d4
444b732
89b7bd5
5d3ef6a
99d4202
c4f921f
839326e
f2c59f3
0b1f90b
a4013f1
97d8c5e
2f0af0c
ef72ec7
6b78581
899ee0a
0e3887f
40b9818
8cccd75
d5c4dbe
30f43e4
2bbd0ef
555ddcb
75ad8c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two types are the same, can we merged them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertKozik
App/src/languages/types.ts
Line 103 in ba75ce9
App/src/languages/types.ts
Line 109 in ba75ce9
App/src/languages/types.ts
Line 107 in ba75ce9
there are a lot of duplicate types, don't you think its better to keep it for its clear naming? if we want to add another param it'll be easier since we have types for each function, if not what should we name the type after combining it as one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense, lets keep it as it is