Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "DRY up the code for the backTo param in routes" #30142

Closed
wants to merge 1 commit into from
Closed

Revert "DRY up the code for the backTo param in routes" #30142

wants to merge 1 commit into from

Conversation

thienlnam
Copy link
Contributor

Reverts #29813

@thienlnam thienlnam self-assigned this Oct 22, 2023
@thienlnam thienlnam marked this pull request as ready for review October 22, 2023 01:28
@thienlnam thienlnam requested a review from a team as a code owner October 22, 2023 01:28
@thienlnam
Copy link
Contributor Author

Straight revert

@melvin-bot melvin-bot bot removed the request for review from a team October 22, 2023 01:28
@melvin-bot
Copy link

melvin-bot bot commented Oct 22, 2023

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from Julesssss October 22, 2023 01:28
@thienlnam thienlnam mentioned this pull request Oct 22, 2023
Merged
59 tasks
luacmartins
luacmartins requested changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with this fix instead of reverting

@Julesssss
Copy link
Contributor

I think we should go with #30144 instead of reverting

Seems like we did that. Closing

@Julesssss Julesssss closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins requested changes

@Julesssss Julesssss Awaiting requested review from Julesssss

Assignees

@thienlnam thienlnam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thienlnam @Julesssss @luacmartins