-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ios wrong permission message #30374
Merged
chiragsalian
merged 26 commits into
Expensify:main
from
ishpaul777:fix/ios-wrong-permission-message
Dec 12, 2023
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
3105687
fix: wrong alert message for microphone permission error
ishpaul777 ea5b6c9
added requested changes
ishpaul777 c4bdd27
fix conflicts
ishpaul777 177d8b9
Merge branch 'main' into fix/ios-wrong-permission-message
ishpaul777 a7dd5e3
fix conflicts
ishpaul777 3d18adf
fix imports
ishpaul777 967569d
fix lint
ishpaul777 729f264
fix prettier difffs
ishpaul777 efe6754
made change specific to ios
ishpaul777 9482050
Merge branch 'Expensify:main' into fix/ios-wrong-permission-message
ishpaul777 f46a771
fix no modal error on mic permission
ishpaul777 b1c9a56
changes copy for alert message in english
ishpaul777 5f44d6b
fix lint
ishpaul777 005fd9f
Merge branch 'Expensify:main' into fix/ios-wrong-permission-message
ishpaul777 3262454
copy updated
ishpaul777 43be729
Merge branch 'fix/ios-wrong-permission-message' of https://github.com…
ishpaul777 5991701
fix lint
ishpaul777 0584882
fix title for error message
ishpaul777 8ba7176
Merge branch 'Expensify:main' into fix/ios-wrong-permission-message
ishpaul777 7ca308e
Merge branch 'Expensify:main' into fix/ios-wrong-permission-message
ishpaul777 8c73e7d
Update src/components/Onfido/index.native.js
ishpaul777 924247d
Update src/components/Onfido/index.native.js
ishpaul777 585e322
Merge branch 'Expensify:main' into fix/ios-wrong-permission-message
ishpaul777 099c7fa
Update CONST.ts
ishpaul777 b85636f
Update src/languages/en.ts
ishpaul777 8c0b10b
Update src/languages/en.ts
ishpaul777 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platform.select
is not preferred. Please re-useiou/ReceiptSelector/CameraPermission
structure to handle platform specific permissions.