add selectTextOnFocus for GooglePlacesAutoComplete #30424

c3024 · 2023-10-26T11:06:35Z

Details

Fixed Issues

$ #30198
PROPOSAL: #30198 (comment)

Tests

Click on FAB -> Request Money -> Distance
Click on a waypoint field
Input some text
Blur the text input
Focus back on the text input
Verify that the text is selected.

Verify that no errors appear in the JS console

Offline tests

Click on FAB -> Request Money -> Distance
Click on a waypoint field
Input some text
Blur the text input
Focus back on the text input
Verify that the text is selected.

QA Steps

Click on FAB -> Request Money -> Distance
Click on a waypoint field
Input some text
Blur the text input
Focus back on the text input
Verify that the text is selected.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-26.at.5.42.22.PM.mov

Android: mWeb Chrome

selectOnFocusAndroid.mp4

iOS: Native

Screen.Recording.2023-10-26.at.4.59.04.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-10-26.at.4.51.08.PM.mov

MacOS: Chrome / Safari

selectOnFocusWebChrome.mov

MacOS: Desktop

selectOnFocusDesktop.mov

melvin-bot · 2023-10-26T11:06:40Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-10-26T12:15:45Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2023-10-26T13:35:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

distance-focus-web.mp4

Mobile Web - Chrome

distance-focus-android-web-compressed.mp4

Mobile Web - Safari

distance-focus-ios-web.mp4

Desktop

distance-focus-desktop.mp4

iOS

distance-focus-ios.mp4

Android

distance-focus-android-compressed.mp4

cubuspl42 · 2023-10-26T13:38:30Z

@c3024 @Julesssss

The selectTextOnFocus flag doesn't seem fully functional on iOS/Native. I'm wondering if this is in scope of this issue.

Julesssss · 2023-10-26T14:23:18Z

Hey @cubuspl42, your Android video seems incorrect.

The selectTextOnFocus flag doesn't seem fully functional on iOS/Native. I'm wondering if this is in scope of this issue.

I'm going to test an AdHoc build before confirming, but it looks like its working to me in @c3024's videos... Am I missing something?

cubuspl42 · 2023-10-26T14:29:44Z

your Android video seems incorrect.

Oops, I dragged wrong file. Corrected.

Am I missing something?

The actual steps are somewhat different. I followed the testing steps literally and unfocused by tapping a non-functional black area.

OSBotify · 2023-10-26T14:44:24Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/30424/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/30424/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/30424/NewExpensify.dmg	https://30424.pr-testing.expensify.com

Julesssss · 2023-10-26T15:15:10Z

I followed the testing steps literally and unfocused by tapping a non-functional black area.

I haven't tested iOS yet, but for Android I see the full text being select both when entering the page, and after tapping outside the input:

Android-Focus.mp4

c3024 · 2023-11-02T17:25:32Z

@Julesssss
On iOS app, the text input does not blur when we click outside the text input. So the text does not get selected/highlighted in this specific case.
It is specific iOS Native behaviour and I wonder if it comes under the scope of this fix.

Screen.Recording.2023-11-02.at.10.52.52.PM.mov

Julesssss · 2023-11-03T08:48:28Z

For me, I had to select an address first. And it only de-focused when I tapped quite close to the input (for example, where the address dropdown shows in your video)

c3024 · 2023-11-06T16:53:20Z

@Julesssss
What shall we do? I have not found any fix yet for this iOS behaviour.
Merge the PR or try to fix this iOS specific behaviour?

Julesssss · 2023-11-07T08:44:47Z

What shall we do? I have not found any fix yet for this iOS behaviour.

@c3024 @cubuspl42 does this work in other places in the app? Or is it unique to this input?

c3024 · 2023-11-10T15:54:29Z

@Julesssss

Textinput does not blur when clicking outside even in other pages as well on iOS.

blurAtOtherOutput.mov

Julesssss · 2023-11-13T08:45:08Z

I was able to reproduce this on iOS here. But given the simplicity of this change then lets just move on. iOS should be resolved app wide.

OSBotify · 2023-11-13T08:50:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-14T22:10:51Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:54:07Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T21:09:33Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

selectTextOnFocus for GooglePlacesAutoComplete

6066800

c3024 marked this pull request as ready for review October 26, 2023 12:15

c3024 requested a review from a team as a code owner October 26, 2023 12:15

melvin-bot bot requested review from cubuspl42 and removed request for a team October 26, 2023 12:15

cubuspl42 approved these changes Oct 26, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss October 26, 2023 13:35

Julesssss added the Ready To Build label Oct 26, 2023

Julesssss assigned c3024 Oct 26, 2023

Julesssss approved these changes Nov 13, 2023

View reviewed changes

Julesssss merged commit 771f252 into Expensify:main Nov 13, 2023
14 of 17 checks passed

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

melvin-bot bot mentioned this pull request Nov 15, 2023

[HOLD for payment 2023-11-22] [$500] Distance - Address search term not highlighted on refocus #30198

Closed

6 tasks

OSBotify mentioned this pull request Nov 15, 2023

Deploy Checklist: New Expensify 2023-11-15 #31404

Closed

37 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add selectTextOnFocus for GooglePlacesAutoComplete #30424

add selectTextOnFocus for GooglePlacesAutoComplete #30424

c3024 commented Oct 26, 2023 •

edited

Loading

melvin-bot bot commented Oct 26, 2023

melvin-bot bot commented Oct 26, 2023

cubuspl42 commented Oct 26, 2023 •

edited

Loading

cubuspl42 commented Oct 26, 2023

Julesssss commented Oct 26, 2023

cubuspl42 commented Oct 26, 2023

OSBotify commented Oct 26, 2023

Julesssss commented Oct 26, 2023

c3024 commented Nov 2, 2023

Julesssss commented Nov 3, 2023

c3024 commented Nov 6, 2023

Julesssss commented Nov 7, 2023

c3024 commented Nov 10, 2023

Julesssss commented Nov 13, 2023

OSBotify commented Nov 13, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

OSBotify commented Nov 15, 2023

add selectTextOnFocus for GooglePlacesAutoComplete #30424

add selectTextOnFocus for GooglePlacesAutoComplete #30424

Conversation

c3024 commented Oct 26, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 26, 2023

melvin-bot bot commented Oct 26, 2023

cubuspl42 commented Oct 26, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

cubuspl42 commented Oct 26, 2023

Julesssss commented Oct 26, 2023

cubuspl42 commented Oct 26, 2023

OSBotify commented Oct 26, 2023

Julesssss commented Oct 26, 2023

c3024 commented Nov 2, 2023

Julesssss commented Nov 3, 2023

c3024 commented Nov 6, 2023

Julesssss commented Nov 7, 2023

c3024 commented Nov 10, 2023

Julesssss commented Nov 13, 2023

OSBotify commented Nov 13, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

OSBotify commented Nov 15, 2023

c3024 commented Oct 26, 2023 •

edited

Loading

cubuspl42 commented Oct 26, 2023 •

edited

Loading