-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expo image #30905
Merged
roryabraham
merged 115 commits into
Expensify:main
from
software-mansion-labs:expo-image
Dec 22, 2023
Merged
Expo image #30905
Changes from 97 commits
Commits
Show all changes
115 commits
Select commit
Hold shift + click to select a range
30594c2
Add expo-modules to application.
mczernek 199d5d6
Update package-lock.json after adding expo-modules.
mczernek 87caddc
Bump kotlin to 1.8.20 to make it compatible with expo-modules.
mczernek e38d43d
Prettier on metro.config.js
mczernek 4a40e3f
Add patch for plaid-sdk
mczernek ca47d62
Display icons with expo-image
WojtekBoman 49f341a
Fix displaying svg icons with own fill colors, fix prop types for icons
WojtekBoman acca9e1
Add displayInDefaultIconColor prop, refactor ReceiptDropUI
WojtekBoman 8278968
Refactor CardPreview component
WojtekBoman cb4cef1
Refactor GenericErrorPage, AboutPage and SignInPageLayout's Footer
WojtekBoman 26d8084
Add icon name prop to components which display icons
WojtekBoman 0a6caa7
Update SidebarLinks
WojtekBoman 215f008
Add names to icon components
WojtekBoman aae9daf
Add jest-expo, refactor tests
WojtekBoman 86e6e77
Add avatarImageName prop to Avatar components
WojtekBoman f7d79c4
Add fixes to svg files
WojtekBoman d8b3805
Refactor passing prop displayInDefaultIconColor
WojtekBoman 1a0363a
Add fixes to display, lib versions, image prop types
WojtekBoman c56ffe4
Add lint fixes
WojtekBoman 6702b34
Add missing icon names
WojtekBoman 362d717
Update package-lock.json
WojtekBoman 8e3cfd4
Update package-lock.json
WojtekBoman 46165f7
Run prettier
WojtekBoman 7277fb9
Fix display SidebarLinks
WojtekBoman f70ff14
Fix displaying avatar fill color
WojtekBoman abc6444
Add ImageSVG component, remove unused code
WojtekBoman 95ffd02
Refactor ImageSVG properties description
WojtekBoman 575e5d4
Remove icon name props and add testID
WojtekBoman d69f0e4
Fix types for svg files
WojtekBoman eb79bed
Refactor image source prop types
WojtekBoman bad91c2
Add code fixes
WojtekBoman 6cdde08
Refactor code, add type fixes
WojtekBoman b83c44a
Remove unnecessary code, lint fixes
WojtekBoman 358168a
Add fix to sourcePropTypes
WojtekBoman 87d7141
Fix passing pointerEvents and preserveAspectRatio props to ImageSVG c…
WojtekBoman d47cba5
Bump expo-image version
WojtekBoman 126d419
Fix onLoad prop in Image component, fix prop types
WojtekBoman ca31c37
Fix propTypes in WalletSection
WojtekBoman 5cd6252
Bump expo-image version, add code fixes
WojtekBoman a5add23
Fix import CONST in ReceiptDropUI
WojtekBoman 5bdf3a6
Merge branch 'main' into expo-image
WojtekBoman 2477d53
Merge branch 'main' into expo-image
WojtekBoman 2d143fc
Merge branch 'main' into expo-image
WojtekBoman 450d83d
Merge branch 'main' into expo-image
WojtekBoman e10f7a1
Bump expo-image version
WojtekBoman cf7765a
Refactor default fill color value in BlockingView, Icon and HeaderWit…
WojtekBoman 0f7cbe9
Add ts fixes
WojtekBoman 9cf42a4
Merge branch 'main' into expo-image
WojtekBoman 2fdbbf3
Adjust ImageView to use expo-image
WojtekBoman 76ab7df
Fix displaying attachments
WojtekBoman c0d46f9
Merge branch 'main' into expo-image
WojtekBoman b8dc114
Merge branch 'main' into expo-image
WojtekBoman 7d845b6
Merge branch 'main' into expo-image
WojtekBoman b34572e
Merge branch 'main' into expo-image
WojtekBoman c661aa9
Fix zoom images in AttachmentCarouselPage
WojtekBoman 806449b
Fix setting scaledImage width and height
WojtekBoman 1ef612e
Fix icon colors
WojtekBoman 819a669
Merge branch 'main' into expo-image
WojtekBoman da40585
Fix default image size in AttachmentCarouselPage
WojtekBoman 6aa5a98
Merge branch 'main' into expo-image
WojtekBoman 0f6ad45
Fix hiding fallback image
WojtekBoman eca74d0
Merge branch 'main' into expo-image
WojtekBoman 015a6ce
Fix icon color in the BaseOptionsSelector component
WojtekBoman 2bc5843
Fix package.json files format
WojtekBoman 92d5953
Fix formatting package.json
WojtekBoman 7bfac55
Fix formatting package-lock.json
WojtekBoman 74f1be8
Merge branch 'main' into expo-image
WojtekBoman eff757e
Merge branch 'main' into expo-image
WojtekBoman cac6174
Merge branch 'main' into expo-image
WojtekBoman 1a2da77
Fix expensify-wordmark svg fill color
WojtekBoman a7e66d8
Merge branch 'main' into expo-image
WojtekBoman 571bc7f
Merge branch 'main' into expo-image
WojtekBoman bbda53a
Add IconAsset type, add lint fixes
WojtekBoman e2d8e56
Refactor default fill prop value in the Avatar component
WojtekBoman 8ed175b
Merge branch 'main' into expo-image
WojtekBoman 694470e
Refactor getDefaultWorkspaceAvatarTestID description
WojtekBoman 33adfff
Remove react-native-plaid-link-sdk patch
WojtekBoman 063c459
Fix displaying google icon
WojtekBoman 93f7548
Merge branch 'main' into expo-image
WojtekBoman 692c787
Merge branch 'main' into expo-image
WojtekBoman 03435e5
Move setIsActive to onLoadEnd in AttachmentCarouselPage
WojtekBoman 047cc65
Merge branch 'main' into expo-image
WojtekBoman 65ab438
Merge branch 'main' into expo-image
WojtekBoman e78a719
Fix lint
WojtekBoman b2cd949
Merge branch 'main' into expo-image
WojtekBoman 827cf90
Merge branch 'main' into expo-image
WojtekBoman edd627a
Merge branch 'main' into expo-image
WojtekBoman 9647214
Remove expo-asset and unnecessary comments
WojtekBoman 95e49d0
Migrate ImageSVG to TS
WojtekBoman a8d3096
Merge branch 'main' into expo-image
WojtekBoman 4d7b90c
Fix ts in HeaderUtils
WojtekBoman 17f0b67
Adjust home background fill color
WojtekBoman a4ec7dc
Merge branch 'main' into expo-image
WojtekBoman 221fe4e
Merge branch 'main' into expo-image
WojtekBoman c483c8a
Merge branch 'main' into expo-image
WojtekBoman 4d78a56
Fix imports order
WojtekBoman 45c8e31
Merge branch 'main' into expo-image
WojtekBoman 4900127
Merge branch 'main' into expo-image
WojtekBoman f8448ca
Merge branch 'main' into expo-image
WojtekBoman 5574239
Replace themeColors with useTheme
WojtekBoman 57d57ec
Adjust new components to expo-image
WojtekBoman ba157c1
Remove assets registry
WojtekBoman c939df1
Merge branch 'main' into expo-image
WojtekBoman 842830f
Merge branch 'main' into expo-image
WojtekBoman 09a703d
Merge branch 'main' into expo-image
WojtekBoman 1da3052
Refactor BackgroundImage, remove unnecessary props
WojtekBoman fabb0b0
Merge branch 'main' into expo-image
WojtekBoman b739e34
Merge branch 'main' into expo-image
WojtekBoman dcc4994
Add contentFit prop to MenuItem
WojtekBoman b856010
Merge branch 'main' into expo-image
WojtekBoman 06638b2
Merge branch 'main' into expo-image
WojtekBoman 0deaafd
chore: merge current main
WoLewicki 3dc4373
Refactor BankIcons nad PaymentMethodList
WojtekBoman e55ca4d
Run prettier on BankIconsUtils
WojtekBoman 7c4ef3f
Merge branch 'main' into expo-image
WojtekBoman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,3 +115,8 @@ yalc.lock | |
|
||
# Local https certificate/key | ||
config/webpack/*.pem | ||
|
||
# Expo | ||
.expo | ||
dist/ | ||
web-build/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change required? Can we skip it?
This post seems to imply we don't have to:
https://x.com/tsapeta/status/1734249424216355227?s=20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly or have experience to back this up, my instinct is that departing from the "standard config" for an app including Expo Modules is likely to cause more potential headaches than not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WojtekBoman or someone else from SWM/Expo- Can you confirm @roryabraham's instincts and/or assumptions above? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the required configuration to use expo in the project :) More information here: https://docs.expo.dev/bare/installing-expo-modules/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so that tweet is incorrect? Or maybe I am not understanding it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, theoretically it is not required to add those changes, but because that's what the
expo-modules
documentation states I think we should keep it. Especially if we're going to use another module -expo-av
for video playback.I think it is also safer to keep those changes, because the expo team would assume that the modules setup is done according to the documentation. It will save us some potential problems during future upgrades.