Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when opening a split bill preview on an #announce room #31291

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Fix crash when opening a split bill preview on an #announce room #31291

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92a9e35
set a default transaction value
bernhardoj Nov 14, 2023
55e8fcd
Merge branch 'main' into fix/31136-crash-on-opening-on-loading-split-…
bernhardoj Nov 20, 2023
aa71142
make transaction back to required
bernhardoj Nov 20, 2023
25e3b56
disable press when transaction is not available
bernhardoj Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/iou/SplitBillDetailsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const propTypes = {
reportActions: PropTypes.shape(reportActionPropTypes),

/** The current transaction */
transaction: transactionPropTypes.isRequired,
transaction: transactionPropTypes,

/** The draft transaction that holds data to be persisited on the current transaction */
draftTransaction: transactionPropTypes,
Expand Down Expand Up @@ -66,6 +66,7 @@ const propTypes = {
const defaultProps = {
personalDetails: {},
reportActions: {},
transaction: {},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to use the alternate solution as this also fix the prop types console error.

draftTransaction: undefined,
};

Expand Down
Loading