-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login via deeplink should open modal in request money #31529
Merged
robertjchen
merged 20 commits into
Expensify:main
from
dukenv0307:fix/29115-open-description-when-login-with-deeplink
May 31, 2024
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ece06a0
fix: login via deeplink should open modal in request money
dukenv0307 585b3f9
fix: conditions
dukenv0307 7adeaef
open report when transaction is empty
dukenv0307 78e9ce8
Merge branch 'main' into fix/29115-open-description-when-login-with-d…
dukenv0307 e859d6a
merge main
dukenv0307 002c909
fix lint
dukenv0307 58e7687
fix lint
dukenv0307 9907af9
merge main
dukenv0307 01ab53d
fix lint
dukenv0307 eeedc25
merge main
dukenv0307 76c4cd9
merge main
dukenv0307 86d123e
Merge branch 'main' into fix/29115-open-description-when-login-with-d…
dukenv0307 c24f80a
reset code change
dukenv0307 07a70af
Fix not found page appear when openning edit page by deeplink
dukenv0307 843be86
merge main
dukenv0307 d2b1fd7
Merge branch 'main' into fix/29115-open-description-when-login-with-d…
dukenv0307 8ea33c2
Merge branch 'main' into fix/29115-open-description-when-login-with-d…
dukenv0307 b037e7f
merge main
dukenv0307 4ed9add
Merge branch 'main' into fix/29115-open-description-when-login-with-d…
dukenv0307 0103f4c
Merge branch 'main' into fix/29115-open-description-when-login-with-d…
dukenv0307 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dukenv0307 I am not entirely sure on what changes we are making here since this PR is very old and the new changes are different than the accepted proposal.
Could you let me know the changes and why we need to do this and how will it fix the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdulrahuman5196 The bug still happens after we refactor the edit flow. The RCA is we don't have the logic to display the loading page when the report is loading. My solution is we will handle this in
withWritableReportOrNotFound
HOC so all pages of money request flow can display a loading page when the report is loading. That's why we have to wrap that HOC on the outside.