Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/16184 base options selector refactoring #31606

Merged
Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
ea2551d
BaseOptionsSelector refactoring
Piotrfj Nov 20, 2023
bf38ece
BaseOptionsSelector prettier
Piotrfj Nov 20, 2023
368b708
fix props
Piotrfj Nov 21, 2023
e3b8192
bing back normal props to make code cleaner
Piotrfj Dec 4, 2023
d7aaf8f
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Dec 4, 2023
ca03827
clean code after pulled changes
Piotrfj Dec 5, 2023
ebef308
prettier
Piotrfj Dec 5, 2023
5145589
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Dec 5, 2023
70cd0a1
fix lint issues
Piotrfj Dec 6, 2023
716d2a2
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Dec 7, 2023
62d1b31
fix: fix linting errors
koko57 Dec 8, 2023
272633f
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Dec 8, 2023
e8d1fbc
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Dec 11, 2023
7a3a1d0
fix: fix autoFocus, ArrowKeyFocusManager, remove shouldDelayFocus
koko57 Dec 12, 2023
c0801ee
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Dec 12, 2023
0f62e50
fix: resolve conflicts
koko57 Dec 13, 2023
66fde97
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Dec 14, 2023
6c8e063
fix: correct imports
koko57 Dec 14, 2023
13032d8
fix: minor fix
koko57 Dec 14, 2023
00e2a2b
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Dec 15, 2023
15de776
fix: wrap some functions in useCallback
koko57 Dec 15, 2023
594d72a
fix: run prettier
koko57 Dec 15, 2023
4f9106a
fix: wrap functions in useCallback
koko57 Dec 15, 2023
54e9ef0
fix: minor fix
koko57 Dec 15, 2023
723e87e
fix: resolve conflicts
koko57 Dec 18, 2023
fc1752c
fix: restore latest changes to BaseOptionsSelector
koko57 Dec 18, 2023
a3217ec
fix: resolve conflicts
koko57 Dec 20, 2023
163e377
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Dec 20, 2023
e129ed0
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Dec 21, 2023
458f8b6
fix: resolve conflicts
koko57 Dec 22, 2023
fbe28e9
fix scrolling by arrow keys
Piotrfj Dec 28, 2023
8c2349d
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Dec 28, 2023
0795f86
prettier
Piotrfj Dec 29, 2023
b6f4a8c
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Jan 2, 2024
1ad06dd
fix performance test and scrolling
Piotrfj Jan 10, 2024
3ad5847
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Jan 10, 2024
abf994b
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Jan 18, 2024
3adcfde
merge and refacotor new changes
Piotrfj Jan 18, 2024
6bb75ae
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Jan 18, 2024
c59ab5d
fix lint
Piotrfj Jan 19, 2024
fb4199e
fix lint
Piotrfj Jan 19, 2024
2120852
fix lint
Piotrfj Jan 19, 2024
febecc0
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Jan 30, 2024
7892399
prettier
Piotrfj Jan 30, 2024
0081e47
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Feb 1, 2024
81fd3f9
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Feb 2, 2024
69125ed
fix: resolve conflicts
koko57 Feb 5, 2024
31623d6
fix: do not scrollToIndex when props.section is empty
koko57 Feb 6, 2024
de356c9
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Feb 6, 2024
a7086cd
fix: prettier
koko57 Feb 6, 2024
312e622
fix: resolve conflicts
koko57 Feb 8, 2024
0344bf8
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Feb 13, 2024
6e34b98
fix document undefined
Piotrfj Feb 14, 2024
797e698
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Feb 14, 2024
6c2ec03
Merge remote-tracking branch 'origin/fix/16184-BaseOptionsSelector-re…
Piotrfj Feb 14, 2024
c451c99
Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring
koko57 Feb 16, 2024
fd0302e
Merge branch 'main' of https://github.com/Expensify/App into fix/1618…
Piotrfj Feb 23, 2024
dcc4ceb
Merge remote-tracking branch 'origin/fix/16184-BaseOptionsSelector-re…
Piotrfj Feb 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: correct imports
  • Loading branch information
koko57 committed Dec 14, 2023
commit 6c8e063c4feffb4c4eb9fa60290bd6a0a0b2e4f6
4 changes: 2 additions & 2 deletions src/components/OptionsSelector/BaseOptionsSelector.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ import useLocalize from '@hooks/useLocalize';
import getPlatform from '@libs/getPlatform';
import Navigation from '@libs/Navigation/Navigation';
import setSelection from '@libs/setSelection';
import useTheme from '@styles/themes/useTheme';
import useThemeStyles from '@styles/useThemeStyles';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import CONST from '@src/CONST';
import ROUTES from '@src/ROUTES';
import {defaultProps as optionsSelectorDefaultProps, propTypes as optionsSelectorPropTypes} from './optionsSelectorPropTypes';
Expand Down
Loading