Revert "Allow receipt recovery if the upload fails"

src/CONST.ts

@@ -1154,7 +1154,6 @@ const CONST = {
             DOCX: 'docx',
             SVG: 'svg',
         },
-        RECEIPT_ERROR: 'receiptError',
     },
 
     GROWL: {

src/components/DotIndicatorMessage.tsx

@@ -1,19 +1,14 @@
 /* eslint-disable react/no-array-index-key */
 import React from 'react';
 import {StyleProp, TextStyle, View, ViewStyle} from 'react-native';
-import fileDownload from '@libs/fileDownload';
 import * as Localize from '@libs/Localize';
 import * as StyleUtils from '@styles/StyleUtils';
 import useTheme from '@styles/themes/useTheme';
 import useThemeStyles from '@styles/useThemeStyles';
-import CONST from '@src/CONST';
 import Icon from './Icon';
 import * as Expensicons from './Icon/Expensicons';
-import {PressableWithoutFeedback} from './Pressable';
 import Text from './Text';
 
-type ReceiptError = {error?: string; source: string; filename: string};
-
 type DotIndicatorMessageProps = {
     /**
      * In most cases this should just be errors from onxyData
@@ -34,14 +29,6 @@ type DotIndicatorMessageProps = {
     textStyles?: StyleProp<TextStyle>;
 };
 
-/** Check if the error includes a receipt. */
-function isReceiptError(message: string | ReceiptError): message is ReceiptError {
-    if (typeof message === 'string') {
-        return false;
-    }
-    return (message?.error ?? '') === CONST.IOU.RECEIPT_ERROR;
-}
-
 function DotIndicatorMessage({messages = {}, style, type, textStyles}: DotIndicatorMessageProps) {
     const theme = useTheme();
     const styles = useThemeStyles();
@@ -69,35 +56,14 @@ function DotIndicatorMessage({messages = {}, style, type, textStyles}: DotIndica
                 />
             </View>
             <View style={styles.offlineFeedback.textContainer}>
-                {uniqueMessages.map((message, i) =>
-                    isReceiptError(message) ? (
-                        <PressableWithoutFeedback
-                            accessibilityLabel={Localize.translateLocal('iou.error.saveFileMessage')}
-                            key={i}
-                            accessibilityRole={CONST.ACCESSIBILITY_ROLE.LINK}
-                            onPress={() => {
-                                fileDownload(message.source, message.filename);
-                            }}
-                        >
-                            <Text
-                                key={i}
-                                style={styles.offlineFeedback.text}
-                            >
-                                <Text style={[styles.optionAlternateText, styles.textLabelSupporting]}>{Localize.translateLocal('iou.error.receiptFailureMessage')}</Text>
-                                <Text style={[styles.optionAlternateText, styles.textLabelSupporting, styles.link]}>{Localize.translateLocal('iou.error.saveFileMessage')}</Text>
-                                <Text style={[styles.optionAlternateText, styles.textLabelSupporting]}>{Localize.translateLocal('iou.error.loseFileMessage')}</Text>
-                            </Text>
-                        </PressableWithoutFeedback>
-                    ) : (
-                        <Text
-                            // eslint-disable-next-line react/no-array-index-key
-                            key={i}
-                            style={[StyleUtils.getDotIndicatorTextStyles(isErrorMessage), textStyles]}
-                        >
-                            {message}
-                        </Text>
-                    ),
-                )}
+                {uniqueMessages.map((message, i) => (
+                    <Text
+                        key={i}
+                        style={[StyleUtils.getDotIndicatorTextStyles(isErrorMessage), textStyles]}
+                    >
+                        {message}
+                    </Text>
+                ))}
             </View>
         </View>
     );

src/components/MessagesRow.js

@@ -15,9 +15,7 @@ import Tooltip from './Tooltip';
 
 const propTypes = {
     /** The messages to display */
-    messages: PropTypes.objectOf(
-        PropTypes.oneOfType([PropTypes.oneOfType([PropTypes.string, PropTypes.object]), PropTypes.arrayOf(PropTypes.oneOfType([PropTypes.string, PropTypes.object]))]),
-    ),
+    messages: PropTypes.objectOf(PropTypes.oneOfType([PropTypes.string, PropTypes.arrayOf(PropTypes.oneOfType([PropTypes.string, PropTypes.object]))])),
 
     /** The type of message, 'error' shows a red dot, 'success' shows a green dot */
     type: PropTypes.oneOf(['error', 'success']).isRequired,

src/languages/en.ts

@@ -593,9 +593,6 @@ export default {
             invalidSplit: 'Split amounts do not equal total amount',
             other: 'Unexpected error, please try again later',
             genericCreateFailureMessage: 'Unexpected error requesting money, please try again later',
-            receiptFailureMessage: "The receipt didn't upload. ",
-            saveFileMessage: 'Download the file ',
-            loseFileMessage: 'or dismiss this error and lose it',
             genericDeleteFailureMessage: 'Unexpected error deleting the money request, please try again later',
             genericEditFailureMessage: 'Unexpected error editing the money request, please try again later',
             genericSmartscanFailureMessage: 'Transaction is missing fields',

src/languages/es.ts

@@ -587,9 +587,6 @@ export default {
             invalidSplit: 'La suma de las partes no equivale al monto total',
             other: 'Error inesperado, por favor inténtalo más tarde',
             genericCreateFailureMessage: 'Error inesperado solicitando dinero, Por favor, inténtalo más tarde',
-            receiptFailureMessage: 'El recibo no se subió. ',
-            saveFileMessage: 'Guarda el archivo ',
-            loseFileMessage: 'o descarta este error y piérdelo',
             genericDeleteFailureMessage: 'Error inesperado eliminando la solicitud de dinero. Por favor, inténtalo más tarde',
             genericEditFailureMessage: 'Error inesperado al guardar la solicitud de dinero. Por favor, inténtalo más tarde',
             genericSmartscanFailureMessage: 'La transacción tiene campos vacíos',

src/libs/ErrorUtils.ts

@@ -42,14 +42,6 @@ function getMicroSecondOnyxError(error: string): Record<number, string> {
     return {[DateUtils.getMicroseconds()]: error};
 }
 
-/**
- * Method used to get an error object with microsecond as the key and an object as the value.
- * @param error - error key or message to be saved
- */
-function getMicroSecondOnyxErrorObject(error: Record<string, string>): Record<number, Record<string, string>> {
-    return {[DateUtils.getMicroseconds()]: error};
-}
-
 type OnyxDataWithErrors = {
     errors?: Errors;
 };
@@ -119,4 +111,4 @@ function addErrorMessage<TKey extends TranslationPaths>(errors: ErrorsList, inpu
     }
 }
 
-export {getAuthenticateErrorMessage, getMicroSecondOnyxError, getMicroSecondOnyxErrorObject, getLatestErrorMessage, getLatestErrorField, getEarliestErrorField, addErrorMessage};
+export {getAuthenticateErrorMessage, getMicroSecondOnyxError, getLatestErrorMessage, getLatestErrorField, getEarliestErrorField, addErrorMessage};

src/libs/actions/IOU.js

@@ -141,18 +141,6 @@ function resetMoneyRequestInfo(id = '') {
     });
 }
 
-/**
- *  Helper function to get the receipt error for money requests, or the generic error if there's no receipt
- *
- * @param {Object} receipt
- * @returns {Object}
- */
-function getReceiptError(receipt) {
-    return _.isEmpty(receipt)
-        ? ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage')
-        : ErrorUtils.getMicroSecondOnyxErrorObject({error: CONST.IOU.RECEIPT_ERROR, source: receipt.source, filename: receipt.filename});
-}
-
 function buildOnyxDataForMoneyRequest(
     chatReport,
     iouReport,
@@ -356,7 +344,7 @@ function buildOnyxDataForMoneyRequest(
                 ...(isNewChatReport
                     ? {
                           [chatCreatedAction.reportActionID]: {
-                              errors: getReceiptError(transaction.receipt),
+                              errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage'),
                           },
                           [reportPreviewAction.reportActionID]: {
                               errors: ErrorUtils.getMicroSecondOnyxError(null),
@@ -365,7 +353,7 @@ function buildOnyxDataForMoneyRequest(
                     : {
                           [reportPreviewAction.reportActionID]: {
                               created: reportPreviewAction.created,
-                              errors: getReceiptError(transaction.receipt),
+                              errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage'),
                           },
                       }),
             },
@@ -377,15 +365,15 @@ function buildOnyxDataForMoneyRequest(
                 ...(isNewIOUReport
                     ? {
                           [iouCreatedAction.reportActionID]: {
-                              errors: getReceiptError(transaction.receipt),
+                              errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage'),
                           },
                           [iouAction.reportActionID]: {
                               errors: ErrorUtils.getMicroSecondOnyxError(null),
                           },
                       }
                     : {
                           [iouAction.reportActionID]: {
-                              errors: getReceiptError(transaction.receipt),
+                              errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage'),
                           },
                       }),
             },
@@ -1445,7 +1433,7 @@ function startSplitBill(participants, currentUserLogin, currentUserAccountID, co
             key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${splitChatReport.reportID}`,
             value: {
                 [splitIOUReportAction.reportActionID]: {
-                    errors: getReceiptError(receipt),
+                    errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage'),
                 },
             },
         });
@@ -1468,7 +1456,7 @@ function startSplitBill(participants, currentUserLogin, currentUserAccountID, co
                         errors: ErrorUtils.getMicroSecondOnyxError('report.genericCreateReportFailureMessage'),
                     },
                     [splitIOUReportAction.reportActionID]: {
-                        errors: getReceiptError(receipt),
+                        errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage'),
                     },
                 },
             },