Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Show Business Bank account as payment option on expense reports #31908

Merged
merged 3 commits into from
Nov 27, 2023
Merged

[CP Staging] Show Business Bank account as payment option on expense reports #31908

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65c73c1
Show the business bank account as an option for workspace chats
mountiny Nov 27, 2023
66cf348
Move the conditional to its on variable in AddPaymentsMethod
mountiny Nov 27, 2023
a137813
Lint
mountiny Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/AddPaymentMethodMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ const defaultProps = {
function AddPaymentMethodMenu({isVisible, onClose, anchorPosition, anchorAlignment, anchorRef, iouReport, onItemSelected, session}) {
const {translate} = useLocalize();

// Users can choose to pay with business bank account in case of Expense reports or in case of P2P IOU report
// which then starts a bottom up flow and creates a Collect workspace where the payer is an admin and payee is an employee.
const canUseBusinessBankAccount =
ReportUtils.isExpenseReport(iouReport) ||
(ReportUtils.isIOUReport(iouReport) && !ReportActionsUtils.hasRequestFromCurrentAccount(lodashGet(iouReport, 'reportID', 0), lodashGet(session, 'accountID', 0)));

return (
<PopoverMenu
isVisible={isVisible}
Expand All @@ -84,7 +90,7 @@ function AddPaymentMethodMenu({isVisible, onClose, anchorPosition, anchorAlignme
},
]
: []),
...(!ReportActionsUtils.hasRequestFromCurrentAccount(lodashGet(iouReport, 'reportID', 0), lodashGet(session, 'accountID', 0))
...(canUseBusinessBankAccount
? [
{
text: translate('common.businessBankAccount'),
Expand Down
Loading