-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form Provider Refactor] WorkspaceInviteMessagePage #32139
[Form Provider Refactor] WorkspaceInviteMessagePage #32139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please refactor this component to function?
Context: #25397 (comment)
merge main into form-refactor/workspace-invite-message-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minor nits I didn't spot previously, overall it looks good 👍
cc: @c3024 |
merge main into form-refactor/workspace-invite-message-page
Hello @luacmartins! I think it's the last component to be migrated, so as soon as this PR will be merged, we can delete |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeinviteAndroidChrome.mp4iOS: NativeinviteMessageiOSNative.moviOS: mWeb SafariinviteMessageiOSSafari.movMacOS: Chrome / SafariinviteMessageMacChrome.movMacOS: DesktopinviteMessageDesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cdOut Please pull main as the android app is crashing and there was a revert PR here |
…space-invite-message-page
Since @cdOut is OOO today, I did the rebase so we can proceed with the merge. @luacmartins I think now it's all yours. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.15-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.15-5 🚀
|
Details
Form migration, add FormProvider in WorkspaceInviteMessagePage
Fixed Issues
$ #31564
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
ANDROID-NATIVE.mov
Android: mWeb Chrome
ANDROID-CHROME.mov
iOS: Native
IOS-NATIVE.mov
iOS: mWeb Safari
IOS-SAFARI.mov
MacOS: Chrome / Safari
CHROME.mov
MacOS: Desktop
DESKTOP.mov