Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] [Wave8] Breadcrumbs #32221

Merged
merged 46 commits into from
Dec 18, 2023
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
6f3fc56
Change size of Expensify logo
MaciejSWM Nov 28, 2023
ced4c37
Breadcrumbs WIP
MaciejSWM Nov 28, 2023
0bfd97e
Breadcrumb types
MaciejSWM Nov 29, 2023
6c66b08
Pixel perfect alignments
MaciejSWM Nov 29, 2023
ce3c4ea
Align text on mobile devices
MaciejSWM Nov 29, 2023
5209597
Handle DEV badge nicely
MaciejSWM Nov 29, 2023
fbd4789
Add unique keys for each breadcrumb
MaciejSWM Nov 29, 2023
1218a42
Align text on mobile
MaciejSWM Nov 29, 2023
a8a2e38
Unique key
MaciejSWM Nov 29, 2023
857c104
Fix missing key
MaciejSWM Nov 29, 2023
737480f
Fix styles not being applied to header
MaciejSWM Nov 29, 2023
08cd12b
Breadcrumbs storybook
MaciejSWM Nov 29, 2023
a81da06
Rename story
MaciejSWM Nov 30, 2023
87b5b5b
Use theme instead of colors
MaciejSWM Dec 1, 2023
125626a
Remove explicit margin - use flex adjustments
MaciejSWM Dec 1, 2023
694d6ad
Single quote instead of backtick
MaciejSWM Dec 4, 2023
1dba8b0
Drop test breadcrumbs
MaciejSWM Dec 4, 2023
5dbffff
Pixel-perfect alignment
MaciejSWM Dec 4, 2023
8e3309c
Drop unused import
MaciejSWM Dec 4, 2023
9467923
Merge branch 'main' into wave8/breadcrumbs
MaciejSWM Dec 5, 2023
c276ae2
Pixel perfect adjustments
MaciejSWM Dec 5, 2023
74d8e2b
Change color of separator to match Figma
MaciejSWM Dec 5, 2023
3c415dc
Restore initial iconHeight
MaciejSWM Dec 5, 2023
fdad0cc
Drop unnecessary keys
MaciejSWM Dec 5, 2023
3dd6fca
Wrap separator and text inside of text to glue it together
MaciejSWM Dec 5, 2023
d0fd4a6
Rename root to header
MaciejSWM Dec 11, 2023
fa46d37
Allow only two elements in Breadcrumbs array
MaciejSWM Dec 11, 2023
d121272
Refactor: Allow only up to two levels breadcrumbs
MaciejSWM Dec 11, 2023
62f576b
Rename const for breadcrumb
MaciejSWM Dec 11, 2023
6eb2110
Drop old breadcrumb styles
MaciejSWM Dec 11, 2023
2fdbd74
Max width helper style
MaciejSWM Dec 11, 2023
3d394ff
Fix alignment
MaciejSWM Dec 11, 2023
0383f26
Drop Normal story sample - not used in app
MaciejSWM Dec 11, 2023
90304da
Add styles from breadcrumb style
MaciejSWM Dec 11, 2023
0a9afd7
Merge branch 'main' into wave8/breadcrumbs
MaciejSWM Dec 12, 2023
333fb45
Adjust colors after main merge
MaciejSWM Dec 12, 2023
7c7051c
Pixel perfect logo height adjustment
MaciejSWM Dec 12, 2023
bb7dda3
Logo width exactly like in Figma
MaciejSWM Dec 12, 2023
27357f4
Merge branch 'main' into wave8/breadcrumbs
MaciejSWM Dec 14, 2023
9a0c2e0
Change import paths
MaciejSWM Dec 14, 2023
e5cc42e
Merge branch 'main' into wave8/breadcrumbs
MaciejSWM Dec 18, 2023
22864a4
Convert object to boolean before doing AND on it
MaciejSWM Dec 18, 2023
39784fb
Migrate Storybook file to TS
MaciejSWM Dec 18, 2023
f14e7b4
Add optional style prop
MaciejSWM Dec 18, 2023
e0cef1a
Export type to use in storybook
MaciejSWM Dec 18, 2023
0d30c94
Prop description
MaciejSWM Dec 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Drop test breadcrumbs
  • Loading branch information
MaciejSWM committed Dec 4, 2023
commit 1dba8b00e54ca82cbe2cb5aa20b6bc931e76541f
25 changes: 0 additions & 25 deletions src/pages/home/sidebar/SidebarLinks.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,31 +178,6 @@ function SidebarLinks({onLinkClick, insets, optionListItems, isLoading, priority
</Tooltip>
<SignInOrAvatarWithOptionalStatus isCreateMenuOpen={isCreateMenuOpen} />
</View>
<View style={[styles.mh5, styles.mb3]}>
<Breadcrumbs
breadcrumbs={[
{
type: CONST.BREADCRUMB_TYPE.ROOT,
},
{
text: 'Chats',
},
]}
/>
</View>
<View style={[styles.mh5, styles.mb3]}>
<Breadcrumbs
breadcrumbs={[
{
text: 'Cathy`s Croissants',
type: CONST.BREADCRUMB_TYPE.STRONG,
},
{
text: 'Settings',
},
]}
/>
</View>
<View style={[styles.pRelative, styles.flex1]}>
<LHNOptionsList
style={styles.flex1}
Expand Down