Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] change webpack config and rename .web files to .website files #32548

Merged
merged 2 commits into from
Dec 7, 2023
+16 −2
Merged

[NoQA] change webpack config and rename .web files to .website files #32548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
820fb32
rename .web files to .website files
SzymczakJ Dec 6, 2023
cd7ba79
make webpack take .website.tsx files
SzymczakJ Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion config/webpack/webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,21 @@ const webpackConfig = ({envFile = '.env', platform = 'web'}) => ({
// This is also why we have to use .website.js for our own web-specific files...
// Because desktop also relies on "web-specific" module implementations
// This also skips packing web only dependencies to desktop and vice versa
extensions: ['.web.js', platform === 'web' ? '.website.js' : '.desktop.js', '.js', '.jsx', '.web.ts', platform === 'web' ? '.website.ts' : '.desktop.ts', '.ts', '.web.tsx', '.tsx'],
extensions: [
'.web.js',
...(platform === 'desktop' ? ['.desktop.js'] : []),
'.website.js',
'.js',
'.jsx',
'.web.ts',
...(platform === 'desktop' ? ['.desktop.ts'] : []),
'.website.ts',
...(platform === 'desktop' ? ['.desktop.tsx'] : []),
'.website.tsx',
'.ts',
'.web.tsx',
'.tsx',
],
fallback: {
'process/browser': require.resolve('process/browser'),
},
Expand Down
0 src/components/MapView/Direction.web.tsx → src/components/MapView/Direction.website.tsx
View file
Open in desktop
File renamed without changes.
0 src/components/MapView/MapView.web.tsx → src/components/MapView/MapView.website.tsx
View file
Open in desktop
File renamed without changes.
0 ...ailsTooltip/BaseUserDetailsTooltip.web.js → ...Tooltip/BaseUserDetailsTooltip.website.js
View file
Open in desktop
File renamed without changes.
0 src/libs/Browser/index.web.ts → src/libs/Browser/index.website.ts
View file
Open in desktop
File renamed without changes.
0 src/libs/StatusBar/index.web.ts → src/libs/StatusBar/index.website.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@
}
},
"exclude": ["**/node_modules/*", "**/dist/*", ".github/actions/**/index.js", "**/docs/*"],
"include": ["src", "desktop", "web", "docs", "assets", "config", "tests", "jest", "__mocks__", ".github/**/*", ".storybook/**/*"]
"include": ["src", "desktop", "web", "website", "docs", "assets", "config", "tests", "jest", "__mocks__", ".github/**/*", ".storybook/**/*"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config change caused #40152.

I don't think so that we would had prevented this though.

}
Loading