Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS Communication Notifications #32765

Merged
merged 51 commits into from
Dec 27, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
523578f
add notification service extension
arosiclair Dec 8, 2023
4335e95
move embed extensions build phase to fix build
arosiclair Dec 8, 2023
53272e9
use airship's UANotificationServiceExtension
arosiclair Dec 11, 2023
9f0e214
use iOS 13 minimum target
arosiclair Dec 11, 2023
794eb84
re-add default implementations
arosiclair Dec 11, 2023
5ff5826
check for payload properties
arosiclair Dec 12, 2023
6b192da
Merge branch 'arosiclair-clear-read-notifications' into arosiclair-io…
arosiclair Dec 12, 2023
83c0b93
use os_log instead of print
arosiclair Dec 13, 2023
315cf25
Add ExpError for throwing runtime errors with messages
arosiclair Dec 14, 2023
75bdc80
parse notification data
arosiclair Dec 14, 2023
daf5876
Merge branch 'arosiclair-clear-read-notifications' into arosiclair-io…
arosiclair Dec 14, 2023
91d7c7d
parse accountID
arosiclair Dec 14, 2023
73a49b6
parse the user's name
arosiclair Dec 14, 2023
b7c5cdb
add communication notification entitlement
arosiclair Dec 14, 2023
4707aba
add INSendMessageIntent
arosiclair Dec 14, 2023
de5d126
move NSUserActivityTypes to the main bundle
arosiclair Dec 15, 2023
fbc2eb1
create message intents and configure communication notifications
arosiclair Dec 15, 2023
c0d636e
parse message text
arosiclair Dec 15, 2023
e61d242
use updated INSendMessageIntent
arosiclair Dec 15, 2023
82245cf
fetch and use avatar
arosiclair Dec 15, 2023
2e22250
error handling
arosiclair Dec 15, 2023
718222e
parse and use roomName
arosiclair Dec 15, 2023
bad32ec
use formatted title
arosiclair Dec 17, 2023
b57be15
remove unused NotificationData properties
arosiclair Dec 17, 2023
8942cd0
remove unused var
arosiclair Dec 17, 2023
640eaa0
rename to just NotificationServiceExtension
arosiclair Dec 17, 2023
67d8610
fix pod install warnings for overriden settings
arosiclair Dec 17, 2023
2fe775f
configure the group/room name
arosiclair Dec 17, 2023
b8e343a
Merge branch 'main' of github.com:Expensify/App into arosiclair-ios-c…
arosiclair Dec 17, 2023
e5b8b3f
update bundle IDs for adhoc and prod
arosiclair Dec 17, 2023
055e64c
use manual signing to match the main app target
arosiclair Dec 17, 2023
fd11e2d
podfile lock update
arosiclair Dec 17, 2023
506ac9e
use iphone distribution like the main target
arosiclair Dec 19, 2023
99c4c50
Merge branch 'main' of github.com:Expensify/App into arosiclair-ios-c…
arosiclair Dec 19, 2023
a7ca53f
podfile update
arosiclair Dec 19, 2023
f734310
comment pointing to docs for comms notifications
arosiclair Dec 19, 2023
9115cc8
Update provisioning profiles in xcode project
AndrewGable Dec 19, 2023
44d09e5
Update with new profiles for Notification Service
AndrewGable Dec 19, 2023
ae48bdc
comment updates
arosiclair Dec 19, 2023
13beb5f
Tweaking configs for test and AdHoc
AndrewGable Dec 19, 2023
c39c67e
Tweak provisioning profile config
AndrewGable Dec 19, 2023
7707911
remove xcargs override
arosiclair Dec 19, 2023
2b451b2
use new profile names
arosiclair Dec 19, 2023
73a37f1
set provisioning profiles for AppStore build
arosiclair Dec 19, 2023
d09f9d7
fix grep check
arosiclair Dec 19, 2023
5b9810d
Merge branch 'main' of github.com:Expensify/App into arosiclair-ios-c…
arosiclair Dec 20, 2023
9788965
rename mock steps and assertions
arosiclair Dec 20, 2023
5b0ec5b
Merge branch 'main' into arosiclair-ios-comms-notifications
roryabraham Dec 24, 2023
8725cd2
Clean build after merge
roryabraham Dec 24, 2023
672d6ff
Fix workflow_tests
roryabraham Dec 25, 2023
a39f711
fix dev bundle IDs for NSE
arosiclair Dec 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move NSUserActivityTypes to the main bundle
  • Loading branch information
arosiclair committed Dec 15, 2023
commit de5d1262b12b6034655d9d2e5841a04764f15bb4
4 changes: 0 additions & 4 deletions ios/CustomNotificationServiceExtension/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
<string>com.apple.usernotifications.service</string>
<key>NSExtensionPrincipalClass</key>
<string>$(PRODUCT_MODULE_NAME).NotificationService</string>
<key>NSUserActivityTypes</key>
<array>
<string>INSendMessageIntent</string>
</array>
</dict>
</dict>
</plist>
4 changes: 4 additions & 0 deletions ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -124,5 +124,9 @@
<string>Dark</string>
<key>UIViewControllerBasedStatusBarAppearance</key>
<false/>
<key>NSUserActivityTypes</key>
<array>
<string>INSendMessageIntent</string>
</array>
</dict>
</plist>