-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] [Wave8] Workspace List Items #32817
Changes from 49 commits
6ed9bcb
4346c84
c1e3d60
64b8143
e4aaaec
11bf35f
b8f3bde
3cc533c
4ac804d
b48be5a
97f5c1b
0545dd7
2db6405
a4ce86e
d5182e8
6927f9f
d4aeb3f
175b74c
31fc5fe
bbb1cb9
0ba4a29
a5da6e5
a897973
760c924
8aae624
5832829
91545df
2dfe4aa
81aad00
a73d34b
1c37275
d4aff8a
97402b4
27ada44
5d15d12
c915923
819a131
6727a24
b324fb0
bd678ad
9133ee4
cb54be7
57a533a
72f2df3
6bba756
67ecbbe
0ae0641
410915d
9fb3e34
db6b0fd
39628d0
2bb86cd
8bb6d4d
657b3fd
7938e1e
e212e7d
cae203d
02660a0
db9ff9e
015cbc3
20eb6ba
102cbbd
7048a20
a0b55e0
4d7cc3a
0502b00
2498c82
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,11 @@ Onyx.connect({ | |
* @param [defaultValue] optional default display name value | ||
*/ | ||
function getDisplayNameOrDefault(displayName?: string, defaultValue = ''): string { | ||
return displayName ?? defaultValue ?? Localize.translateLocal('common.hidden'); | ||
// Not using nullish coalescing as it differs from OR for strings. For example: | ||
// '' || 'A' === 'A' | ||
// '' ?? 'A' === '' | ||
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing | ||
return displayName || defaultValue || Localize.translateLocal('common.hidden'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! This fixes something happening on production? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Umm, I'm not sure if it fixes any known bugs and definitely I'm hoping that it doesn't create any. |
||
} | ||
|
||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is too general. Don't know which layout it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LAYOUT_WIDTH
? Then it'sLAYOUT_WIDTH.WIDE
andLAYOUT_WIDTH.NARROW
. I aimed at this being general, didn't want it to be only tied to a single place in the app.