-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Use vanilla setupGitForOSBotify action in createNewVersion.yml #32848
Conversation
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Requesting review from @mountiny as he has context from https://expensify.slack.com/archives/C03V9A4TB/p1701345996461099 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosN/A - CI/CD Android: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, going to merge now that Marco also approved
Ah seems like the github actions tests are failing 😢 @roryabraham so gonna have to wait for that to get resolved |
Yeah, I think it usually happens when a GH action changes, but yeah better to wait for @roryabraham to confirm |
These new workflow_tests are kind of a PITA because some of the basic JS representation of our workflows are generated once and committed rather than being generated on the fly. In this particular case, I'm running into an unrelated problem trying to run these tests locally. Anyways, I'll see if I can try to fix these |
Tests are passing now, ready for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to go ahead and merge now, thanks for fixing!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.13-0 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.13-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.13-8 🚀
|
Details
This is a case where I've identified we do not need to set up the OSBotify app, just the git config. Since
setupGitForOSBotifyApp
has been flaky, I'm creating this PR to just use the stable "vanilla" version ofsetupGitForOSBotify
.Fixed Issues
(partial) #31571
Tests
Merge this PR and run a staging or production deploy. Verify that
createNewVersion.yml
completes successfully.Offline tests
None.
QA Steps
None.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop