[CP Staging] Track when a split is created from global create to call proper API #32878

tgolen · 2023-12-11T23:00:46Z

Details

The original intention of the SplitBill and SplitBillAndOpenReport API commands was to call them depending on if the user started the request from an existing chat or from the global create menu (respectively).

When I refactored things, the concept of "starting from global create" really morphed into a concept of "is this reportID in the URL from an optimistic report or a real report". I thought it would also work for the split case, but it doesn't look like it works very well.

In order to resolve the blocker with urgency, I have added a flag into the Onyx draft to indicate whether or not the request started from the global create menu or not. This results in the correct APIs being called with the correct reportID now.

Fixed Issues

$ #32853

Tests

First Test

Create an account
Open Global create menu and choose request
Select the manual option
Fill out an amount and click next
Select two participants (try requests with both existing users and brand new users) and click next
Create the request
Verify that you are properly taken to the group chat with the request showing

Second Test

Create an account
Open Global create menu and choose request
Select the scan option
Upload a file and click next
Select two participants (try requests with both existing users and brand new users) and click next
Create the request
Verify that you are properly taken to the group chat with the request showing and a receipt in scanning progress

Third Test

Go to a group chat with two or more people
Click the + in the composer
Choose the option to split bill
Enter an amount and click next
Submit the request
Verify you stay in the chat and see the split request

Verify that no errors appear in the JS console

Offline tests

Same as the above

QA Steps

Same as the above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Unable to test emulator because local development builds are broken

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

tgolen · 2023-12-11T23:03:38Z

src/pages/iou/request/step/IOURequestStepConfirmation.js

@@ -192,14 +192,14 @@ function IOURequestStepConfirmation({

            // If we have a receipt let's start the split bill by creating only the action, the transaction, and the group DM if needed
            if (iouType === CONST.IOU.TYPE.SPLIT && receiptFile) {
-                const existingSplitChatReportID = CONST.REGEX.NUMBER.test(reportID) ? reportID : '';
+                const existingSplitChatReportID = CONST.REGEX.NUMBER.test(report.reportID) ? reportID : '';


This seems to be an existing bug. reportID is a reference to the reportID coming from the URL route, and that will always be a number. This changes the code so that it's testing if the report.reportID belongs to an optimistic report or not, which I think is what is intended.

melvin-bot · 2023-12-11T23:28:04Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2023-12-12T01:28:26Z

@tgolen if this is urgent I can jump in for a review

shubham1206agra · 2023-12-12T06:37:27Z

@tgolen You need to update the type object of the transaction to accommodate this change.
I suggest creating 2 separate types for this, one for transaction and one for transaction draft.

Julesssss · 2023-12-12T10:48:31Z

@tgolen You need to update the type object of the transaction to accommodate this change. I suggest creating 2 separate types for this, one for transaction and one for transaction draft.

Thanks for this, as the PR is blocking deploy and this only triggers a warning we can handle that separately.

shubham1206agra · 2023-12-12T11:02:36Z

Test case 2 failing with #32895
Fix is #32896
cc @Julesssss

shubham1206agra · 2023-12-12T11:08:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Test 1

Screen.Recording.2023-12-12.at.4.25.50.PM.mov

Test 3

Screen.Recording.2023-12-12.at.4.29.15.PM.mov

shubham1206agra · 2023-12-12T11:14:48Z

@Julesssss Please merge this

melvin-bot · 2023-12-12T11:15:04Z

@johnmlee101 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss

Looking good. Thanks for treating this with urgency. Will merge and CP

OSBotify · 2023-12-12T11:37:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2023-12-12T12:13:19Z

CP in progress

Track when a split is created from global create to call proper API (cherry picked from commit 4bcdcf5)

OSBotify · 2023-12-12T12:41:31Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 1.4.11-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-13T11:10:25Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Track when a split is created from global create to call proper API

16a4a13

tgolen mentioned this pull request Dec 11, 2023

[HOLD for payment 2023-12-20] [$500] Split - User is redirected to LHN instead of group chat #32853

Closed

6 tasks

tgolen commented Dec 11, 2023

View reviewed changes

luacmartins approved these changes Dec 11, 2023

View reviewed changes

tgolen self-assigned this Dec 11, 2023

tgolen marked this pull request as ready for review December 11, 2023 23:27

tgolen requested a review from a team as a code owner December 11, 2023 23:27

melvin-bot bot requested review from jjcoffee and removed request for a team December 11, 2023 23:28

shubham1206agra mentioned this pull request Dec 12, 2023

[HOLD for payment 2023-12-20] [$500] Split - User can select or unselect members on comfirmation page when splitting bill from FAB #32867

Closed

6 tasks

This comment was marked as off-topic.

Sign in to view

shubham1206agra approved these changes Dec 12, 2023

View reviewed changes

melvin-bot bot requested a review from johnmlee101 December 12, 2023 11:15

Julesssss requested review from Julesssss and removed request for johnmlee101 December 12, 2023 11:32

Julesssss approved these changes Dec 12, 2023

View reviewed changes

Julesssss merged commit 4bcdcf5 into main Dec 12, 2023
16 of 24 checks passed

Julesssss deleted the tgolen-fix-split-participants branch December 12, 2023 11:33

mountiny changed the title ~~Track when a split is created from global create to call proper API~~ [CP Staging] Track when a split is created from global create to call proper API Dec 12, 2023

OSBotify pushed a commit that referenced this pull request Dec 12, 2023

Merge pull request #32878 from Expensify/tgolen-fix-split-participants

18faa7f

Track when a split is created from global create to call proper API (cherry picked from commit 4bcdcf5)

github-actions bot mentioned this pull request Dec 12, 2023

Deploy Checklist: New Expensify 2023-12-11 #32794

Closed

81 tasks

c3024 mentioned this pull request Dec 21, 2023

Refactor the money request creation flow #28618

Merged

58 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Track when a split is created from global create to call proper API #32878

[CP Staging] Track when a split is created from global create to call proper API #32878

tgolen commented Dec 11, 2023 •

edited

Loading

tgolen Dec 11, 2023 •

edited

Loading

melvin-bot bot commented Dec 11, 2023

shubham1206agra commented Dec 12, 2023

shubham1206agra commented Dec 12, 2023

Julesssss commented Dec 12, 2023

This comment was marked as off-topic.

This comment was marked as off-topic.

shubham1206agra commented Dec 12, 2023 •

edited

Loading

shubham1206agra commented Dec 12, 2023

shubham1206agra commented Dec 12, 2023

melvin-bot bot commented Dec 12, 2023

Julesssss left a comment

OSBotify commented Dec 12, 2023

Julesssss commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 13, 2023

[CP Staging] Track when a split is created from global create to call proper API #32878

[CP Staging] Track when a split is created from global create to call proper API #32878

Conversation

tgolen commented Dec 11, 2023 • edited Loading

Details

Fixed Issues

Tests

First Test

Second Test

Third Test

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

tgolen Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

melvin-bot bot commented Dec 11, 2023

shubham1206agra commented Dec 12, 2023

shubham1206agra commented Dec 12, 2023

Julesssss commented Dec 12, 2023

This comment was marked as off-topic.

This comment was marked as off-topic.

shubham1206agra commented Dec 12, 2023 • edited Loading

shubham1206agra commented Dec 12, 2023

Reviewer Checklist

Screenshots/Videos

shubham1206agra commented Dec 12, 2023

melvin-bot bot commented Dec 12, 2023

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 12, 2023

Julesssss commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 13, 2023

tgolen commented Dec 11, 2023 •

edited

Loading

tgolen Dec 11, 2023 •

edited

Loading

shubham1206agra commented Dec 12, 2023 •

edited

Loading