Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MentionUserRenderer.js for issue 26016 #32933

Closed
wants to merge 2 commits into from
Closed

Update MentionUserRenderer.js for issue 26016 #32933

wants to merge 2 commits into from

Conversation

nikhildewoolkar
Copy link
Contributor

Fixed Issues
#26016
#26016

Tests
Open the app
Open any report
Write '@' to trigger mentions
Select any one mention, make any letter of mention as capital and send
Hover on mention to observe that tooltip doesn't display the right display name and avatar
For same mention as step 4 or select different mention and capitalize all letters and send
Observe that now it is not displayed as mention

IMG-20231212-WA0003

@nikhildewoolkar nikhildewoolkar requested a review from a team as a code owner December 12, 2023 16:36
Copy link
Contributor

github-actions bot commented Dec 12, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team December 12, 2023 16:37
Copy link

melvin-bot bot commented Dec 12, 2023

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@nikhildewoolkar
Copy link
Contributor Author

kindly review the PR

@nikhildewoolkar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@cristipaval cristipaval requested review from sobitneupane and removed request for cristipaval December 13, 2023 10:49
@sobitneupane
Copy link
Contributor

@nikhildewoolkar You need to fill up the PR Author Checklist. You were supposed to fill up the template that was generated while creating PR. We won't be able to merge PR without this test passing.

Screenshot 2023-12-14 at 08 07 48

@sobitneupane
Copy link
Contributor

@nikhildewoolkar Bump on this. Let's wrap this PR asap.

@nikhildewoolkar
Copy link
Contributor Author

#33539
@sobitneupane @rushatgabhane
Kindly review PR.
Screenshots added below in comments section of PR. Screenshots not applicable for mobile application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants