Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename style container for the TextInput #33221

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Rename style container for the TextInput #33221

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d830b40
rename
perunt Dec 18, 2023
c746ce6
parse style as array
perunt Dec 30, 2023
930ca15
type
perunt Dec 30, 2023
df41873
Merge branch 'main' of https://github.com/Expensify/App into perunt/i…
perunt Dec 30, 2023
41b6340
remove file after merge
perunt Dec 30, 2023
2015c6a
Merge branch 'main' of https://github.com/Expensify/App into perunt/i…
perunt Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/AmountTextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function AmountTextInput(props) {
onSelectionChange={props.onSelectionChange}
role={CONST.ROLE.PRESENTATION}
onKeyPress={props.onKeyPress}
containerStyles={[...StyleUtils.parseStyleAsArray(props.containerStyles)]}
testInputWrapper={[...StyleUtils.parseStyleAsArray(props.containerStyles)]}
/>
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/TextInput/BaseTextInput/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ function BaseTextInput(props) {
style={[
props.autoGrowHeight && styles.autoGrowHeightInputContainer(textInputHeight, variables.componentSizeLarge, maxHeight),
!isMultiline && styles.componentHeightLarge,
...props.containerStyles,
props.testInputWrapper,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we not need to spread this prop and why is this prop not in the propTypes? This PR is a bit confusing, could you add a bit more context? @perunt @allroundexperts Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've updated it to match our style guide. Thanks!

]}
>
<View
Expand Down
Loading