Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/30884: Redirect to upload screen if file is lost #33562

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Fix/30884: Redirect to upload screen if file is lost #33562

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7bbc387
redirect to upload screen if file is lost
DylanDylann Dec 25, 2023
d9243e7
fix lint
DylanDylann Dec 25, 2023
b656946
merge main
DylanDylann Jan 4, 2024
5a9fc7d
reset source and file name after reload
DylanDylann Jan 4, 2024
aa45fe6
fix lint
DylanDylann Jan 4, 2024
68035f5
fix lint
DylanDylann Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/libs/IOUUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type {ValueOf} from 'type-fest';
import CONST from '@src/CONST';
import ROUTES from '@src/ROUTES';
import type {Report, Transaction} from '@src/types/onyx';
import * as IOU from './actions/IOU';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import * as IOU from './actions/IOU';
import * as IOU from '@userActions/IOU';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-09 at 20 35 13

At the beginning I used '@userActions/IOU'; as your suggestion but It caused a lint error

import * as CurrencyUtils from './CurrencyUtils';
import * as FileUtils from './fileDownload/FileUtils';
import Navigation from './Navigation/Navigation';
Expand Down Expand Up @@ -38,7 +39,14 @@ function navigateToStartStepIfScanFileCannotBeRead(
return;
}

const onFailure = () => navigateToStartMoneyRequestStep(requestType, iouType, transactionID, reportID);
const onFailure = () => {
IOU.setMoneyRequestReceipt_temporaryForRefactor(transactionID, '', '');
if (requestType === CONST.IOU.REQUEST_TYPE.MANUAL) {
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(iouType, transactionID, reportID, Navigation.getActiveRouteWithoutParams()));
return;
}
navigateToStartMoneyRequestStep(requestType, iouType, transactionID, reportID);
};
FileUtils.readFileAsync(receiptPath, receiptFilename, onSuccess, onFailure);
}

Expand Down
Loading