Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript #33570

Merged
merged 29 commits into from
Jan 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
674e24d
rename file
KrAbhas Dec 25, 2023
883eaae
add types, remove compose, refactor HOC
KrAbhas Dec 25, 2023
b5f1a17
refactor types for intersection
KrAbhas Dec 25, 2023
89ed621
improve optional and nullish chaining
KrAbhas Dec 25, 2023
73d0421
merge main to branch
KrAbhas Dec 28, 2023
35ff0a9
resolve conflict from main
KrAbhas Dec 28, 2023
90f7963
add ts-expect-error with issue nos
KrAbhas Dec 28, 2023
fcf8873
remove underscore
KrAbhas Dec 28, 2023
b873919
write prettier changes
KrAbhas Dec 28, 2023
7938b48
remove nullish coalescing to replace ||
KrAbhas Dec 28, 2023
d267f1b
improve ts-expect-error comments
KrAbhas Dec 28, 2023
007def1
define and use PaymentType
KrAbhas Dec 28, 2023
3fac3e9
keep Session and import all types as OnyxTypes
KrAbhas Dec 28, 2023
904b910
Merge branch 'main' into ts_mig_MoneyReportHeader
KrAbhas Dec 29, 2023
a836394
Merge branch 'main' into ts_mig_MoneyReportHeader
KrAbhas Jan 3, 2024
d0604ff
resolve ts lint error from latest master pull
KrAbhas Jan 3, 2024
eadb576
match types between MenuItem and ThreedotMenuItem
KrAbhas Jan 5, 2024
f19a692
match array type for threedotmenuitem
KrAbhas Jan 5, 2024
c135fdc
merge main to branch and resolve HeaderUtils conflict
KrAbhas Jan 5, 2024
95f02ab
resolve lint error for type import
KrAbhas Jan 5, 2024
9d10263
resolve lint error for top-level type import
KrAbhas Jan 5, 2024
cb57d63
resolve lint error: OnyxEntry as type
KrAbhas Jan 5, 2024
2024316
merge main to branch and resolve conflict
KrAbhas Jan 6, 2024
b2e045e
remove MenuItem in favor of ThreeDotsMenuItem
KrAbhas Jan 9, 2024
11dbb77
Merge branch 'main' into ts_mig_MoneyReportHeader
KrAbhas Jan 9, 2024
11b97e8
run prettier
KrAbhas Jan 10, 2024
97e9c35
Merge branch 'main' into ts_mig_MoneyReportHeader
KrAbhas Jan 10, 2024
5bae0f9
merge main to branch and resolve conflicts
KrAbhas Jan 16, 2024
e5a8893
Merge branch 'main' into ts_mig_MoneyReportHeader
KrAbhas Jan 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add types, remove compose, refactor HOC
  • Loading branch information
KrAbhas committed Dec 25, 2023
commit 883eaaea390c217f2a14dd686ad6bc3f65d2429e
2 changes: 1 addition & 1 deletion src/components/MoneyReportHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -224,4 +224,4 @@ export default withOnyx<MoneyReportHeaderProps, MoneyReportHeaderOnyxProps>({
session: {
key: ONYXKEYS.SESSION,
},
})(MoneyReportHeader);
})(MoneyReportHeader);