Added limit exceed error message with new limit #33601

dhairyasenjaliya · 2023-12-26T15:33:13Z

Details

Fixed Issues

$ #18647
PROPOSAL: #18647 (comment)

Tests

Test case send money description

Login in to app
Press FAB -> Select send money -> add money
Select any contact
Choose Description
Enter more then 500 characters
Notice input should not allow to exceed 500 characters limit

Test case edit description

Login in to app
Select any conversation that has money sent
Go to description try to edit
Notice input should not allow to exceed 500 characters limit

Test case Request money description

Login in to app
Press FAB -> Select request money -> select manual
Select any contact
Choose Description
Enter more then 500 characters
Notice input should not allow to exceed 500 characters limit

Test case workspace name

Login in to app
Press FAB -> new room
Enter more then 100 characters on workspace name field
Notice input should not allow to exceed 100 characters limit

Test case for workspace name

Login in to app
Press on avatar icon -> select workspace
Select any. Workspace or create new -> press on workspace name to open setting page
Enter more then 100 characters on workspace name field
Notice input should not allow to exceed 100 characters limit

Test case for task name

Login in to app
Press on FAB -> assign task
Enter more then 100 characters on task name field
Notice input should not allow to exceed 100 characters limit

Test case for task description

Login in to app
Press on FAB -> assign task
Enter more then 100 characters on task name field
Notice input should not allow to exceed 100 characters limit

~~Test case for welcome message for room~~

~~1. Login in to app~~
~~2. Navigate to any room~~
~~3. Open room setting -> select Welcome message~~
~~4. Notice input should not allow to exceed 500 characters limit~~

Test case for legal name

Login in to app
Navigate to settings -> go to profile -> go to personal details page -> go to legal name page
check first and last name can only add upto 100 characters

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-26T15:33:18Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2023-12-28T16:51:46Z

@dhairyasenjaliya Can you please update the Test Steps/QA Steps to cover all features where we applied the fix?

dhairyasenjaliya · 2023-12-28T18:51:01Z

@mananjadhav updated steps & screenshots

mananjadhav · 2024-01-04T13:27:01Z

src/CONST.ts

-    WORKSPACE_NAME_CHARACTER_LIMIT: 80,
+
+    TITLE_CHARACTER_LIMIT: 100,
+    SUPPORTING_CHARACTER_LIMIT: 500,


I am wondering if this should be SUPPORTING_TEXT_LIMIT or DESCRIPTION_LIMIT.

@youssef-lr wdyt?

I think DESCRIPTION_LIMIT is more consistent with what we have in the backend.

dhairyasenjaliya · 2024-01-04T19:41:49Z

@mananjadhav @youssef-lr do we need to handle the legal name as well?

mananjadhav · 2024-01-04T20:09:31Z

@mananjadhav @youssef-lr do we need to handle the legal name as well?

Yes. We closed one the linked issue stating we'll take care of it here.

dhairyasenjaliya · 2024-01-04T20:10:30Z

Okay and any other remaining @mananjadhav

mananjadhav · 2024-01-04T20:12:42Z

Okay and any other remaining @mananjadhav

I am checking through the issues.

mananjadhav · 2024-01-09T16:10:05Z

@dhairyasenjaliya did we cover legal name? I can't find new commits.

@youssef-lr @dhairyasenjaliya any comments on this one?

dhairyasenjaliya · 2024-01-09T16:26:00Z

@mananjadhav legal names added and QA steps also updated

mananjadhav · 2024-01-14T19:39:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-length-validation.mov

Android: mWeb Chrome

mweb-chrome-length-validation.mov

iOS: Native

ios-length-validation.mov

iOS: mWeb Safari

mweb-safari-length-validation.mov

MacOS: Chrome / Safari

web-length-legal-name.mov

web-length-legal-name-with-latin-error.mov

MacOS: Desktop

desktop-length-validation_7cMHizon.mp4

mananjadhav · 2024-01-16T17:34:35Z

@dhairyasenjaliya @youssef-lr I can see one potential issue:

When more than one fields have the validation error, we only show the error to the first field. Is that the expected behavior? Because we don't have the validation in the current form we can't make out.

I have other forms where both the fields show the error.

dhairyasenjaliya · 2024-01-16T17:46:21Z

@mananjadhav Yeah we should stick with the current approach to show both error validations I have added that on the new commit

mananjadhav · 2024-01-16T17:47:25Z

Is that the only place? Do we need to worry about any other places?

dhairyasenjaliya · 2024-01-16T17:48:48Z

I checked its only for one place which I just updated @mananjadhav

mananjadhav · 2024-01-16T19:04:07Z

@dhairyasenjaliya One more issue, the latin error message doesn't get cleared in the legal name.

legal-name-length-latin.mov

dhairyasenjaliya · 2024-01-16T19:16:14Z

@mananjadhav fixed on latest commit

mananjadhav · 2024-01-16T19:46:26Z

Thanks @dhairyasenjaliya the above listed bugs are resolved in the latest push.

mananjadhav · 2024-01-19T04:28:23Z

@dhairyasenjaliya We've got Typescript check failing. Can you merge the latest main to see if it fixes it?

src/pages/ReportWelcomeMessagePage.tsx

…into inputLength

dhairyasenjaliya · 2024-02-02T15:35:48Z

hey @youssef-lr all conflicts fixed please check

…into inputLength

youssef-lr · 2024-02-06T17:12:38Z

I remember we had changes in ReportWelcomeMessagePage but can't see them anymore? we also changed this to be max 500, right now it's 10000

dhairyasenjaliya · 2024-02-06T17:14:29Z

@youssef-lr on latest main it was removed for welcome message

…into inputLength

youssef-lr · 2024-02-07T22:05:15Z

@dhairyasenjaliya there are conflicts, once fixed I can approve & merge.

…into inputLength

dhairyasenjaliya · 2024-02-08T18:59:58Z

@youssef-lr all done please merge once you get a chance

OSBotify · 2024-02-10T00:17:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-12T14:19:46Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

lanitochka17 · 2024-02-12T15:22:16Z

This PR is failing because of issue #36342

The issue is reproducible in: All environments

Bug6376647_1707748776886.bandicam_2024-02-12_22-22-11-178.mp4

youssef-lr · 2024-02-12T15:30:20Z

@dhairyasenjaliya can you look into this asap please?

mananjadhav · 2024-02-12T15:36:58Z

@youssef-lr I don't think it is related to the PR, it crashes on the production as well. I think because of the undefined in the URL.

OSBotify · 2024-02-13T18:25:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

Added limit exceed error message with new limit

ebf46e0

dhairyasenjaliya requested a review from a team as a code owner December 26, 2023 15:33

melvin-bot bot requested review from mananjadhav and removed request for a team December 26, 2023 15:33

type fixes

d791082

added for remaning room

8416455

mananjadhav reviewed Jan 4, 2024

View reviewed changes

limit on legal name

cb61222

Fix to display both error validation

36492af

Fix legal name errors

69a50b1

mananjadhav approved these changes Jan 16, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr January 16, 2024 19:46

youssef-lr reviewed Feb 1, 2024

View reviewed changes

src/pages/ReportWelcomeMessagePage.tsx Outdated Show resolved Hide resolved

dhairyasenjaliya added 8 commits February 2, 2024 00:49

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

f34d83b

…into inputLength

Resolve conflict

8941290

Resolve conflict - 1

784d5bc

Resolve conflict - 2

130fa1b

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

614659c

…into inputLength

Resolve conflict - 3

02883ac

added proper error messages

00eedcc

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

3fa1172

…into inputLength

dhairyasenjaliya added 2 commits February 6, 2024 14:18

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

2dc88fa

…into inputLength

Remove key for welcome message

36d9542

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

7e4d7db

…into inputLength

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

4b2b5ab

…into inputLength

youssef-lr approved these changes Feb 10, 2024

View reviewed changes

youssef-lr merged commit d786be0 into Expensify:main Feb 10, 2024
15 checks passed

github-actions bot mentioned this pull request Feb 12, 2024

Deploy Checklist: New Expensify 2024-02-12 #36335

Closed

90 tasks

lanitochka17 mentioned this pull request Feb 12, 2024

[HOLD App 35455][$500] Send money - Not here page opens when opening Description in Send money flow #36342

Closed

6 tasks

mananjadhav mentioned this pull request Feb 12, 2024

[HOLD for payment 2024-02-20] [$1000] [Polish] Add limit on length of task names, room names, etc. #18647

Closed

6 tasks

lanitochka17 mentioned this pull request Feb 12, 2024

[$500] Workspace - Workspace name character limit is 80 instead of 100 #36352

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added limit exceed error message with new limit #33601

Added limit exceed error message with new limit #33601

dhairyasenjaliya commented Dec 26, 2023 •

edited

Loading

melvin-bot bot commented Dec 26, 2023

mananjadhav commented Dec 28, 2023

dhairyasenjaliya commented Dec 28, 2023

mananjadhav Jan 4, 2024 •

edited

Loading

youssef-lr Feb 1, 2024

dhairyasenjaliya Feb 1, 2024

dhairyasenjaliya commented Jan 4, 2024

mananjadhav commented Jan 4, 2024

dhairyasenjaliya commented Jan 4, 2024

mananjadhav commented Jan 4, 2024

mananjadhav commented Jan 9, 2024

dhairyasenjaliya commented Jan 9, 2024 •

edited

Loading

mananjadhav commented Jan 14, 2024 •

edited

Loading

mananjadhav commented Jan 16, 2024

dhairyasenjaliya commented Jan 16, 2024

mananjadhav commented Jan 16, 2024

dhairyasenjaliya commented Jan 16, 2024

mananjadhav commented Jan 16, 2024

dhairyasenjaliya commented Jan 16, 2024

mananjadhav commented Jan 16, 2024

mananjadhav commented Jan 19, 2024

dhairyasenjaliya commented Feb 2, 2024

youssef-lr commented Feb 6, 2024 •

edited

Loading

dhairyasenjaliya commented Feb 6, 2024

youssef-lr commented Feb 7, 2024

dhairyasenjaliya commented Feb 8, 2024

OSBotify commented Feb 10, 2024

OSBotify commented Feb 12, 2024

lanitochka17 commented Feb 12, 2024

youssef-lr commented Feb 12, 2024

mananjadhav commented Feb 12, 2024

OSBotify commented Feb 13, 2024

Added limit exceed error message with new limit #33601

Added limit exceed error message with new limit #33601

Conversation

dhairyasenjaliya commented Dec 26, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 26, 2023

mananjadhav commented Dec 28, 2023

dhairyasenjaliya commented Dec 28, 2023

mananjadhav Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

youssef-lr Feb 1, 2024

Choose a reason for hiding this comment

dhairyasenjaliya Feb 1, 2024

Choose a reason for hiding this comment

dhairyasenjaliya commented Jan 4, 2024

mananjadhav commented Jan 4, 2024

dhairyasenjaliya commented Jan 4, 2024

mananjadhav commented Jan 4, 2024

mananjadhav commented Jan 9, 2024

dhairyasenjaliya commented Jan 9, 2024 • edited Loading

mananjadhav commented Jan 14, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Jan 16, 2024

dhairyasenjaliya commented Jan 16, 2024

mananjadhav commented Jan 16, 2024

dhairyasenjaliya commented Jan 16, 2024

mananjadhav commented Jan 16, 2024

dhairyasenjaliya commented Jan 16, 2024

mananjadhav commented Jan 16, 2024

mananjadhav commented Jan 19, 2024

dhairyasenjaliya commented Feb 2, 2024

youssef-lr commented Feb 6, 2024 • edited Loading

dhairyasenjaliya commented Feb 6, 2024

youssef-lr commented Feb 7, 2024

dhairyasenjaliya commented Feb 8, 2024

OSBotify commented Feb 10, 2024

OSBotify commented Feb 12, 2024

lanitochka17 commented Feb 12, 2024

youssef-lr commented Feb 12, 2024

mananjadhav commented Feb 12, 2024

OSBotify commented Feb 13, 2024

dhairyasenjaliya commented Dec 26, 2023 •

edited

Loading

mananjadhav Jan 4, 2024 •

edited

Loading

dhairyasenjaliya commented Jan 9, 2024 •

edited

Loading

mananjadhav commented Jan 14, 2024 •

edited

Loading

youssef-lr commented Feb 6, 2024 •

edited

Loading