Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overflow menu to mini context menu #34031

Merged
merged 17 commits into from
Jan 18, 2024
Merged

Add overflow menu to mini context menu #34031

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e579509
Add overflow menu to mini context menu
esh-g Jan 5, 2024
ccd4983
fix lint
esh-g Jan 5, 2024
a24941a
fix lint
esh-g Jan 5, 2024
bf88b1a
Prettify 💫
esh-g Jan 8, 2024
2e8961f
Merge branch 'main' into overflow-menu
esh-g Jan 8, 2024
73eae87
Add icons
esh-g Jan 8, 2024
8ed9318
Prettify
esh-g Jan 8, 2024
150702f
Fix bug
esh-g Jan 10, 2024
71b593d
Merge branch 'main' into overflow-menu
esh-g Jan 10, 2024
302e3be
Correct items number
esh-g Jan 10, 2024
5d83979
Fix types and CONST
esh-g Jan 10, 2024
270d46b
Fix lint
esh-g Jan 10, 2024
6c7b897
Make sure report action is highlighted when active
esh-g Jan 11, 2024
243e001
Merge branch 'main' into overflow-menu
esh-g Jan 17, 2024
032aa6a
Make changes after TS migration
esh-g Jan 17, 2024
5c62754
Fix lint
esh-g Jan 17, 2024
a697f71
Fix lint
esh-g Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function BaseReportActionContextMenu(props) {
const shouldEnableArrowNavigation = !props.isMini && (props.isVisible || shouldKeepOpen);
let filteredContextMenuActions = _.filter(ContextMenuActions, shouldShowFilter);
filteredContextMenuActions =
props.isMini && filteredContextMenuActions.length > 3 ? [...filteredContextMenuActions.slice(0, 3), filteredContextMenuActions.at(-1)] : filteredContextMenuActions;
props.isMini && filteredContextMenuActions.length > 4 ? [...filteredContextMenuActions.slice(0, 3), filteredContextMenuActions.at(-1)] : filteredContextMenuActions;
esh-g marked this conversation as resolved.
Show resolved Hide resolved
// Context menu actions that are not rendered as menu items are excluded from arrow navigation
const nonMenuItemActionIndexes = _.map(filteredContextMenuActions, (contextAction, index) => (_.isFunction(contextAction.renderContent) ? index : undefined));
const disabledIndexes = _.filter(nonMenuItemActionIndexes, (index) => !_.isUndefined(index));
Expand Down
Loading