fix: show error message for invalid receipt #34087

tienifr · 2024-01-08T06:37:59Z

Details

Fixed Issues

$ #28343
PROPOSAL: #28343 (comment)

Tests

Login to any account
Send a Money Request to another account, using the Scan Receipt option
Click on the Receipt image to open the preview popup
Click on the “Three dots” icon >> select the “Replace” option
Replace the current image with an unsupported file. Ex: CORRUPT.pdf
Verify that the error message is shown and users can download the invalid file
Click clear error icon, verify that the errors are removed, and the previous file is shown

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Login to any account
Send a Money Request to another account, using the Scan Receipt option
Click on the Receipt image to open the preview popup
Click on the “Three dots” icon >> select the “Replace” option
Replace the current image with an unsupported file. Ex: CORRUPT.pdf
Verify that the error message is shown and users can download the invalid file
Click clear error icon, verify that the errors are removed, and the previous file is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-17.at.14.23.39.mov

Android: mWeb Chrome

Screen.Recording.2024-01-17.at.14.13.08.mov

iOS: Native

Screen.Recording.2024-01-08.at.13.22.18.mov

iOS: mWeb Safari

Screen.Recording.2024-01-08.at.12.30.50.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-08.at.12.26.17.mp4

MacOS: Desktop

Screen.Recording.2024-01-08.at.13.25.01.mp4

melvin-bot · 2024-01-08T06:38:34Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-01-08T09:15:56Z

@tienifr, a few quick reviews for PR checklist

It looks like we're missing test steps for "clear error" icon
It looks like we're missing recordings of Android platforms

src/libs/actions/IOU.js

src/types/onyx/OnyxCommon.ts

src/libs/ReceiptUtils.ts

hoangzinh · 2024-01-12T14:30:22Z

src/libs/ReceiptUtils.ts

@@ -30,9 +32,10 @@ type FileNameAndExtension = {
 */
 function getThumbnailAndImageURIs(transaction: Transaction, receiptPath: string | null = null, receiptFileName: string | null = null): ThumbnailAndImageURI {
    // URI to image, i.e. blob:new.expensify.com/9ef3a018-4067-47c6-b29f-5f1bd35f213d or expensify.com/receipts/w_e616108497ef940b7210ec6beb5a462d01a878f4.jpg
-    const path = transaction?.receipt?.source ?? receiptPath ?? '';
+    const errors = _.findLast(transaction.errors) as ReceiptError | null;


Do we need union type here ReceiptError | null, can it be ReceiptError only?

error can be undefined (receipt without error), so I think it should be ReceiptError | undefined

hoangzinh · 2024-01-12T14:31:43Z

@tienifr also we're missing recordings for Android platform

hoangzinh · 2024-01-16T15:37:12Z

cc @tienifr, just in case you missed this PR

tienifr · 2024-01-17T03:43:31Z

@hoangzinh I updated the PR, will add the screenshots in a few minutes

hoangzinh · 2024-01-18T15:24:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

2488984317132467882.mp4

Android: mWeb Chrome

Screen.Recording.2024-01-26.at.23.18.15.android.chrome.mov

iOS: Native

Screen.Recording.2024-01-27.at.15.31.28.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-01-27.at.15.33.20.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-26.at.23.07.57.web.mov

MacOS: Desktop

Screen.Recording.2024-01-26.at.23.09.59.desktop.mov

hoangzinh · 2024-01-18T15:44:19Z

@tienifr When I click "download" link on Web, the file is downloaded but the file name is weird. Have you faced same issue as me?

tienifr · 2024-01-19T09:43:06Z

@hoangzinh Ah, sorry. The filename should be file.name (I missed it when fixing the conflict). I updated

hoangzinh · 2024-01-22T10:08:37Z

@tienifr I found another bug, when receipt is failed to upload, there is no IOU error in LHN or in the parent report.

Screen.Recording.2024-01-22.at.17.05.42.mov

tienifr · 2024-01-24T10:57:01Z

I'm checking

tienifr · 2024-01-25T09:03:25Z

@hoangzinh I see this behavior is present on main. LHN does not show the red dot.

Screen.Recording.2024-01-25.at.16.01.52.mov

hoangzinh · 2024-01-26T16:23:32Z

@tienifr have you faced same error with me in Android platform? I couldn't download error image

hoangzinh · 2024-01-27T14:23:58Z

@jasperhuangg could you help to trigger adhoc builds for Android so I can test this PR on a real device? My Mac has a problem so I can't make a connection to my Android device to install our Expensify Dev app via react-native

jasperhuangg · 2024-01-29T23:40:53Z

https://github.com/Expensify/App/actions/runs/7703963164

github-actions · 2024-01-30T00:06:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/34087/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/34087/NewExpensify.dmg	https://34087.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hoangzinh · 2024-01-30T04:51:00Z

Thanks @jasperhuangg

hoangzinh

LGTM

OSBotify · 2024-01-30T18:45:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-31T02:57:05Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-01-31T04:11:02Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T04:37:19Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins · 2024-01-31T22:26:37Z

@tienifr I think this PR caused this regression, could you please look into it?

OSBotify · 2024-01-31T22:48:13Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rojiphil · 2024-07-25T06:21:07Z

src/components/ReportActionItem/MoneyRequestView.js

+                        errors={transaction.errors}
+                        errorRowStyles={[styles.ml4]}
+                        onClose={() => {
+                            Transaction.clearError(transaction.transactionID);


We missed handling the case of createChat errorfields which would happen when the creation of the chat itself fails thereby causing #43481.

fix: show error message for invalid receipt

5c8b972

tienifr marked this pull request as ready for review January 8, 2024 06:38

tienifr requested a review from a team as a code owner January 8, 2024 06:38

melvin-bot bot removed the request for review from a team January 8, 2024 06:38

melvin-bot bot requested a review from hoangzinh January 8, 2024 06:38

hoangzinh reviewed Jan 10, 2024

View reviewed changes

src/libs/actions/IOU.js Outdated Show resolved Hide resolved

src/libs/actions/IOU.js Outdated Show resolved Hide resolved

src/types/onyx/OnyxCommon.ts Outdated Show resolved Hide resolved

src/libs/ReceiptUtils.ts Show resolved Hide resolved

clean code

290c569

hoangzinh reviewed Jan 12, 2024

View reviewed changes

add comment

d78b26e

add undefined

2a20b9b

tienifr added 2 commits January 19, 2024 16:33

Merge branch 'main' into fix/28343-show-error-for-invalid-receipt

670bd8b

add filename

f48ddc1

jasperhuangg added the Ready To Build label Jan 29, 2024

hoangzinh approved these changes Jan 30, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg January 30, 2024 04:51

jasperhuangg approved these changes Jan 30, 2024

View reviewed changes

jasperhuangg merged commit fc523dc into Expensify:main Jan 30, 2024
16 checks passed

github-actions bot mentioned this pull request Jan 31, 2024

Deploy Checklist: New Expensify 2024-01-31 #35448

Closed

54 tasks

kbecciv mentioned this pull request Jan 31, 2024

IOU - In scan request, tapping download file shows error pop up #34043

Closed

6 tasks

lanitochka17 mentioned this pull request Jan 31, 2024

[HOLD for payment 2024-02-14] Scan- Invalid file is downloaded when uploading invalid file and downloading from receipt view #35482

Closed

6 tasks

luacmartins mentioned this pull request Jan 31, 2024

Revert "fix: show error message for invalid receipt" #35496

Closed

melvin-bot bot mentioned this pull request Jan 31, 2024

[HOLD for payment 2024-02-07] [$500] IOU - Replacing Receipt with an Invalid File Format Does Not Display an Error Message #28343

Closed

6 tasks

rojiphil reviewed Jul 25, 2024

View reviewed changes

rojiphil mentioned this pull request Jul 25, 2024

[HOLD for payment 2024-07-24] [$500] Expense - Main chat and transaction thread with RBR are not dismissed after dismissing error #43481

Closed

6 tasks

sobitneupane mentioned this pull request Jul 29, 2024

[HOLD for payment 2024-07-26] [$250] BUG: Failed distance request isn't cleaned up properly #42950

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: show error message for invalid receipt #34087

fix: show error message for invalid receipt #34087

tienifr commented Jan 8, 2024 •

edited

Loading

melvin-bot bot commented Jan 8, 2024

hoangzinh commented Jan 8, 2024

hoangzinh Jan 12, 2024

tienifr Jan 17, 2024

hoangzinh commented Jan 12, 2024

hoangzinh commented Jan 16, 2024

tienifr commented Jan 17, 2024

hoangzinh commented Jan 18, 2024 •

edited

Loading

hoangzinh commented Jan 18, 2024 •

edited

Loading

tienifr commented Jan 19, 2024

hoangzinh commented Jan 22, 2024

tienifr commented Jan 24, 2024

tienifr commented Jan 25, 2024

hoangzinh commented Jan 26, 2024

hoangzinh commented Jan 27, 2024

jasperhuangg commented Jan 29, 2024

github-actions bot commented Jan 30, 2024

hoangzinh commented Jan 30, 2024

hoangzinh left a comment

OSBotify commented Jan 30, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

luacmartins commented Jan 31, 2024

OSBotify commented Jan 31, 2024

rojiphil Jul 25, 2024

fix: show error message for invalid receipt #34087

fix: show error message for invalid receipt #34087

Conversation

tienifr commented Jan 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 8, 2024

hoangzinh commented Jan 8, 2024

hoangzinh Jan 12, 2024

Choose a reason for hiding this comment

tienifr Jan 17, 2024

Choose a reason for hiding this comment

hoangzinh commented Jan 12, 2024

hoangzinh commented Jan 16, 2024

tienifr commented Jan 17, 2024

hoangzinh commented Jan 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh commented Jan 18, 2024 • edited Loading

tienifr commented Jan 19, 2024

hoangzinh commented Jan 22, 2024

tienifr commented Jan 24, 2024

tienifr commented Jan 25, 2024

hoangzinh commented Jan 26, 2024

hoangzinh commented Jan 27, 2024

jasperhuangg commented Jan 29, 2024

github-actions bot commented Jan 30, 2024

hoangzinh commented Jan 30, 2024

hoangzinh left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 30, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

luacmartins commented Jan 31, 2024

OSBotify commented Jan 31, 2024

rojiphil Jul 25, 2024

Choose a reason for hiding this comment

tienifr commented Jan 8, 2024 •

edited

Loading

hoangzinh commented Jan 18, 2024 •

edited

Loading

hoangzinh commented Jan 18, 2024 •

edited

Loading