Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the next steps to client side #34450
Migrate the next steps to client side #34450
Changes from all commits
0230d23
c2f14f8
c2c25b2
04d2c44
24552b0
a32e22e
bbe860d
9387b10
090d8ff
f77cea1
58baa0a
13d2d7f
81616da
003d387
85731fb
9942130
fa2c8fb
dfec8f6
59a036d
ba8e6ff
9ea9a31
8481f66
ae300a4
7467e2c
38bfb70
8703eb1
f2041bf
dba0e00
cf9fcfb
821ee65
9a36327
2e6879c
45a4f7b
ad414b5
5b63982
2b56951
81cca96
d610054
f2e4bc3
77f0019
6aab7ff
9e3ad05
ea00b24
afe058a
bebeea9
bbe1426
4e0bb21
655d9de
e70ec81
12a28c1
b9ac4a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An approver could also be an admin who still needs to reimburse I think, how would this work in this case? It would show them they are done but they still need to pay it, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on a message that we get from the backend, it should be "No further action....". So, looks like it works properly.
Approved.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok lets go with this and see if some issues will be reported!