Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate SettingsWallet page to TypeScript #34716

Merged
merged 42 commits into from
Feb 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
a7fbd97
TS migration SettingsWallet
tienifr Jan 18, 2024
47ea3ac
use StackScreenProps type
tienifr Jan 18, 2024
9506d82
add commen
tienifr Jan 18, 2024
a15c596
fix lint
tienifr Jan 18, 2024
b848510
TS migrate ActivatePhysicalCardPage
tienifr Jan 18, 2024
a532fc8
Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…
tienifr Jan 18, 2024
14951ed
TS migrate AddDebitCardPage
tienifr Jan 18, 2024
44853e7
fix lint
tienifr Jan 18, 2024
40b2601
TS migrate ReportCardLostPage
tienifr Jan 18, 2024
73095a2
Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…
tienifr Jan 18, 2024
ff51244
TS migrate TransferBalancePage
tienifr Jan 18, 2024
137ff59
fix lint
tienifr Jan 18, 2024
48d470a
TS migrate ExpensifyCardPage
tienifr Jan 18, 2024
65446ab
Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…
tienifr Jan 19, 2024
7b7906c
Fix Form TS error
tienifr Jan 19, 2024
3b5d9ee
Merge branch 'main' into ts-migration/32003
tienifr Jan 19, 2024
9cfedfe
Fix lint and type
tienifr Jan 19, 2024
021be80
remove redundant check
tienifr Jan 19, 2024
47d7f81
Merge branch 'main' into ts-migration/32003
tienifr Jan 23, 2024
9365b3d
add comment and fix minor errors
tienifr Jan 23, 2024
67001c6
Merge branch 'main' into ts-migration/32003
tienifr Jan 25, 2024
d3a9997
Merge branch 'main' into ts-migration/32003
tienifr Jan 26, 2024
5ff1569
Merge branch 'main' into ts-migration/32003
tienifr Feb 16, 2024
6368b04
Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…
tienifr Feb 16, 2024
3c59cfe
Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…
tienifr Feb 17, 2024
7acd0af
Resolve conflicts
tienifr Feb 17, 2024
6439290
fix type error
tienifr Feb 17, 2024
23bc723
fix lint
tienifr Feb 17, 2024
48d5b09
remove unnecessary changes
tienifr Feb 17, 2024
6e01c60
fix type error
tienifr Feb 17, 2024
c15a756
fix lint
tienifr Feb 17, 2024
923e1a0
Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…
tienifr Feb 19, 2024
779a231
use or instead of nullish coalescing
tienifr Feb 19, 2024
aced7a7
Merge branch 'main' into ts-migration/32003
tienifr Feb 20, 2024
8ffbbe1
Fix typecheck
tienifr Feb 20, 2024
79b29cc
Merge branch 'main' into ts-migration/32003
tienifr Feb 22, 2024
d6c3570
fix crash in activate physical card page
tienifr Feb 22, 2024
9d27a52
Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…
tienifr Feb 22, 2024
b606e21
Merge branch 'main' into ts-migration/32003
tienifr Feb 23, 2024
1ddf781
Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…
tienifr Feb 23, 2024
befbda6
fix typecheck
tienifr Feb 23, 2024
b8caf36
fix: selected icon not show for selected account
tienifr Feb 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use or instead of nullish coalescing
  • Loading branch information
tienifr committed Feb 19, 2024
commit 779a23163ea0542a1446dc66535cb39afd4cf8de
3 changes: 2 additions & 1 deletion src/pages/settings/Wallet/ExpensifyCardPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ function ExpensifyCardPage({
setIsNotFound(isEmptyObject(virtualCard) && isEmptyObject(physicalCard));
}, [cardList, physicalCard, virtualCard]);

const formattedAvailableSpendAmount = CurrencyUtils.convertToDisplayString(physicalCard?.availableSpend ?? virtualCard?.availableSpend ?? 0);
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- availableSpend can be 0
const formattedAvailableSpendAmount = CurrencyUtils.convertToDisplayString(physicalCard?.availableSpend || virtualCard?.availableSpend || 0);

const handleRevealDetails = () => {
setIsLoading(true);
Expand Down
Loading