Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: draft message is gone #35213

Closed
wants to merge 4 commits into from
Closed

Fix: draft message is gone #35213

wants to merge 4 commits into from

Conversation

DylanDylann
Copy link
Contributor

@DylanDylann DylanDylann commented Jan 25, 2024 •
edited
Loading

Details

  • This PR will fix issue: Desktop - Draft message offline isn't saved after app reload if user remains in same chat
  • We will just render the SilentCommentUpdater if the reportID !== '0'

Fixed Issues

$ #33938
PROPOSAL: #33938 (comment)

Tests

  • Desktop:
  1. Open Desktop App
  2. Go to any chat
  3. Go offline
  4. Enter any message and do not send it
  5. Close Desktop App without changing chat
  6. Go online
  7. Start Desktop app again
  8. A draft message entered offline is saved in the chat composer field
  • Deskktop (brief steps based on the RCA)
  1. Open Desktop App
  2. Go to any chat
  3. Enter any message and do not send it
  4. Close Desktop App without changing chat
  5. Start Desktop app again
  6. A draft message entered is saved in the chat composer field
  • Mac-OS chrome:
  1. Open https://staging.new.expensify.com/
  2. Go to any chat
  3. Enter any message and do not send it
  4. Change the current URL to "https://staging.new.expensify.com/" then press "Enter". The page will be reloaded
  5. A draft message entered is saved in the chat composer field
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Desktop:
  1. Open Desktop App
  2. Go to any chat
  3. Go offline
  4. Enter any message and do not send it
  5. Close Desktop App without changing chat
  6. Go online
  7. Start Desktop app again
  8. A draft message entered offline is saved in the chat composer field
  • Deskktop (brief steps based on the RCA)
  1. Open Desktop App
  2. Go to any chat
  3. Enter any message and do not send it
  4. Close Desktop App without changing chat
  5. Start Desktop app again
  6. A draft message entered is saved in the chat composer field
  • Mac-OS chrome:
  1. Open https://staging.new.expensify.com/
  2. Go to any chat
  3. Enter any message and do not send it
  4. Change the current URL to "https://staging.new.expensify.com/" then press "Enter". The page will be reloaded
  5. A draft message entered is saved in the chat composer field
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
  • Cannot test on this platform
Android: mWeb Chrome
  • Cannot test on this platform
iOS: Native
  • Cannot test on this platform
iOS: mWeb Safari
  • Cannot test in this platform
MacOS: Chrome / Safari
Screencast.from.26-01-2024.06.15.30.webm
MacOS: Desktop
Screencast.from.26-01-2024.06.57.11.webm

@DylanDylann DylanDylann requested a review from a team as a code owner January 25, 2024 23:28
@melvin-bot melvin-bot bot removed the request for review from a team January 25, 2024 23:28
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 25, 2024

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from rushatgabhane January 25, 2024 23:28
@DylanDylann DylanDylann mentioned this pull request Jan 26, 2024
Closed
6 tasks
@DylanDylann
Copy link
Contributor Author

@rushatgabhane please help review this PR once you have a chance

@DylanDylann
Copy link
Contributor Author

DylanDylann commented Feb 3, 2024 •
edited
Loading

@rushatgabhane Ping for review the PR in case you miss it

@rushatgabhane
Copy link
Member

@DylanDylann hi, im reviewing this.

Could you please fix performance tests too, thanks!

@DylanDylann
Copy link
Contributor Author

@rushatgabhane I fixed

@rushatgabhane
Copy link
Member

@DylanDylann ts checks are failing

@DylanDylann
Copy link
Contributor Author

@rushatgabhane All are fixed

@rushatgabhane
Copy link
Member

didn't get time on friday, reviewing today!

@rushatgabhane
Copy link
Member

rushatgabhane commented Feb 12, 2024 •
edited
Loading

@DylanDylann looks like this issue is fixed in main #35805 because of a duplicate issue. We can close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushatgabhane rushatgabhane Awaiting requested review from rushatgabhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanDylann @rushatgabhane