-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: EReceipt thumbnail icon is shown in black color #35217
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-native-2024-01-26_17.01.40.mp4Android: mWeb Chromeandroid-chrome-2024-01-26_17.06.40.mp4iOS: Nativeios-native-2024-01-29_14.53.53.mp4iOS: mWeb Safariios-safari-2024-01-29_14.53.00.mp4MacOS: Chrome / Safaridesktop-chrome-2024-01-26_16.54.50.mp4MacOS: Desktopdesktop-app-2024-01-26_16.57.23.mp4 |
@aswin-s Thanks for the quick PR! Could you tidy up the tests a bit, as there's no need to login with a specific account or to go to the specific URL from the original issue? Also, for simulating the ECard transaction, could you make it a bit clearer, e.g. where should the code snippet be placed? (You can use this PR for inspiration). QA will use this info to perform tests, so it's best if it's super clear and easy for them to follow, so we can keep things moving quickly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.34-0 🚀
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.34-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀
|
Details
This PR fixes an issue with EReceipt thumbnail where the icon at the center of thumbnail was displayed in black color on Android devices.
Fixed Issues
$ #34907
PROPOSAL: #34907 (comment)
Tests
For Developer Testing:
For simulating an ECard transaction Onyx data needs to be patched manually. Follow the steps below.
Example:
Optionally add the above code to
MoneyRequestPreview.js
to avoid re-executing it after every page load and to test the scenario on Android & iOS devicesNow navigate to transaction detail page for given transaction
Verify that the icon at center of EReceipt is rendered properly
Use storybook to verify that all types of EReceipts are rendered properly.
Verify that no errors appear in the JS console
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_out.mp4
Android: mWeb Chrome
android_web_out.mp4
iOS: Native
ios_out.mp4
iOS: mWeb Safari
ios-web_out.mp4
MacOS: Chrome / Safari
web_out.mp4
MacOS: Desktop
desktop_out.mp4