Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Infinite loading when navigate to non-existing chat by deeplink #35228

Closed
wants to merge 5 commits into from
Closed

Fix: Infinite loading when navigate to non-existing chat by deeplink #35228

wants to merge 5 commits into from

Conversation

tienifr
Copy link
Contributor

@tienifr tienifr commented Jan 26, 2024 •
edited
Loading

Details

This PR fixes the issue that infinite loading shows when navigate to non-existing chat by deeplink.

Fixed Issues

$ #33638
PROPOSAL: #33638 (comment)

Tests

  1. Open any report
  2. Hide the app
  3. Open a non-existing report deeplink (e.g. new-expensify://r/1234)
  4. Verify "You don't have access to this chat" page shows
  • Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

  1. Open any report
  2. Hide the app
  3. Open a non-existing report deeplink (e.g. https://staging.new.expensify.com/r/1234)
  4. Verify "You don't have access to this chat" page shows
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2024-01-26.at.15.50.48-compressed.mov
Android: mWeb Chrome
Screen.Recording.2024-01-26.at.15.53.22-compressed.mov
iOS: Native
Screen.Recording.2024-01-26.at.15.40.00-compressed.mov
iOS: mWeb Safari
Screen.Recording.2024-01-26.at.15.42.22-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2024-01-26.at.15.37.15-compressed.mov
MacOS: Desktop
Screen.Recording.2024-01-26.at.15.37.15-compressed.mov

@tienifr tienifr marked this pull request as ready for review January 26, 2024 08:54
@tienifr tienifr requested a review from a team as a code owner January 26, 2024 08:54
@melvin-bot melvin-bot bot requested review from sobitneupane and removed request for a team January 26, 2024 08:54
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 26, 2024

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@tienifr tienifr mentioned this pull request Jan 26, 2024
Closed
6 tasks
sobitneupane
sobitneupane reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@sobitneupane sobitneupane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots/Videos

Android: Native
Screen.Recording.2024-02-01.at.15.12.16.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-02-01.at.15.19.35.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-01.at.14.17.36.mov
Screen.Recording.2024-02-01.at.14.19.41.mov
Screen.Recording.2024-02-01.at.14.21.52.mov
Screen.Recording.2024-02-01.at.14.26.06.mov
Screen.Recording.2024-02-01.at.14.26.57.mov
Screen.Recording.2024-02-01.at.14.29.48.mov
Screen.Recording.2024-02-01.at.14.31.26.mov
Screen.Recording.2024-02-01.at.14.32.52.mov
MacOS: Desktop

@sobitneupane
Copy link
Contributor

@tienifr In Android/native, it shows NotFoundPage twice.

Screen.Recording.2024-02-01.at.15.12.16.mov

@tienifr
Copy link
Contributor Author

tienifr commented Feb 2, 2024

I cannot reproduce on the latest main today.

@sobitneupane
Copy link
Contributor

sobitneupane commented Feb 5, 2024 •
edited
Loading

@tienifr In web, I am stuck in the loading screen. Is it working well in your end? I don't think it is related to this PR.

Screen.Recording.2024-02-05.at.16.19.35.mov

@sobitneupane
Copy link
Contributor

sobitneupane commented Feb 5, 2024 •
edited
Loading

We should also test signing in with deeplink (valid and invalid). The change is likely to introduce regressions. So, I am trying to cover as much test cases as possible.

@sobitneupane
Copy link
Contributor

@tienifr Any update about above two comments? Let's test as much as possible with invalid and different types of valid deeplink.

We should also test signing in with deeplink (valid and invalid). The change is likely to introduce regressions. So, I am trying to cover as much test cases as possible.

@tienifr
Copy link
Contributor Author

tienifr commented Feb 20, 2024 •
edited
Loading

I do not quite understand this:

different types of valid deeplink

Can you give some hints?

@tienifr
Copy link
Contributor Author

tienifr commented Feb 20, 2024

In web, I am stuck in the loading screen

Working fine on my end:

Screen.Recording.2024-02-20.at.20.58.11-compressed.mov

@sobitneupane
Copy link
Contributor

Can you give some hints?

-> /concierge
-> r/:reportID
->/settings/about
->a/:accountID
-> r/:reportID/details

@sobitneupane
Copy link
Contributor

@tienifr Any update?

@tienifr
Copy link
Contributor Author

tienifr commented Feb 24, 2024

/concierge
Screen.Recording.2024-02-25.at.00.02.00.mov
/r/:reportID
Screen.Recording.2024-02-25.at.00.02.00.mov
/settings/about
Screen.Recording.2024-02-25.at.00.03.55.mov
/a/:accountID
Screen.Recording.2024-02-25.at.00.04.15.mov
/r/:reportID/details
Screen.Recording.2024-02-25.at.00.04.37.mov

@tienifr
Copy link
Contributor Author

tienifr commented Feb 24, 2024

@sobitneupane Can you help check the videos above^? I think they worked as expected. Pls correct me if I misunderstand sth. Thanks

@sobitneupane
Copy link
Contributor

sobitneupane commented Feb 27, 2024 •
edited
Loading

@tienifr Looks like the issue is not reproducible any longer. It might have been already resolved.

@tienifr
Copy link
Contributor Author

tienifr commented Feb 27, 2024

I believe it was fixed in #36477. But give me a day or two to verify if the solution there actually works for every case.

@tienifr
Copy link
Contributor Author

tienifr commented Feb 29, 2024

@sobitneupane I verified that the solution in the mentioned PR fixed this issue. I think we can close this then.

@tienifr
Copy link
Contributor Author

tienifr commented Mar 5, 2024

@sobitneupane Please check this out and confirm we can close.

@sobitneupane
Copy link
Contributor

@tienifr Yup. We are good to close.

@tienifr tienifr closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobitneupane sobitneupane sobitneupane left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienifr @sobitneupane