Bump up Expo SDK to 50.0.3 #35249

kowczarz · 2024-01-26T14:14:47Z

Details

We had to bump up Expo SDK, because in latest version it fixes autolinking bug expo/expo#26497 which is a blocker of #30829. The reason I'm updating it in a separate PR is that it will be easier to cherrypick the change to Fabric Migration PR #13767.

Fixed Issues

Needed for #20471

Tests

App starts up correctly on every supported platform
Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-01-26T14:45:57Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

francoisl · 2024-01-26T18:15:15Z

I was running into expo/expo#25905 when running pod install. Deleting all pods and rerunning pod install fixed it, but now I have these changes - that look like they might need to be committed? Did you get these changes too?

diff --git a/ios/Podfile b/ios/Podfile
index aa87c3e295..1ff3f4de76 100644
--- a/ios/Podfile
+++ b/ios/Podfile
@@ -71,6 +71,11 @@ target 'NewExpensify' do
     rescue => e
       Pod::UI.warn e
     end
+    begin
+      expo_patch_react_imports!(installer)
+    rescue => e
+      Pod::UI.warn e
+    end
   end
   permissions_path = '../node_modules/react-native-permissions/ios'
 
diff --git a/ios/Podfile.lock b/ios/Podfile.lock
index 4cdf61554a..d47604a649 100644
--- a/ios/Podfile.lock
+++ b/ios/Podfile.lock
@@ -32,7 +32,7 @@ PODS:
     - React-Core
   - CocoaAsyncSocket (7.6.5)
   - DoubleConversion (1.1.6)
-  - Expo (50.0.0-preview.7):
+  - Expo (50.0.3):
     - ExpoModulesCore
   - ExpoImage (1.10.1):
     - ExpoModulesCore
@@ -40,7 +40,7 @@ PODS:
     - SDWebImageAVIFCoder (~> 0.10.1)
     - SDWebImageSVGCoder (~> 1.7.0)
     - SDWebImageWebPCoder (~> 0.13.0)
-  - ExpoModulesCore (1.11.4):
+  - ExpoModulesCore (1.11.8):
     - glog
     - RCT-Folly (= 2022.05.16.00)
     - React-Core
@@ -1176,6 +1176,8 @@ PODS:
     - React-Core
   - react-native-key-command (1.0.6):
     - React-Core
+  - react-native-launch-arguments (4.0.2):
+    - React
   - react-native-netinfo (11.2.1):
     - React-Core
   - react-native-pager-view (6.2.2):
@@ -1423,7 +1425,7 @@ PODS:
     - React-Core
   - RNReactNativeHapticFeedback (1.14.0):
     - React-Core
-  - RNReanimated (3.6.1):
+  - RNReanimated (3.6.2):
     - glog
     - RCT-Folly (= 2022.05.16.00)
     - React-Core
@@ -1522,6 +1524,7 @@ DEPENDENCIES:
   - "react-native-image-manipulator (from `../node_modules/@oguzhnatly/react-native-image-manipulator`)"
   - react-native-image-picker (from `../node_modules/react-native-image-picker`)
   - react-native-key-command (from `../node_modules/react-native-key-command`)
+  - react-native-launch-arguments (from `../node_modules/react-native-launch-arguments`)
   - "react-native-netinfo (from `../node_modules/@react-native-community/netinfo`)"
   - react-native-pager-view (from `../node_modules/react-native-pager-view`)
   - react-native-pdf (from `../node_modules/react-native-pdf`)
@@ -1715,6 +1718,8 @@ EXTERNAL SOURCES:
     :path: "../node_modules/react-native-image-picker"
   react-native-key-command:
     :path: "../node_modules/react-native-key-command"
+  react-native-launch-arguments:
+    :path: "../node_modules/react-native-launch-arguments"
   react-native-netinfo:
     :path: "../node_modules/@react-native-community/netinfo"
   react-native-pager-view:
@@ -1831,9 +1836,9 @@ SPEC CHECKSUMS:
   BVLinearGradient: 421743791a59d259aec53f4c58793aad031da2ca
   CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
   DoubleConversion: fea03f2699887d960129cc54bba7e52542b6f953
-  Expo: cd2dc043dd1cc3d9e8e4e035fb9a41b421e8f13f
+  Expo: 88b4aa68115bbb57c1a07cc30161c2352ab2fc25
   ExpoImage: 1cdaa65a6a70bb01067e21ad1347ff2d973885f5
-  ExpoModulesCore: 01c0abfa6cd9c41c4bd76d8a1a079e6b591db10f
+  ExpoModulesCore: 96d1751929ad10622773bb729ab28a8423f0dd0c
   FBLazyVector: fbc4957d9aa695250b55d879c1d86f79d7e69ab4
   FBReactNativeSpec: 86de768f89901ef6ed3207cd686362189d64ac88
   Firebase: 629510f1a9ddb235f3a7c5c8ceb23ba887f0f814
@@ -1909,6 +1914,7 @@ SPEC CHECKSUMS:
   react-native-image-manipulator: c48f64221cfcd46e9eec53619c4c0374f3328a56
   react-native-image-picker: c33d4e79f0a14a2b66e5065e14946ae63749660b
   react-native-key-command: 5af6ee30ff4932f78da6a2109017549042932aa5
+  react-native-launch-arguments: 5f41e0abf88a15e3c5309b8875d6fd5ac43df49d
   react-native-netinfo: 8a7fd3f7130ef4ad2fb4276d5c9f8d3f28d2df3d
   react-native-pager-view: 02a5c4962530f7efc10dd51ee9cdabeff5e6c631
   react-native-pdf: b4ca3d37a9a86d9165287741c8b2ef4d8940c00e
@@ -1957,7 +1963,7 @@ SPEC CHECKSUMS:
   rnmapbox-maps: 6f638ec002aa6e906a6f766d69cd45f968d98e64
   RNPermissions: 9b086c8f05b2e2faa587fdc31f4c5ab4509728aa
   RNReactNativeHapticFeedback: 1e3efeca9628ff9876ee7cdd9edec1b336913f8c
-  RNReanimated: 57f436e7aa3d277fbfed05e003230b43428157c0
+  RNReanimated: 5589be82dc26b3f94738eb7c6b1f942787532b25
   RNScreens: b582cb834dc4133307562e930e8fa914b8c04ef2
   RNSVG: 255767813dac22db1ec2062c8b7e7b856d4e5ae6
   SDWebImage: 750adf017a315a280c60fde706ab1e552a3ae4e9
@@ -1969,6 +1975,6 @@ SPEC CHECKSUMS:
   VisionCamera: 7d13aae043ffb38b224a0f725d1e23ca9c190fe7
   Yoga: 13c8ef87792450193e117976337b8527b49e8c03
 
-PODFILE CHECKSUM: 0ccbb4f2406893c6e9f266dc1e7470dcd72885d2
+PODFILE CHECKSUM: 0a251987d71151b196465eecf6a04a9444790763
 
-COCOAPODS: 1.13.0
+COCOAPODS: 1.14.3

kowczarz · 2024-01-29T11:10:00Z

@francoisl fair point I forget to commit Podfile.lock changes, but I'm not sure if we want to commit your changes of Podfile, because it looks like we already have that lines in our code https://github.com/Expensify/App/blob/main/ios/Podfile#L69-L73

github-actions · 2024-01-29T20:24:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/35249/NewExpensify.dmg	https://35249.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

francoisl · 2024-01-29T20:35:56Z

I can't build Android locally (though I think my whole dev environment is kind of broken) so I'm trying to use an ad-hoc build, but it's failing with:

CommandError: It looks like you're trying to use web support but don't have the required
dependencies installed.

Please install @expo/metro-runtime@~3.1.1 by running:

npx expo install @expo/metro-runtime

iOS is also failing, logs can be found here: https://github.com/Expensify/App/actions/runs/7701854602

@c3024 are you able to build on Android and iOS locally?

kowczarz · 2024-01-29T20:44:48Z

Ok, I will check the problem and I will probably need to update the CI workflow. I'll reach @mountiny to run the build to test if my fixes work, because he's in same timezone and we won't waste time waiting to sync.

francoisl · 2024-01-29T20:54:27Z

Sounds good, thanks. I'll see if I can find anything to fix it today as well.

Also, feel free to ask any engineer to start an ad-hoc build for you in Slack if Vit isn't available (although, he seems to be online almost 24 hours a day 😄)

mountiny · 2024-01-29T21:24:41Z

although, he seems to be online almost 24 hours a day 😄

😶‍🌫️😶‍🌫️😶‍🌫️

…o-50.0.3 # Conflicts: # package-lock.json # package.json

c3024 · 2024-01-30T10:22:45Z

Android build worked for me

bumpExpo.mp4

mountiny · 2024-01-30T11:01:23Z

https://github.com/Expensify/App/actions/runs/7710101028

github-actions · 2024-01-30T11:17:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	https://35249.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

mountiny · 2024-01-30T11:18:09Z

https://github.com/Expensify/App/actions/runs/7710294635

c3024 · 2024-01-30T11:21:31Z

iOS build failed

c3024 · 2024-01-30T11:31:16Z

iOS - Installed node_modules afresh and ran pod install and built the app. Failed again.

github-actions · 2024-01-30T11:35:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35249/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/35249/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://35249.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

…o-50.0.3 # Conflicts: # package-lock.json

kowczarz · 2024-01-30T13:44:40Z

@c3024 I've merged latest main please check now if you can run the iOS.

c3024 · 2024-01-30T13:54:19Z

Builds well on iOS 👍

Screen.Recording.2024-01-30.at.7.23.16.PM.mov

c3024 · 2024-01-30T13:55:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

bumpExpoAndroid.mp4

Android: mWeb Chrome

iOS: Native

bumpExpoiOS.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

bumpExpoChrome.mov

MacOS: Desktop

bumpExpoDesktop.mp4

github-actions · 2024-01-30T14:03:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35249/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/35249/NewExpensify.dmg	https://35249.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

kowczarz · 2024-01-30T14:37:15Z

It seems there was a problem with GitHub actions runner, because the iOS build just timed out without any error.

c3024

Working well on all platforms. 🚀

melvin-bot · 2024-01-30T14:54:41Z

🎯 @c3024, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #35409.

OSBotify · 2024-01-30T22:34:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-31T02:58:29Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-01-31T04:12:26Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T04:38:43Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T22:49:37Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

shubham1206agra · 2024-02-01T02:42:50Z

package.json

@@ -99,7 +100,7 @@
    "dom-serializer": "^0.2.2",
    "domhandler": "^4.3.0",
    "expensify-common": "git+ssh://[email protected]/Expensify/expensify-common.git#4a61536649cbfe49236a35bc7542b5dfd0767e4a",
-    "expo": "^50.0.0-preview.7",
+    "expo": "^50.0.3",
    "expo-image": "1.10.1",


Why this was not bumped in this PR?

Bump up Expo SDK to 50.0.3

22f363b

mountiny requested a review from francoisl January 26, 2024 14:24

kowczarz marked this pull request as ready for review January 26, 2024 14:45

kowczarz requested a review from a team as a code owner January 26, 2024 14:45

melvin-bot bot requested review from c3024 and removed request for a team January 26, 2024 14:45

francoisl added the Ready To Build label Jan 26, 2024

This comment has been minimized.

Sign in to view

eh2077 mentioned this pull request Jan 28, 2024

feat: add PDFThumbnail to preview PDF receipt #35255

Merged

50 tasks

kowczarz added 2 commits January 29, 2024 11:50

Update podfile lock

9389da7

update rn reanimated patch

df85ba5

kowczarz added 2 commits January 30, 2024 10:45

Merge remote-tracking branch 'expensify/main' into bump-up-expo-SDK-t…

26ff637

…o-50.0.3 # Conflicts: # package-lock.json # package.json

Post merge cleanup

dba2c36

kowczarz added 2 commits January 30, 2024 11:43

Post merge cleanup

f7cc9b7

Add missing package

205e947

Merge remote-tracking branch 'expensify/main' into bump-up-expo-SDK-t…

f8e9744

…o-50.0.3 # Conflicts: # package-lock.json

c3024 approved these changes Jan 30, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Jan 30, 2024

[HOLD for payment 2023-02-07] Payment issue for E/App PR#35249 #35409

Closed

francoisl approved these changes Jan 30, 2024

View reviewed changes

francoisl merged commit 3d0f8b8 into Expensify:main Jan 30, 2024
18 checks passed

francoisl mentioned this pull request Jan 30, 2024

[CRITICAL] Implement new Video Player components #32770

Closed

8 tasks

github-actions bot mentioned this pull request Jan 31, 2024

Deploy Checklist: New Expensify 2024-01-31 #35448

Closed

54 tasks

shubham1206agra reviewed Feb 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump up Expo SDK to 50.0.3 #35249

Bump up Expo SDK to 50.0.3 #35249

kowczarz commented Jan 26, 2024 •

edited by francoisl

Loading

melvin-bot bot commented Jan 26, 2024

This comment has been minimized.

francoisl commented Jan 26, 2024 •

edited

Loading

kowczarz commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

francoisl commented Jan 29, 2024

kowczarz commented Jan 29, 2024

francoisl commented Jan 29, 2024

mountiny commented Jan 29, 2024

c3024 commented Jan 30, 2024

mountiny commented Jan 30, 2024

github-actions bot commented Jan 30, 2024

mountiny commented Jan 30, 2024

c3024 commented Jan 30, 2024

c3024 commented Jan 30, 2024

github-actions bot commented Jan 30, 2024

kowczarz commented Jan 30, 2024

c3024 commented Jan 30, 2024

c3024 commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 30, 2024

kowczarz commented Jan 30, 2024

c3024 left a comment

melvin-bot bot commented Jan 30, 2024

OSBotify commented Jan 30, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

shubham1206agra Feb 1, 2024

Bump up Expo SDK to 50.0.3 #35249

Bump up Expo SDK to 50.0.3 #35249

Conversation

kowczarz commented Jan 26, 2024 • edited by francoisl Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 26, 2024

This comment has been minimized.

francoisl commented Jan 26, 2024 • edited Loading

kowczarz commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

francoisl commented Jan 29, 2024

kowczarz commented Jan 29, 2024

francoisl commented Jan 29, 2024

mountiny commented Jan 29, 2024

c3024 commented Jan 30, 2024

mountiny commented Jan 30, 2024

github-actions bot commented Jan 30, 2024

mountiny commented Jan 30, 2024

c3024 commented Jan 30, 2024

c3024 commented Jan 30, 2024

github-actions bot commented Jan 30, 2024

kowczarz commented Jan 30, 2024

c3024 commented Jan 30, 2024

c3024 commented Jan 30, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

github-actions bot commented Jan 30, 2024

kowczarz commented Jan 30, 2024

c3024 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 30, 2024

OSBotify commented Jan 30, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

shubham1206agra Feb 1, 2024

Choose a reason for hiding this comment

kowczarz commented Jan 26, 2024 •

edited by francoisl

Loading

francoisl commented Jan 26, 2024 •

edited

Loading

c3024 commented Jan 30, 2024 •

edited

Loading