Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'IOU' page to TypeScript #35253

Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
be682af
refactor(typescript): migrate iou page
pac-guerreiro Jan 26, 2024
546e43a
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Jan 26, 2024
cf5f1cd
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Feb 5, 2024
4ff2192
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Feb 7, 2024
3c16bee
chore(typescript): migrate IOU related components
pac-guerreiro Feb 7, 2024
96c467f
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Feb 9, 2024
b25f22f
chore: apply pull request suggestions
pac-guerreiro Feb 9, 2024
9eebd1b
fix: typing issues
pac-guerreiro Feb 9, 2024
9ee97a0
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Feb 15, 2024
264dbbc
chore: apply pull request feedback
pac-guerreiro Feb 16, 2024
45a08a8
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Feb 22, 2024
9ab98e0
chore: remove unused typescript expect error
pac-guerreiro Feb 22, 2024
b2ab8c6
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 11, 2024
0845c3e
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 13, 2024
54a4ac9
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 13, 2024
6f8fcb7
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 14, 2024
fad75a9
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 15, 2024
dfdb162
fix(typescript): type mismatches
pac-guerreiro Mar 15, 2024
c6b427b
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 18, 2024
a0655e1
refactor(typescript): apply pull request feedback
pac-guerreiro Mar 18, 2024
a1794d0
refactor(typescript): apply pull request feedback
pac-guerreiro Mar 18, 2024
521f2ba
fix: add missing dependency on useEffect
pac-guerreiro Mar 18, 2024
3b41c2e
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 20, 2024
c67fad2
refactor(typescript): apply pull request feedback
pac-guerreiro Mar 20, 2024
e554a10
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 22, 2024
6431baf
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 26, 2024
38be36d
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 26, 2024
2f643b2
refactor(typescript): apply pull request suggestions
pac-guerreiro Mar 26, 2024
ad93e44
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 28, 2024
49b4982
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
pac-guerreiro Mar 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…
…ypescript

# Conflicts:
#	src/libs/actions/IOU.ts
  • Loading branch information
pac-guerreiro committed Mar 11, 2024
commit b2ab8c6418e9ac451a56331ddd77d355741d43e2
2 changes: 1 addition & 1 deletion src/libs/actions/IOU.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2389,7 +2389,7 @@ function startSplitBill(
* @param sessionEmail - email of the current user
*/
function completeSplitBill(chatReportID: string, reportAction: OnyxTypes.ReportAction, updatedTransaction: OnyxEntry<OnyxTypes.Transaction>, sessionAccountID: number, sessionEmail: string) {
const currentUserEmailForIOUSplit = OptionsListUtils.addSMSDomainIfPhoneNumber(sessionEmail);
const currentUserEmailForIOUSplit = PhoneNumber.addSMSDomainIfPhoneNumber(sessionEmail);
const transactionID = updatedTransaction?.transactionID ?? '';
const unmodifiedTransaction = allTransactions[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.