Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS Migration] Improve Form #35584
[TS Migration] Improve Form #35584
Changes from 40 commits
4f109b2
5a9b7fa
1865489
ea73d4f
8a06c0a
ede25e5
35356da
c5e9982
fbadba9
6e2bf36
e4caa67
06ee35e
8b4f885
8db9304
488c935
94e6d41
b894733
ffd0a26
4488723
87e4ea1
16529f2
0a07743
30a91f0
ede62bd
06394df
4708fae
ef0b5de
737b148
cd2e3e5
dcf3fb9
bd4bb07
16c1089
e9be3f4
8b932c3
bec9ded
b9130ee
a931897
dfb9ae9
b9b1b00
d1baa7b
b0449c0
f716077
8062eb8
72407eb
a10a841
b138cc1
0d10ba1
575c163
dbd6335
611b6f3
a95392a
fe4aace
e11690d
820e63e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not seeing this earlier, but why are there all these types that are just
FormTypes.Form
, even though we have more specific types for these forms, such as the one defined insrc/types/form/EditTaskForm
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was adjusted at some point and I made a mistake while resolving conflicts. I'll fix it in a follow up 👍