Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update Account Settings] Preferences, About, Security #35672
[Update Account Settings] Preferences, About, Security #35672
Changes from 1 commit
0f80d69
d836214
bd0d930
beebe04
1b2d2a7
9571905
4397fc5
3124444
3a8cd2d
330fb72
9f2b8f8
1d0e5a9
c74a873
715eacd
426632c
b6d1789
3601b3f
3e44c6f
3769321
028d355
eab2a13
479203f
56fd657
42d1233
782d2ca
8941626
31e513d
a33f3a8
5f13923
1743d97
0375e27
0993456
a9ef0cc
f2ca240
5e5bce0
4f30355
404b3c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it hard to use same illustration with a different background. Why don't we just pass
illustrationBackgroundColor
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I theoretically couldn't use
colors
in components:DO NOT import colors.js into file
stated incolors.js
. So I put it here.Currently, we didn't have any case where we changed the background color of illustration. If someone needs it, he can possibly do that by passing
illustrationBackgroundColor
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I move it anyway, and import
colors
? But personally I think, that background color is closely related to the illustration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not.a blocker. Let's keep it as is for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! If internal decides we want to change it, I will do it as a follow-up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tmight be nice to add this as a follow up but I would say once we will need this dynamic which we dont right now as far as I know
Check failure on line 47 in src/pages/settings/Preferences/PreferencesPage.js
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be in dark mode i think
Screen.Recording.2024-02-14.at.4.08.20.AM.mov
@kosmydel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here