test lhn sidebar #35817

shubham1206agra · 2024-02-05T14:34:35Z

Details

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

luacmartins · 2024-02-05T14:57:59Z

@shubham1206agra thanks for the PR. It seems like we have a few failed tests. Would you mind taking a look at them?

luacmartins

I'm seeing Expected 3 arguments, but got 7. error for SidebarUtils.perf-test.ts. Can you update that so we can run that test since it's the main performance metric we'll be using in this PR?

shubham1206agra · 2024-02-05T15:03:01Z

I'm seeing Expected 3 arguments, but got 7. error for SidebarUtils.perf-test.ts. Can you update that so we can run that test since it's the main performance metric we'll be using in this PR?

Actually, I split the whole functionality into 2 different functions. Ones filter the reports and one sorts them.

fedirjh

@shubham1206agra It would be helpful if you could provide additional context about the PR. It appears that you have implemented a new approach in this PR.

fedirjh · 2024-02-05T15:21:31Z

src/components/LHNOptionsList/LHNOptionsList.tsx

+                    <FlatList
+                        data={data}
+                        testID="lhn-options-list-virtualized"
+                        keyExtractor={keyExtractor}
+                        renderItem={prepareItem}
+                        initialNumToRender={data.length}
+                    />


Why do we have this FlatList ?

@shubham1206agra Friendly bump.

fedirjh · 2024-02-05T15:23:52Z

src/components/LHNOptionsList/OptionRowLHNData.tsx

Let's include @youssef-lr's suggestion #33029 (comment) in this component.

shubham1206agra · 2024-02-05T17:42:56Z

@luacmartins I will open another draft PR with a different approach to compare the timings tomorrow.

shubham1206agra · 2024-02-06T15:24:05Z

@luacmartins This is the other PR #35907.

luacmartins

@shubham1206agra this seems like a different approach than what was suggested in the issue. Are you still working on this POC?

luacmartins · 2024-02-09T14:23:01Z

@fedirjh were you able to take a look at the latest commits?

fedirjh · 2024-02-09T21:45:37Z

@shubham1206agra friendly bump for #35817 (review) , Could you please provide additional context about the approach used in this PR? Thank you.

shubham1206agra · 2024-02-16T04:46:27Z

I am going to close this PR as it has some performance regressions. And it might create problems in the future.

test lhn sidebar

74acd49

shubham1206agra mentioned this pull request Feb 5, 2024

HIGH: [Polish] [$500] Finalize order of LHN in #focus mode #33029

Closed

luacmartins requested changes Feb 5, 2024

View reviewed changes

fedirjh reviewed Feb 5, 2024

View reviewed changes

shubham1206agra added 3 commits February 5, 2024 22:20

trying to fix test

960c3db

trying to fix test 2

315152e

trying to fix test 3

ff5da29

luacmartins reviewed Feb 8, 2024

View reviewed changes

shubham1206agra closed this Feb 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test lhn sidebar #35817

test lhn sidebar #35817

shubham1206agra commented Feb 5, 2024

luacmartins commented Feb 5, 2024

luacmartins left a comment

shubham1206agra commented Feb 5, 2024

fedirjh left a comment

fedirjh Feb 5, 2024

fedirjh Feb 9, 2024

fedirjh Feb 5, 2024

shubham1206agra commented Feb 5, 2024

shubham1206agra commented Feb 6, 2024

luacmartins left a comment

luacmartins commented Feb 9, 2024

fedirjh commented Feb 9, 2024

shubham1206agra commented Feb 16, 2024

test lhn sidebar #35817

test lhn sidebar #35817

Conversation

shubham1206agra commented Feb 5, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

luacmartins commented Feb 5, 2024

luacmartins left a comment

Choose a reason for hiding this comment

shubham1206agra commented Feb 5, 2024

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh Feb 5, 2024

Choose a reason for hiding this comment

fedirjh Feb 9, 2024

Choose a reason for hiding this comment

fedirjh Feb 5, 2024

Choose a reason for hiding this comment

shubham1206agra commented Feb 5, 2024

shubham1206agra commented Feb 6, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Feb 9, 2024

fedirjh commented Feb 9, 2024

shubham1206agra commented Feb 16, 2024