Fix/34608: Remove old CreatedPage #35853

brunovjk · 2024-02-05T19:51:53Z

Details

This is a part of #29107 and is all about removing the original components and any of the duplicated efforts.

Old Component: MoneyRequestDatePage.
New Component IOURequestStepDate.

Fixed Issues

$ #34608
PROPOSAL: #34608 (comment)

Tests

Create a new manual request.
While creating a new request, click on the date field.
Verify that the route displays /create/request/date/ ... backTo ...
After creating the request, click on the date field to edit.
Verify that the route displays /edit/request/date/ ... backTo ...
Create a new manual split bill.
While creating a new split bill, click on the date field.
Verify that the route displays /create/split/date/ ... backTo ...
After creating the new split bill:
Verify that the date didn't change and displays the date of today (known issue [$500] SplitBill date is incorrect when a date other than today is selected #36285).
Click on the date field to edit.
Verify that the changes are now applied.
Verify that everything else works well as before.

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Same above

PR Author Checklist

Screenshots/Videos

Android: Native

Android_.Native.mp4

Android: mWeb Chrome

iOS: Native

iOS_.Native.mp4

iOS: mWeb Safari

iOS_.mWeb.mp4

MacOS: Chrome / Safari

MacOS_Chrome.Safari.mp4

MacOS: Desktop

MacOS_.Desktop.mp4

melvin-bot · 2024-02-05T19:51:58Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

brunovjk · 2024-02-05T20:33:02Z

@DylanDylann I think I found a bug, also reproduced on 'staging'. After create a SplitBill and edit the 'date', open the split report, the created date is used, not the edited date. If you edit again it works fine.

Reproduce the bug in this PR

Reproduce.the.bug.in.this.PR.mp4

This bug was not introduced by this PR

Reproduce the bug on 'staging'

Reproduce.the.bug.on.staging.mp4

I'll revisit this first thing tomorrow.

brunovjk · 2024-02-06T20:12:20Z

@DylanDylann I've been investigating and it seems to be a backend issue. At the time of creating a 'SplitBill' and editing the date, the BE response 'created' date uses today's date, as if we hadn't edited. When we do the same with 'RequestMoney' everything works fine. Would you mind taking a look at it? Thank you :D

possible_BE_issue-fix_34608.mp4

DylanDylann · 2024-02-07T04:47:34Z

When making API, we don't pass created field as a param. So the BE always return date is today. I think we should fix this bug on this PR

cc @tgolen

brunovjk · 2024-02-07T09:39:36Z

@DylanDylann nice.. thank you.. Im on it :D

src/pages/iou/request/step/IOURequestStepDate.js

DylanDylann · 2024-02-08T08:06:12Z

@brunovjk Please fill all checklist

DylanDylann · 2024-02-08T08:13:04Z

@brunovjk also please fix this bug

brunovjk · 2024-02-08T10:04:47Z

@brunovjk also please fix this bug

Ok, Im still working on it, I had to leave yesterday, but today I'm 100% focused on it.

brunovjk · 2024-02-08T21:02:47Z

@DylanDylann, I have added the created parameter to type SplitBillParams. With the changes I made, the split transaction should have the correct created date, however the SplitBill response continues with today's date (In the example below, today is 02/08, and the created is 02/22).

Am I missing something here?

SplitBill optimisticData

SplitBill BE Response

brunovjk · 2024-02-08T21:09:53Z

also please fix #35853 (comment)

Additionally I think we should update the tests too. I suggest splitting this PR into two for clarity. The current scope seems extensive, and as the bug wasn't introduced here anyway, it might be better to handle it separately. I'm committed to creating another PR for the bug fix. Your thoughts?

DylanDylann · 2024-02-09T07:07:44Z

@tgolen For this bug, It seems we also need to update from the BE side. Because this bug isn't caused by this PR, it existed before. Should we create another issue to fix it to avoid delaying this PR

tgolen · 2024-02-09T17:29:41Z

For that backend bug, I will report it and have a separate issue created for it so it can be handled outside of this PR. I think it's OK to merge this one without the BE bug fixed yet.

This reverts commit 3fc8ac6.

src/pages/iou/request/step/IOURequestStepDate.js

DylanDylann · 2024-02-10T12:02:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

date-android.mp4

Android: mWeb Chrome

dat-c.mp4

iOS: Native

date-ios.mp4

iOS: mWeb Safari

date-s.mp4

MacOS: Chrome / Safari

date-web.mp4

MacOS: Desktop

date-des.mp4

…nd policyCategories' params

brunovjk · 2024-02-10T16:12:07Z

~~I am testing on all platforms. Please wait.~~ I'm having trouble testing on Android: mWeb Chrome, but on the rest looks good. Thanks.

src/pages/iou/request/step/IOURequestStepDate.js

DylanDylann · 2024-02-11T07:29:54Z

The changes look good. And it works well.

OSBotify · 2024-02-12T15:30:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-15T05:24:34Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

brunovjk requested a review from a team as a code owner February 5, 2024 19:51

melvin-bot bot removed the request for review from a team February 5, 2024 19:51

melvin-bot bot requested a review from DylanDylann February 5, 2024 19:51

brunovjk closed this Feb 7, 2024

brunovjk force-pushed the fix/34608 branch from 7afcac0 to 82e93b8 Compare February 7, 2024 18:07

Merge branch 'Expensify:main' into fix/34608

1692286

brunovjk reopened this Feb 7, 2024

brunovjk added 2 commits February 7, 2024 16:39

In 'IOURequestStepDate' get 'splitDraftTransaction' from Onyx and use it

c084c92

run prettier

58c09d3

DylanDylann reviewed Feb 8, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepDate.js Outdated Show resolved Hide resolved

brunovjk and others added 3 commits February 8, 2024 07:56

Remove 'trim' from 'created' field

03f08d5

Merge branch 'Expensify:main' into fix/34608

d00fca8

Added 'created' parameter to SplitBillParams type

3fc8ac6

Merge branch 'Expensify:main' into fix/34608

aa446db

brunovjk and others added 4 commits February 9, 2024 21:01

Merge branch 'main' into fix/34608

e4d0a94

Remove backTo for money request view

85c3028

Revert "Added 'created' parameter to SplitBillParams type"

06e11dc

This reverts commit 3fc8ac6.

run prettier

473e188

DylanDylann reviewed Feb 10, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepDate.js Outdated Show resolved Hide resolved

DylanDylann reviewed Feb 10, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepDate.js Outdated Show resolved Hide resolved

src/pages/iou/request/step/IOURequestStepDate.js Outdated Show resolved Hide resolved

brunovjk and others added 3 commits February 10, 2024 10:20

Merge branch 'Expensify:main' into fix/34608

8da343e

Update 'IOU.updateMoneyRequestDate' call to use 'policy, policyTags a…

7e3e974

…nd policyCategories' params

Use 'isEditing'

422ab7e

Merge branch 'Expensify:main' into fix/34608

484fa5c

brunovjk requested a review from DylanDylann February 10, 2024 20:59

brunovjk mentioned this pull request Feb 10, 2024

[$500] SplitBill date is incorrect when a date other than today is selected #36285

Closed

6 tasks

DylanDylann reviewed Feb 11, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepDate.js Outdated Show resolved Hide resolved

Organize comment

588d43a

brunovjk requested a review from DylanDylann February 11, 2024 11:19

DylanDylann approved these changes Feb 12, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen February 12, 2024 01:59

tgolen approved these changes Feb 12, 2024

View reviewed changes

tgolen merged commit a7c3ee6 into Expensify:main Feb 12, 2024
17 checks passed

brunovjk deleted the fix/34608 branch February 12, 2024 15:48

github-actions bot mentioned this pull request Feb 13, 2024

Deploy Checklist: New Expensify 2024-02-13 #36429

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/34608: Remove old CreatedPage #35853

Fix/34608: Remove old CreatedPage #35853

brunovjk commented Feb 5, 2024 •

edited

Loading

melvin-bot bot commented Feb 5, 2024

brunovjk commented Feb 5, 2024

brunovjk commented Feb 6, 2024

DylanDylann commented Feb 7, 2024 •

edited

Loading

brunovjk commented Feb 7, 2024

DylanDylann commented Feb 8, 2024

DylanDylann commented Feb 8, 2024

brunovjk commented Feb 8, 2024

brunovjk commented Feb 8, 2024 •

edited

Loading

brunovjk commented Feb 8, 2024 •

edited

Loading

DylanDylann commented Feb 9, 2024

tgolen commented Feb 9, 2024

DylanDylann commented Feb 10, 2024 •

edited

Loading

brunovjk commented Feb 10, 2024 •

edited

Loading

DylanDylann commented Feb 11, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 15, 2024

Fix/34608: Remove old CreatedPage #35853

Fix/34608: Remove old CreatedPage #35853

Conversation

brunovjk commented Feb 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 5, 2024

brunovjk commented Feb 5, 2024

brunovjk commented Feb 6, 2024

DylanDylann commented Feb 7, 2024 • edited Loading

brunovjk commented Feb 7, 2024

DylanDylann commented Feb 8, 2024

DylanDylann commented Feb 8, 2024

brunovjk commented Feb 8, 2024

brunovjk commented Feb 8, 2024 • edited Loading

brunovjk commented Feb 8, 2024 • edited Loading

DylanDylann commented Feb 9, 2024

tgolen commented Feb 9, 2024

DylanDylann commented Feb 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

brunovjk commented Feb 10, 2024 • edited Loading

DylanDylann commented Feb 11, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 15, 2024

brunovjk commented Feb 5, 2024 •

edited

Loading

DylanDylann commented Feb 7, 2024 •

edited

Loading

brunovjk commented Feb 8, 2024 •

edited

Loading

brunovjk commented Feb 8, 2024 •

edited

Loading

DylanDylann commented Feb 10, 2024 •

edited

Loading

brunovjk commented Feb 10, 2024 •

edited

Loading