Tweaking bubble icons and changing comment action menu #36467
Conversation
melvin-bot
bot
requested review from
Santhosh-Sellavel
and removed request for
a team
|
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@sobitneupane @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
@dubielzyk-expensify You need to complete the PR Author Checklist to get it merged.
The only change made is changing the icon in ContextMenuActions, right?
Co-authored-by: Sobit Neupane <[email protected]>
Yep just changing the icon and adding the icons in our repo. I'll do the checklist if I manage 😂 A designer with limited coding skills so bear with me |
|
To avoid spending too much back and forth, I might just need some help finishing and merging this PR. @sobitneupane is this something you could help with? 😇 |
|
@dubielzyk-expensify Off course. How can I help you? |
| @@ -180,7 +180,7 @@ const ContextMenuActions: ContextMenuAction[] = [ | |||
| { | |||
| isAnonymousAction: false, | |||
| textTranslateKey: 'reportActionContextMenu.replyInThread', | |||
| icon: Expensicons.ChatBubbleAdd, | |||
There was a problem hiding this comment.
Since we aren't using ChatBuubleAdd any more, should we remove it from src/components/Icon/Expensicons.ts and assets as well? Or will we be using it in some other place?
There was a problem hiding this comment.
I suspect we'll use it later. As we still have it in our Figma library I'd be keen to keep it for now :)
Finishing off the PR checklist and merge 😇 I realize my skills only takes me to actually changing the code, but running tests etc isn't something I can do. 😅 Sorry! |
|
@dubielzyk-expensify I can review the PR and complete the checklist. However, you will need to tick all the checkboxes in the PR Author Checklist in the PR body (It is required to get the GH tests passed). Additionally, there appears to be a conflict on the PR. Since I may not have access to commit to the PR, you will need to resolve the merge conflict. cc: @shawnborton |
|
I think it might be easier to just delete this pull request and externalize it. I'm not even sure if I did the code 100% correct. |
|
I have read the CLA Document and I hereby sign the CLA |
|
Ready for your review @sobitneupane :D Massive thanks to @techievivek for helping me get here ❤️ |
There was a problem hiding this comment.
Screenshots/Videos
Android: Native
Screen.Recording.2024-02-29.at.20.32.55.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2024-02-29.at.20.28.24.mov
iOS: mWeb Safari
Screen.Recording.2024-02-29.at.20.29.16.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-29.at.20.25.27.mov
MacOS: Desktop
Screen.Recording.2024-02-29.at.20.27.04.mov
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
|
🎯 @sobitneupane, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #37506. |
|
@shawnborton all yours |
|
I’m OOO for the next couple of days so feel free to merge without me!
…On Thu, Feb 29, 2024 at 1:09 PM Carlos Alvarez ***@***.***> wrote:
@shawnborton <https://github.com/shawnborton> all yours
—
Reply to this email directly, view it on GitHub
<#36467 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARWH5XWAF2WCUJSFGGPB4LYV5XGZAVCNFSM6AAAAABDIAQ5XOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRGY4DMMRWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.46-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.46-2 🚀
|
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/366491
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop