Revert "Simplify native attachment gallery paging context and improve code" #36524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
pecanoro
approved these changes
Feb 14, 2024
pecanoro
deleted the
revert-34080-@chrispader/simplify-native-attachment-carousel
branch
|
@pecanoro looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Tim explained in the description why we are doing a straight revert, not an emergency |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
73 tasks
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.42-0 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #34080
I accidentally merged the original PR without the reviewer checklist being completed and without all the platforms tested.
There is no need to test this, since it's a straight revert and we want it reverted before it gets pushed to staging.