Simplify native attachment gallery paging context and improve code #36534

kirillzyusko · 2024-02-14T18:21:53Z

Details

Based on #33756. Check this for actual diff.

This PR removes unnecessary prop-drilling and improves how we use the AttachmentCarouselPagerContext.

It also improves many of the components used in the (native) attachment gallery and simplifies some rendering logic.

The MultiGestureCanvas component is becoming more generic and can therefore be used in other cases more easily. The Lightbox component takes control of the adapted behaviour while in an attachment carousel.

Fixed Issues

$ #36034
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Go to a report with attachments
Open an (image) attachment
Check that the attachment carousel is working
Check that image gestures/transformations are working (pinching, panning, double tap, swiping)

Offline tests

None needed.

QA Steps

Verify that no errors appear in the JS console

Same as in Tests.

PR Author Checklist

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-08.at.09.54.30.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

simplify-web-demo.mov

MacOS: Desktop

Screen.Recording.2024-02-14.at.19.20.42.mov

melvin-bot · 2024-02-14T18:21:58Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kirillzyusko · 2024-02-14T18:22:40Z

@tgolen may I ask you to review again? I've attached videos for desktop/web (but they are very short, because GH has limits for uploading video files).

tgolen

It looks just like how I remember it 😅

kirillzyusko · 2024-02-14T20:03:36Z

It looks just like how I remember it 😅

Anything else is required from my side?.. I think I attached all necessary videos and it was the only one thing that I had to do, right?

pecanoro · 2024-02-14T20:22:57Z

@mollfpr Can you test the PR and complete the checklist, please?

mollfpr · 2024-02-15T01:11:02Z

@pecanoro On it!

mollfpr · 2024-02-15T17:27:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

36534.Android.mp4

Android: mWeb Chrome

36534.mWeb-Chrome.mp4

iOS: Native

36534.iOS.mp4

iOS: mWeb Safari

36534.mWeb-Safari.mp4

MacOS: Chrome / Safari

36534.Web.mp4

MacOS: Desktop

36534.Desktop.mp4

Note: If you notice in the videos on mWeb/Safari and mWeb/Android, there's abnormal things happen. On the mWeb/Safari, is open wrong attachment. For mWeb/Android, there's a blinking when sliding the attachment. Both issues are also happen on the staging. So not because this PR.

tgolen · 2024-02-15T17:51:20Z

I'll let you merge this one @pecanoro!

OSBotify · 2024-02-15T18:27:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:48:58Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-26T20:55:02Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

paultsimura · 2024-03-14T09:46:23Z

src/components/MultiGestureCanvas/index.tsx

@@ -126,8 +112,6 @@ function MultiGestureCanvas({
    const reset = useWorkletCallback((animated: boolean, callback?: () => void) => {
        stopAnimation();

-        pinchScale.value = 1;


This removal caused a bug: #37248

feat: Simplify native attachment gallery paging context and improve code

1ec5883

kirillzyusko requested a review from a team as a code owner February 14, 2024 18:21

melvin-bot bot requested review from mollfpr and removed request for a team February 14, 2024 18:21

tgolen approved these changes Feb 14, 2024

View reviewed changes

pecanoro approved these changes Feb 14, 2024

View reviewed changes

mollfpr approved these changes Feb 15, 2024

View reviewed changes

melvin-bot bot requested a review from pecanoro February 15, 2024 17:50

pecanoro approved these changes Feb 15, 2024

View reviewed changes

pecanoro merged commit fe1cb5b into Expensify:main Feb 15, 2024
16 of 18 checks passed

github-actions bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

paultsimura reviewed Mar 14, 2024

View reviewed changes

paultsimura mentioned this pull request Mar 14, 2024

[HOLD for payment 2024-03-14] [$250] iOS - Image - Maximum zoom is applied after zooming out #37248

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify native attachment gallery paging context and improve code #36534

Simplify native attachment gallery paging context and improve code #36534

kirillzyusko commented Feb 14, 2024

melvin-bot bot commented Feb 14, 2024

kirillzyusko commented Feb 14, 2024

tgolen left a comment

kirillzyusko commented Feb 14, 2024

pecanoro commented Feb 14, 2024

mollfpr commented Feb 15, 2024

mollfpr commented Feb 15, 2024 •

edited

Loading

tgolen commented Feb 15, 2024

OSBotify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

OSBotify commented Feb 26, 2024

paultsimura Mar 14, 2024

Simplify native attachment gallery paging context and improve code #36534

Simplify native attachment gallery paging context and improve code #36534

Conversation

kirillzyusko commented Feb 14, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 14, 2024

kirillzyusko commented Feb 14, 2024

tgolen left a comment

Choose a reason for hiding this comment

kirillzyusko commented Feb 14, 2024

pecanoro commented Feb 14, 2024

mollfpr commented Feb 15, 2024

mollfpr commented Feb 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

tgolen commented Feb 15, 2024

OSBotify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

OSBotify commented Feb 26, 2024

paultsimura Mar 14, 2024

Choose a reason for hiding this comment

mollfpr commented Feb 15, 2024 •

edited

Loading