-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🍒 Cherry pick PR #36497 to staging 🍒 #36548
Conversation
Co-authored-by: Getabalew Tesfaye <[email protected]>
This reverts commit a64ab19.
Co-authored-by: Abdelhafidh Belalia <[email protected]>
Reorganized code by introducing shared types in `SignInPageLayoutProps`, which streamlined the props of all components in the SignInPageLayout. The shared types are now used in Footer, SignInPageContent, SignInPageLayout, SignInHeroCopy, SignInPageHero, and SignInHeroImage components. Files have been moved to the SignInPageLayout directory for better organization.
…moved 'backTo' from the Navigation.goBack function
Add the policy tax trackingEnabled
fixes : copy to clipboard mention whisper message and hide mention whisper on any action
fix: Add fallback icons for thumbnails
[No QA] [TS migration] Migrate 'UrlTest.js' test to TypeScript
Fixed currency pressable ui and padding issues
(cherry picked from commit e9bd5cd)
Fixed currency pressable ui and padding issues (cherry picked from commit af1026e)
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
This pull request has merge conflicts and can not be automatically merged. 😞 |
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
Fixed the merge conflicts |
Hmm it says there are 627 commits now and lots of changes, I don't think we wanted to merge Like comparing to a cherry pick PR from a few days ago: #36330 - the conflicts were just fixed manually on the branch |
Ah crap, I think you're right - let me close and re-trigger the CP |
🍒 Cherry pick #36497 to staging 🍒
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.