-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor IOU Components to /ReportActionItem folder & rename #3674
Conversation
While not that important, it would be great to get this PR merged ASAP as it touches files that are likely to have conflicts with other IOU issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.71-1🚀
|
🚀 Deployed to production in version: 1.0.73-3🚀
|
CC @tgolen -- as you suggested this change in an older PR review
Details
Simply refactors the three
ReportActionItemIOU...
components to a new package to simplify the naming. The components areIOUPreview
,IOUAction
, andIOUQuote
and all relate to the Preview component -- which is what we should test.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/164356
Tests
We need to review the IOU flows to ensure the regression didn't break anything. Please do the following and raise any issues that occur:
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android