[Audit][Implementation] - Reduce Redundant Operations

src/CONST.ts

@@ -37,10 +37,21 @@ const keyInputRightArrow = KeyCommand?.constants?.keyInputRightArrow ?? 'keyInpu
 // describes if a shortcut key can cause navigation
 const KEYBOARD_SHORTCUT_NAVIGATION_TYPE = 'NAVIGATION_SHORTCUT';
 
+const chatTypes = {
+    POLICY_ANNOUNCE: 'policyAnnounce',
+    POLICY_ADMINS: 'policyAdmins',
+    DOMAIN_ALL: 'domainAll',
+    POLICY_ROOM: 'policyRoom',
+    POLICY_EXPENSE_CHAT: 'policyExpenseChat',
+    SELF_DM: 'selfDM',
+} as const;
+
 // Explicit type annotation is required
 const cardActiveStates: number[] = [2, 3, 4, 7];
 
 const CONST = {
+    MERGED_ACCOUNT_PREFIX: 'MERGED_',
+    DEFAULT_POLICY_ROOM_CHAT_TYPES: [chatTypes.POLICY_ADMINS, chatTypes.POLICY_ANNOUNCE, chatTypes.DOMAIN_ALL],
     ANDROID_PACKAGE_NAME,
     ANIMATED_TRANSITION: 300,
     ANIMATED_TRANSITION_FROM_VALUE: 100,
@@ -685,14 +696,7 @@ const CONST = {
             IOU: 'iou',
             TASK: 'task',
         },
-        CHAT_TYPE: {
-            POLICY_ANNOUNCE: 'policyAnnounce',
-            POLICY_ADMINS: 'policyAdmins',
-            DOMAIN_ALL: 'domainAll',
-            POLICY_ROOM: 'policyRoom',
-            POLICY_EXPENSE_CHAT: 'policyExpenseChat',
-            SELF_DM: 'selfDM',
-        },
+        CHAT_TYPE: chatTypes,
         WORKSPACE_CHAT_ROOMS: {
             ANNOUNCE: '#announce',
             ADMINS: '#admins',

src/libs/LocalePhoneNumber.ts

@@ -1,5 +1,6 @@
 import Str from 'expensify-common/lib/str';
 import Onyx from 'react-native-onyx';
+import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import {parsePhoneNumber} from './PhoneNumber';
 
@@ -18,6 +19,10 @@ function formatPhoneNumber(number: string): string {
         return '';
     }
 
+    // do not parse the string, if it doesn't contain the SMS domain and it's not a phone number
+    if (number.indexOf(CONST.SMS.DOMAIN) === -1 && !CONST.REGEX.DIGITS_AND_PLUS.test(number)) {
+        return number;
+    }
     const numberWithoutSMSDomain = Str.removeSMSDomain(number);
     const parsedPhoneNumber = parsePhoneNumber(numberWithoutSMSDomain);
 

src/libs/Localize/index.ts

@@ -12,6 +12,7 @@ import type {Locale} from '@src/types/onyx';
 import type {ReceiptError} from '@src/types/onyx/Transaction';
 import LocaleListener from './LocaleListener';
 import BaseLocaleListener from './LocaleListener/BaseLocaleListener';
+import type BaseLocale from './LocaleListener/types';
 
 // Current user mail is needed for handling missing translations
 let userEmail = '';
@@ -93,11 +94,69 @@ function translate<TKey extends TranslationPaths>(desiredLanguage: 'en' | 'es' |
     throw new Error(`${phraseKey} was not found in the default language`);
 }
 
+/**
+ * Map to store translated values for each locale.
+ * This is used to avoid translating the same phrase multiple times.
+ *
+ * The data is stored in the following format:
+ *
+ * {
+ *  "name": "Name",
+ * }
+ *
+ * Note: We are not storing any translated values for phrases with variables,
+ * as they have higher chance of being unique, so we'll end up wasting space
+ * in our cache.
+ */
+const TRANSLATED_VALUES_EN = new Map<string, string>();
+const TRANSLATED_VALUES_ES = new Map<string, string>();
+const TRANSLATED_VALUES_ES_ES = new Map<string, string>();
+const TRANSLATED_VALUES_ES_ONFIDO = new Map<string, string>();
+
+/**
+ * Returns the map for the given locale.
+ */
+function getTranslatedValuesMap(locale: BaseLocale) {
+    switch (locale) {
+        case CONST.LOCALES.ES_ES:
+            return TRANSLATED_VALUES_ES_ES;
+        case CONST.LOCALES.ES_ES_ONFIDO:
+            return TRANSLATED_VALUES_ES_ONFIDO;
+        case CONST.LOCALES.ES:
+            return TRANSLATED_VALUES_ES;
+        case CONST.LOCALES.DEFAULT:
+        default:
+            return TRANSLATED_VALUES_EN;
+    }
+}
+
 /**
  * Uses the locale in this file updated by the Onyx subscriber.
  */
 function translateLocal<TKey extends TranslationPaths>(phrase: TKey, ...variables: PhraseParameters<Phrase<TKey>>) {
-    return translate(BaseLocaleListener.getPreferredLocale(), phrase, ...variables);
+    const preferredLocale = BaseLocaleListener.getPreferredLocale();
+    const key = `${phrase}`;
+    const isVariablesEmpty = variables.length === 0;
+
+    // Get the map for the preferred locale
+    const map = getTranslatedValuesMap(preferredLocale);
+
+    // Directly access and assign the translated value from the cache, instead of
+    // going through map.has() and map.get() to avoid multiple lookups.
+    const valueFromCache = map.get(key);
+
+    // If the phrase is already translated, return the translated value
+    if (valueFromCache) {
+        return valueFromCache;
+    }
+    const translatedText = translate(preferredLocale, phrase, ...variables);
+
+    // We don't want to store translated values for phrases with variables
+    if (isVariablesEmpty) {
+        // We set the translated value in the cache
+        map.set(key, translatedText);
+    }
+    return translatedText;
 }
 
 /**

src/libs/PersonalDetailsUtils.ts

@@ -24,15 +24,27 @@ Onyx.connect({
     },
 });
 
+// Index for the substring method to remove the merged account prefix.
+const substringStartIndex = CONST.MERGED_ACCOUNT_PREFIX.length;
+
 function getDisplayNameOrDefault(passedPersonalDetails?: Partial<PersonalDetails> | null, defaultValue = '', shouldFallbackToHidden = true, shouldAddCurrentUserPostfix = false): string {
-    let displayName = passedPersonalDetails?.displayName ? passedPersonalDetails.displayName.replace(CONST.REGEX.MERGED_ACCOUNT_PREFIX, '') : '';
+    let displayName = passedPersonalDetails?.displayName ?? '';
+
+    // If the displayName starts with the merged account prefix, remove it.
+    if (displayName.startsWith(CONST.MERGED_ACCOUNT_PREFIX)) {
+        displayName = displayName.substring(substringStartIndex);
+    }
+
     if (shouldAddCurrentUserPostfix && !!displayName) {
         displayName = `${displayName} (${Localize.translateLocal('common.you').toLowerCase()})`;
     }
 
-    const fallbackValue = shouldFallbackToHidden ? Localize.translateLocal('common.hidden') : '';
-
-    return displayName || defaultValue || fallbackValue;
+    // If displayName exists, return it early so we don't have to allocate
+    // memory for the fallback string.
+    if (displayName) {
+        return displayName;
+    }
+    return defaultValue || (shouldFallbackToHidden ? Localize.translateLocal('common.hidden') : '');
 }
 
 /**

src/libs/ReportUtils.ts

@@ -777,7 +777,7 @@ function isAnnounceRoom(report: OnyxEntry<Report>): boolean {
  * Whether the provided report is a default room
  */
 function isDefaultRoom(report: OnyxEntry<Report>): boolean {
-    return [CONST.REPORT.CHAT_TYPE.POLICY_ADMINS, CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE, CONST.REPORT.CHAT_TYPE.DOMAIN_ALL].some((type) => type === getChatType(report));
+    return CONST.DEFAULT_POLICY_ROOM_CHAT_TYPES.some((type) => type === getChatType(report));
 }
 
 /**